We hold these locks for a short amount of time anyway, and using an
async lock could cause parallel sends to happen in an order different
than the order in which `send`/`request` was called.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
5a889b0
Merge pull request #329 from zed-industries/fix-newline-in-multibuffer
Click to expand commit body
Fix cursor position when inserting newlines on a repeated excerpt
Max Brunsfeld
created
89ead1c
Merge pull request #314 from zed-industries/auto-connect
Click to expand commit body
Auto-connect to server on startup if credentials are on the keychain
Antonio Scandurra
created
c168201
Fix cursor position when inserting newlines on a repeated excerpt
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Antonio Scandurra
,
Nathan Sobo
, and
Max Brunsfeld
created
58e45dd
Merge pull request #328 from zed-industries/fix-multibuffer-anchors
Click to expand commit body
Randomize test multibuffer anchors and fix resulting issues
Antonio Scandurra
created
aa543a4
Ensure selections stay sorted after refreshing them
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
e70b728
Verify `Anchor::buffer_id` before resolving it or comparing it
Click to expand commit body
This commit also verifies some properties about anchor resolution in the
multibuffer randomized test.
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra
and
Nathan Sobo
created
2d5e722
Merge pull request #325 from zed-industries/fix-more-subscription-panics
Click to expand commit body
Don't register an entity ID extractor for non-entity subscriptions
Antonio Scandurra
created
d7fcb04
Don't register an entity ID extractor for non-entity subscriptions
Click to expand commit body
This commit fixes a panic that could occur when registering N subscriptions for
N entities of the same kind. Before, when dropping the first of the
subscriptions, we would remove the entity ID extractor as well. This was,
however, used by all the other N - 1 subscriptions which would then start
losing messages. In addition, dropping yet another subscription of that kind
would result in a panic, because we wouldn't find the extractor in the map
upon invoking `Subscription::drop`.
With this change we will avoid removing the ID extractor when dropping a
subscription. Crucially, we also avoid inserting extractors for simple message
subscriptions. This enables these non-entity subscriptions to be dropped and
re-registered without seeing a "registered handler for the same message twice"
panic.
Antonio Scandurra
created
2ea78c5
Merge pull request #320 from zed-industries/more-diagnostics-polish
Click to expand commit body
Keep the cursor at the top when first opening the project diagnostics view
Max Brunsfeld
created
a0a5583
In diagnostics editor, attempt to open excerpts in a different pane
Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld
and
Nathan Sobo
created
747d9e8
Add files to project diagnostics view in order