e436b82
acp: Use `ResourceLink` for agents that don't support embedded context (#36687)
Click to expand commit body
The completion provider was already limiting the mention kinds according
to `acp::PromptCapabilities`. However, it was still using
`ContentBlock::EmbeddedResource` when
`acp::PromptCapabilities::embedded_context` was `false`. We will now use
`ResourceLink` in that case making it more complaint with the
specification.
Release Notes:
- N/A
Agus Zubiaga
created
20710a4
Fix more improper uses of the `buffer_id` field of `Anchor` (#36636)
Click to expand commit body
Follow-up to #36524
Release Notes:
- N/A
Cole Miller
created
ca67e06
Show excerpt dividers in `without_headers` multibuffers (#36647)
Click to expand commit body
Release Notes:
- Fixed diff cards in agent threads not showing dividers between
disjoint edited regions.
Cole Miller
created
7f95310
acp: Detect gemini auth errors and show a button (#36641)
Click to expand commit body
Closes #ISSUE
Release Notes:
- N/A
Conrad Irwin
created
bb32d45
acp: Hide history unless in native agent (#36644)
Click to expand commit body
Release Notes:
- N/A
Conrad Irwin
created
79064d1
acp: Use file icons for edit tool cards when ToolCallLocation is known (#36684)
This PR adds a temporary workaround to supress "Aborted" errors from
Gemini when cancelling generation. This won't be needed once
https://github.com/google-gemini/gemini-cli/pull/6656 is generally
available.
Release Notes:
- N/A
8e57f63
acp: Hide feedback buttons for external agents (#36630)
Click to expand commit body
Release Notes:
- N/A
Agus Zubiaga
created
1ee07a4
acp: Rename `assistant::QuoteSelection` and support it in agent2 threads (#36628)
Click to expand commit body
Release Notes:
- N/A
Cole Miller
created
b070dc6
acp: Suggest installing gemini@preview instead of latest (#36629)
Click to expand commit body
Release Notes:
- N/A
Agus Zubiaga
created
15e451c
thread_view: Add recent history entries & adjust empty state (#36625)
Click to expand commit body
Release Notes:
- N/A
Danilo Leal
created
401a604
acp thread view: Do not go into editing mode if unsupported (#36623)
Click to expand commit body
Release Notes:
- N/A
Agus Zubiaga
created
e9a1404
agent2: Clean up tool descriptions (#36619)
Click to expand commit body
schemars was passing along the newlines from the doc comments. This
should make these closer to the markdown file versions we had in the old
agent.
Release Notes:
- N/A
2813073
message editor: Only allow types of content the agent can handle (#36616)
Click to expand commit body
Uses the new
[`acp::PromptCapabilities`](https://github.com/zed-industries/agent-client-protocol/blob/a39b7f635d67528f0a4e05e086ab283b9fc5cb93/rust/agent.rs#L194-L215)
to disable non-file mentions and images for agents that don't support
them.
Release Notes:
- N/A
- **clippy: Fix println-empty-string**
- **clippy: non-minimal-cfg**
Related to #36577
Release Notes:
- N/A
Piotr Osiewicz
created
b6722ca
Remove special case for singleton buffers from `MultiBufferSnapshot::anchor_at` (#36524)
Click to expand commit body
This may be responsible for a panic that we've been seeing with
increased frequency in agent2 threads.
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Bennet Bo Fenner
and
Ben Brandt
created
d0fb612
Fix scrollbar flicker when streaming agent2 response (#36606)
Click to expand commit body
This was caused by calling `list_state.splice` on updated entries. We
don't need to splice the entry, as we'll recompute its measurements
automatically when we render it.
Release Notes:
- N/A
Antonio Scandurra
created
699f58a
Capture telemetry when requesting completions in agent2 (#36600)
de12633
Wait for agent2 feature flag before loading panel (#36583)
Click to expand commit body
Release Notes:
- N/A
Antonio Scandurra
created
6ed29fb
Enforce style lints which do not have violations (#36580)
Click to expand commit body
Release Notes:
- N/A
tidely
created
4ee565c
Fix mentions roundtrip from/to database and other history bugs (#36575)
Click to expand commit body
Release Notes:
- N/A
Antonio Scandurra
created
f80a0ba
Move clippy lints which aren't apart of the style category (#36579)
Click to expand commit body
Move lints which aren't apart of the style category.
Motivation: They might get accidentally get reverted when we turn the
style category on again and remove the manual lint enforcements.
Release Notes:
- N/A
This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.
A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.
I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.
Release Notes:
- N/A
tidely
created
cf7c64d
lints: A bunch of extra style lint fixes (#36568)
Click to expand commit body
- **lints: Fix 'doc_lazy_continuation'**
- **lints: Fix 'doc_overindented_list_items'**
- **inherent_to_string and io_other_error**
- **Some more lint fixes**
- **lints: enable bool_assert_comparison, match_like_matches_macro and
wrong_self_convention**
Release Notes:
- N/A
Piotr Osiewicz
created
a32a264
agent2: Use correct completion intent when generating summary (#36573)
Click to expand commit body
Release Notes:
- N/A
Bennet Bo Fenner
created
0a80209
agent2: Fix remaining update_model_request_usage todos (#36570)
Click to expand commit body
Release Notes:
- N/A
Bennet Bo Fenner
created
83d361b
Add more string and comment overrides (#36566)
Click to expand commit body
Follow-up to #36469
Part of the issue was that we hadn't defined comment and string
overrides for some languages. Hence, even after the fix edit predictions
would show up in comments for me in e.g. JSONC files.
This PR adds some more overrides where possible for this repo to ensure
this happens less frequently.
Release Notes:
- N/A
Finn Evers
created
4290f04
agent2: Fix token count not updating when changing model/toggling burn mode (#36562)
Click to expand commit body
Release Notes:
- N/A
---------
Co-authored-by: Antonio Scandurra <me@as-cii.com>