e585bc7
Add retries to rescan test that uses the real file system
We could potentially use a fake file system, but this should avoid flaky tests in the short run. Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
e54d6f6
Merge pull request #366 from zed-industries/style-project-diagnostics
Style project diagnostics
Nathan Sobo created
0263ea2
Style diagnostic header's border in light and dark theme
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
dedd5d6
Fix blending of quad's border with background
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
3f6960b
Position underlines at a distance proportional to the line descent
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
b9b2556
Display squiggly underlines underneath text with diagnostics
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
52594fe
WIP: Start on squiggly underlines
Antonio Scandurra created
a890787
Render header blocks as horizontall fixed (like the gutter)
Tweak editor layout to perform horizontal autoscroll before laying out the blocks, so that they can access the scroll position.
Max Brunsfeld created
f199340
Account for editor's full scroll width when laying out blocks
Compute the editor's scroll width earlier in layout and store it on the layout state, rather than computing it repeatedly.
Max Brunsfeld created
cefb639
Tweak diagnostic header styling
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
e04e929
Render diagnostic status bar icon with icons
Max Brunsfeld created
dbe9698
Show icons and counts in the project diagnostics tab
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
c9b4bb7
Merge branch 'project-diagnostics-pinned-tab' into style-project-diagnostics
Max Brunsfeld created
78b57e4
Scale diagnostic header and message text with editor font
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
0c6fd15
Scale diagnostic headers icons with editor font and right align w/ line numbers
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
121b45e
Sanitize language server diagnostics coming from Rust
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
7250974
Style block decorations
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
65d4c33
Format messages within backticks using bold instead of with a background
Antonio Scandurra created
7e55353
Show error code in diagnostic header
Antonio Scandurra created
ec0ca2a
Display icon next to primary message
Antonio Scandurra created
e7ec016
Restyle diagnostic headers
Antonio Scandurra created
b319bda
Merge pull request #363 from zed-industries/remote-go-to-definition
Make go-to-definition work for guests
Max Brunsfeld created
0cfb9ff
Add random delays in FakeFs
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
2b8685c
Insert random delays when sending and receiving websocket messages in tests
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
d241ab6
Don't store operations for remote buffers we haven't yet opened
This used to be needed, but we think with our improvements to message ordering that we'll never miss operations that were applied after opening a remote buffer. Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
afa33c9
Clear shared buffers when unsharing projects
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
469ee55
Get most tests passing when respecting wake order for foreground tasks in Deterministic executor
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
b7314ef
WIP: Start restructuring executor
Antonio Scandurra created
96b66dc
Fix race condition when opening a buffer and getting a definition to it
Antonio Scandurra created
93125cb
Remove `executor::Foreground::Test`
All code paths have already transitioned to `Foreground::Deterministic`.
Antonio Scandurra created
dabab6e
Verify simultaneously opening buffers via `definition` and `open_buffer`
This fails because we don't yet handle this scenario.
Antonio Scandurra created
a762f57
Add remote worktree to project before it is fully deserialized
This prevents a race condition where the host will send us messages and responses about a worktree that we have seen but haven't yet finished loading.
Antonio Scandurra created
245490f
Implement `Project::definition` when the buffer is remote
Antonio Scandurra created
528a4dd
Fix regression causing guests to miss operations while opening a buffer
Antonio Scandurra created
5403ab3
Merge pull request #360 from zed-industries/improve-files
Improve remote file handling
Antonio Scandurra created
f859d44
Don't show conflict indicator on remote buffer after a reload
Antonio Scandurra created
4372fe1
Maintain remote buffers via `UpdateBufferFile` messages sent by host
Antonio Scandurra created
da13d02
Send File protos as part of Buffer protos
Use the File proto to build the File associated with the buffer rather than relying on the local entry.
Nathan Sobo created
66fce5e
Introduce LocalFile trait
If you want to call `abs_path` or `load`, the file needs to be local. You call `as_local` which returns `Option<dyn LocalFile>` with those local-only methods. I think this makes it more explicit what works only locally vs everywhere.
Nathan Sobo created
ea9c5b0
💄
Nathan Sobo created
506ce8e
Introduce LocalSnapshot
This allows us to remove the absolute path and scan-related state from the Snapshot. None of this data is relevant or valid on guests.
Nathan Sobo created
d192b6e
Remove Worktree::abs_path
I'd like to only have methods related to absolute paths on local worktrees, because it's not really possible to implement them on remote worktrees since we don't know the full path being shared and wouldn't have anything to do with it anyway if we did.
Nathan Sobo created
e2a2073
Remove worktree_path from File struct
Nathan Sobo created
2a6f06f
Merge pull request #359 from zed-industries/defer
Fix panic in ProjectDiagnosticsEditor::open_excerpts by introducing new defer feature to GPUI
Nathan Sobo created
e61a5b1
Defer pane interaction when opening excerpts in diagnostics view
Activating a new item causes the current item to be deactivated. We're the current item, but we're on the stack, so we panic if we try to do this synchronously. If we use defer to wait until we're off the stack it works.
Nathan Sobo created
b755b2d
Add ViewHandle::defer
It's like update, but happens after the current effect instead of synchronously. Also, it doesn't allow the callback to return a value because there would be nothing to do with it.
Nathan Sobo created
8b04c5d
Add a ViewContext::defer
This takes a closure that will be enqueued as an effect to ensure there are no entities on the stack.
Nathan Sobo created
b1931fb
Merge pull request #358 from zed-industries/move-buffers-to-project
Move buffers to project
Nathan Sobo created
8341820
Assign diagnostics on buffer even if it doesn't have a language
This shouldn't be necessary in practice but makes testing easier.
Nathan Sobo created
8bf628c
Update new buffers with existing diagnostics in Project – after assigning language
Nathan Sobo created