aa2d012
Limit edit prediction reject batches to max (#43965)
Click to expand commit body
We currently attempt to flush all rejected predictions at once even if
we have accumulated more than
`MAX_EDIT_PREDICTION_REJECTIONS_PER_REQUEST`. Instead, we will now flush
as many as possible, and then keep the rest for the next batch.
Release Notes:
- N/A
Many prediction requests end up being rejected early without ever being
set as the current prediction. Before this change, those cases weren’t
reported as rejections because the `request_prediction_with_*` functions
simply returned `Ok(None)`.
With this update, whenever we get a successful response from the
provider, we will return at least the `id`, allowing it to be properly
reported. The request now also includes a “reject reason,” since the
different variants carry distinct implications for prediction quality.
All of these scenarios are now covered by tests. While adding them, I
also found and fixed a bug where some cancelled predictions were
incorrectly being set as the current one.
Release Notes:
- N/A
---------
Co-authored-by: MrSubidubi <dev@bahn.sh>
Agus Zubiaga
and
MrSubidubi
created
0cf6ce4
Revert "acp: Add a timeout when initializing an ACP agent so the user isn't waiting forever" (#44066) (cherry-pick to preview) (#44067)
Click to expand commit body
Cherry-pick of #44066 to preview
----
Reverts zed-industries/zed#43663
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
zed-zippy[bot]
and
Ben Brandt
created
08f7535
Properly filter out the greedy bracket pairs (#44022) (cherry-pick to preview) (#44056)
Click to expand commit body
Cherry-pick of #44022 to preview
----
Follow-up of https://github.com/zed-industries/zed/pull/43607
Release Notes:
- N/A
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
zed-zippy[bot]
and
Kirill Bulatov
created
c8a77ae
git_ui: Fix utf8 panic in `compress_commit_diff` (#43972) (cherry-pick to preview) (#43973)
Click to expand commit body
Cherry-pick of #43972 to preview
----
Fixes ZED-3QG
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
09afb7f
edit prediction: Do not attempt to gather context for non-zeta2 models (#43943) (cherry-pick to preview) (#43951)
Click to expand commit body
Cherry-pick of #43943 to preview
----
We were running the LLM-based context gathering for zeta1 and sweep
which don't use it.
Release Notes:
- N/A
Co-authored-by: Agus Zubiaga <agus@zed.dev>
zed-zippy[bot]
and
Agus Zubiaga
created
a25a230
zeta: Smaller reject batches (#43942) (cherry-pick to preview) (#43950)
Click to expand commit body
Cherry-pick of #43942 to preview
----
We were allowing the client to build up to
`MAX_EDIT_PREDICTION_REJECTIONS_PER_REQUEST`. We'll now attempt to flush
the rejections when we reach half max.
Release Notes:
- N/A
Co-authored-by: Agus Zubiaga <agus@zed.dev>
zed-zippy[bot]
and
Agus Zubiaga
created
9b77387
Fix bracket colorization not working in file-less files with a proper language (#43947) (cherry-pick to preview) (#43948)
Click to expand commit body
Cherry-pick of #43947 to preview
----
Follow-up of https://github.com/zed-industries/zed/pull/43172
Release Notes:
- Fixed bracket colorization in file-less files with a proper language
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
zed-zippy[bot]
and
Kirill Bulatov
created
035c4c4
text: Downgrade some more offset panics to error logs (#43925) (cherry-pick to preview) (#43927)
Click to expand commit body
Cherry-pick of #43925 to preview
----
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
15aca8c
git: Push process spawns to the background threads (#43918) (cherry-pick to preview) (#43920)
Click to expand commit body
Cherry-pick of #43918 to preview
----
Release Notes:
- Improved performance of multibuffers by spawning git blame processes
on the background threads
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
bed6777
agent_ui: JSON encode command path along with other elements in MCPcontext modal (#42693) (cherry-pick to preview) (#43902)
Click to expand commit body
Cherry-pick of #42693 to preview
----
Closes #42692
Release Notes:
- Fixed command path not being correctly encoded in context server
config modal
Co-authored-by: Adam Huganir <adam@huganir.com>
da03be4
buffer_diff: Fix git gutter incorrectly showing for ignored files (#43776) (cherry-pick to preview) (#43782)
Click to expand commit body
Cherry-pick of #43776 to preview
----
Closes #43734
Closes #43698
Release Notes:
- Fixed git gutter incorrectly showing up for ignored files.
Co-authored-by: Jakub Konka <kubkon@jakubkonka.com>
zed-zippy[bot]
and
Jakub Konka
created
ffc946a
editor: Speed up `colorize_brackets` slightly in large multibuffers (#43713) (cherry-pick to preview) (#43717)
Click to expand commit body
Cherry-pick of #43713 to preview
----
There is still room for improvement here as `anchor(s)_in_excerpt` is
generally a bad API here due to it reseeking the entire excerpt tree
from the start on every call which we don't really need. But this at
least cuts the seeks down by a factor of 4 for now.
Release Notes:
- Improved performance of bracket colorization in large multibuffers
Co-authored-by: Lukas Wirth <lukas@zed.dev>
zed-zippy[bot]
and
Lukas Wirth
created
dbe0cf7
askpass: Use double quotes for script name in helper command (#43689) (cherry-pick to preview) (#43705)
Click to expand commit body
Cherry-pick of #43689 to preview
----
Replace single quotes with double quotes when referencing the askpass
script name in the helper command. The Windows command processor
(cmd.exe) requires double quotes for proper string handling, as single
quotes are treated as literal characters.
Error I get when trying to open remote project:
<img width="396" height="390" alt="image"
src="https://github.com/user-attachments/assets/1538ee10-8efc-4f80-a867-b367908091b6"
/>
```
Zed Nightly 0.216.0
c2281779af56bd52c829ccd31aae4eb82b682ebc
0.216.0+nightly.1965.c2281779af56bd52c829ccd31aae4eb82b682ebc
```
Release Notes:
- N/A
Co-authored-by: Maokaman1 <maokaman@gmail.com>
zed-zippy[bot]
and
Maokaman1
created
678fd29
acp: Add a timeout when initializing an ACP agent so the user isn't waiting forever (#43663) (cherry-pick to preview) (#43668)
Click to expand commit body
Cherry-pick of #43663 to preview
----
Sometimes we are unable to receive messages at all from an agent. This
puts on upper bound on the `initialize` call so we can at least give a
message to the user that something is wrong here.
30s might feel like too long, but I wanted to avoid some false positives
in case there was something an agent needed to do at startup. This will
still communicate to the user at some point that something is wrong,
rather than leave them waiting forever with no signal that something is
going wrong.
Release Notes:
- agent: Show an error message to the user if we are unable to
initialize an ACP agent in a reasonable amount of time.
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
zed-zippy[bot]
and
Ben Brandt
created
2e99827
Do not color html tags and other "long" "bracket pairs" (#43644) (cherry-pick to preview) (#43645)
Click to expand commit body
Cherry-pick of #43644 to preview
----
Closes https://github.com/zed-industries/zed/issues/43621
Follow-up of https://github.com/zed-industries/zed/pull/43172
Release Notes:
- (Preview only) Fixed html tags incorrectly colorized
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
a290fee
remote: Do not include prerelease and build meta in asset queries (#43611) (cherry-pick to preview) (#43616)
Click to expand commit body
Cherry-pick of #43611 to preview
----
Closes #43580
Release Notes:
- (Preview only) Fixed failures to fetch remoting server (needed to run
remoting).
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
zed-zippy[bot]
and
Piotr Osiewicz
created
e2cc259
Account for greedy tree-sitter bracket matches (#43607) (cherry-pick to preview) (#43610)
Click to expand commit body
Cherry-pick of #43607 to preview
----
Current approach is to colorize brackets based on their depth, which was
broken for markdown:
<img width="388" height="50" alt="image"
src="https://github.com/user-attachments/assets/bd8b6c2f-5a26-4d6b-a301-88675bf05920"
/>
Markdown grammar, for bracket queries
https://github.com/zed-industries/zed/blob/00e93bfa113a3daed6e4a97a7244ad04d58453ee/crates/languages/src/markdown/brackets.scm#L1-L8
and markdown document `[LLM-powered features](./ai/overview.md), [bring
and configure your own API
keys](./ai/llm-providers.md#use-your-own-keys)`, matches first bracket
(offset 0) with two different ones:
* `[LLM-powered features]`
* `[LLM-powered features](./ai/overview.md), [bring and configure your
own API keys]`
which mix and add different color markers.
Now, in case multiple pairs exist for the same first bracket, Zed will
only colorize the shortest one:
<img width="373" height="33" alt="image"
src="https://github.com/user-attachments/assets/04b3f7af-8927-4a8b-8f52-de8b5bb063ac"
/>
Release Notes:
- Fixed bracket colorization mixing colors in markdown files
Co-authored-by: Kirill Bulatov <kirill@zed.dev>
zed-zippy[bot]
and
Kirill Bulatov
created
7fbf0f6
editor: Consider experimental theme overrides for colorized bracket invalidation (#43602) (cherry-pick to preview) (#43606)
Click to expand commit body
Cherry-pick of #43602 to preview
----
Release Notes:
- Fixed a small issue where bracket colors would not be immediately
updated if `experimental_theme_overrides.accents` was changed.
Co-authored-by: Finn Evers <finn@zed.dev>
b81880b
auto-update: Fix auto-update loop with non-nightly channels (#43595) (cherry-pick to preview) (#43597)
Click to expand commit body
Cherry-pick of #43595 to preview
----
There are 3 factors:
1. The Preview channel endpoint does not propagate versions with build
identifier (which we oh-so-conveniently store in pre-release field of
semver).
2. Preview build, once fetched, sees it's version *with* build
identifier (as that's baked into the binary).
3. Auto update logic treats versions with pre-release version as less
than versions without pre-release version.
This in turn makes any Preview client see itself as versioned like
0.214.4-123-asdf1234455311, whereas the latest version on the endpoint
is 0.214.4. Thus, the endpoint version is always more recent than the
client version, causing an update loop.
The fix is to ignore build identifier when comparing versions of
non-nightly channels. This should still let us introduce changes to
auto-update behavior in minor releases in the future.
Closes #43584
Release Notes:
- (Preview only): Fixed an update loop with latest Preview update.
Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
51e97d3
languages: Recognize .clangd as YAML (#43557)
Click to expand commit body
Follow-up to: https://github.com/zed-industries/zed/pull/43469
Thanks @WeetHet for [the idea]([WeetHet](https://github.com/WeetHet)).
Release Notes:
- Added support for identifying. .clangd files as YAML by default
Peter Tripp
created
c36b12f
settings_ui: Pick a more reasonable minimum window size (#43556)
Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/41903
Release Notes:
- Fixed settings ui being forced larger than small screens
Lukas Wirth
created
7c724c0
editor: Do not show scroll thumb if page fits (#43548)
Click to expand commit body
Follow-up to https://github.com/zed-industries/zed/pull/39367
Release Notes:
- Fixed a small issue where a scrollbar would sometimes show in the
editor although the content fix exactly on screen.
Finn Evers
created
1e6a05d
askpass: Quote askpass script in askpass helper command (#43542)
Click to expand commit body
Closes #40276
Release Notes:
- Fixed askpass execution failing on windows sometimes
Lukas Wirth
created
b9af664
gpui: Return `None` for non-existing credentials in `read_credentials` on windows (#43540)
c2cb76b
rope: Turn `ChunkSlice::slice` panics into error logs (#43538)
Click to expand commit body
While logically not really correct, its better than tearing down the
application until we figure out the root cause here
Release Notes:
- N/A *or* Added/Fixed/Improved ...
Lukas Wirth
created
684a58f
Implement vertical scrolling for extended keymap load error information (#42542)
Click to expand commit body
This PR fix an issue where, if an error occurs while loading the keymap
file during application startup, an excessively long error message would
be truncated and not fully displayed.
Before:
<img width="1567" height="1056" alt="before"
src="https://github.com/user-attachments/assets/ab80c204-b642-4e8f-aaf5-eae070ab01a2"
/>
After:
<img width="1567" height="1056" alt="image"
src="https://github.com/user-attachments/assets/1b2ff2ce-3796-41d5-b145-dc7d69f04f11"
/>
Release Notes:
- N/A
ihavecoke
created
9150346
outline_panel: Fix the panel frequent flickering during search (#43530)
Click to expand commit body
The outline panel flickers when searching or when the file content
changes. This happens because an empty UI appears during the search
process, but it only lasts for a few milliseconds, so we can safely
ignore it.
## Before
https://github.com/user-attachments/assets/9b409827-75ee-4a45-864a-58f0ca43191f
## After
https://github.com/user-attachments/assets/b6d48143-1f1a-4811-8754-0a679428eec2
Release Notes:
- N/A
Floyd Wang
created
425d4c7
git: Use correct file mode when staging (#41900)
Click to expand commit body
Closes #28667
Release Notes:
- Fixed git not preserving file mode when committing. Now if an input file is executable it will be preserved when committed with Zed.
---------
Signed-off-by: 11happy <soni5happy@gmail.com>
Signed-off-by: 11happy <bhuminjaysoni@gmail.com>
Co-authored-by: Jakub Konka <kubkon@jakubkonka.com>
Bhuminjay Soni
and
Jakub Konka
created
00e93bf
shell: Correctly identifiy `powershell` shells on windows (#43526)
Click to expand commit body
Release Notes:
- Fixed zed only finding pwsh but not powershell on windows
Lukas Wirth
created
9d8b507
zeta: Avoid logging an error for not having SWEEP_AI_TOKEN (#43504)
Click to expand commit body
Closes #43503
Release Notes:
- Fixes ERROR No SWEEP_AI_TOKEN environment variable set
Co-authored-by: oscarvarto <oscarvarto@users.noreply.github.com>
Oscar Vargas Torres
and
oscarvarto
created
3072133
Improve bash detection on Windows (#43455)
Click to expand commit body
I have git installed via [scoop](https://scoop.sh). The current
implementation finds `git.exe` in scoop's shims folder and then tries to
find `bash.exe` relative to it.
For example, `git.exe` (shim) is located at:
```
C:\Users\<username>\scoop\shims\git.exe
```
And the code tries to find `bash.exe` at:
```
C:\Users\<username>\scoop\shims\..\bin\bash.exe
```
which doesn't exist.
This PR changes the logic to first check if `bash.exe` is available in
PATH (using `which::which`), and only falls back to the git-relative
path if that fails.
qystishere
created
56a2f9c
Revert "git: Make the version_control.{deleted/added} colors more accessible" (#43512)
Click to expand commit body
Reverts zed-industries/zed#43475
The colors ended up being too dark. Zed adds an opacity to the
highlights.
https://github.com/zed-industries/zed/blob/e13e93063ce24a2ede88747c316d7279174878c8/crates/editor/src/element.rs#L9195-L9200
Reverting to avoid having the colors go out in preview will fix shortly
after.
Anthony Eid
created
88ef5b1
terminal: Update search match highlights on resize (#43507)
Click to expand commit body
The fix for this is emitting a wake-up event to tell the terminal to
recalculate its search highlights on resize.
Release Notes:
- terminal: Fix bug where search match highlights wouldn't update their
position when resizing the terminal.
Anthony Eid
created
e13e930
Avoid continuing zeta requests that are cancelled before their throttle (#43505)
Click to expand commit body
Release Notes:
- N/A
Max Brunsfeld
created
98e3692
languages: Recognize .clang-format as YAML (#43469)
Click to expand commit body
Clang-Format uses uses a YAML config file format.
Use YAML language by default for `.clang-format` and `_clang-format`
filenames.
([source](https://clang.llvm.org/docs/ClangFormatStyleOptions.html))
Add `#yaml-language-server: $schema` to `.clang-format` example in C
language docs.
Release Notes:
- Added support for identifying. `.clang-format` files as YAML by
default
Fixes https://github.com/zed-industries/zed/issues/42554
Fixes https://github.com/zed-industries/zed/issues/43383
Release Notes:
- python: Added support for detecting uv workspaces as toolchains.
- windows: Fixed console windows sometimes appearing when opening Python
files.
Most of the features for collab were previously listed in the section
that was written for private calls. Most of this PR is moving that
content over to the channel documentation and adapting it slightly.
Private calls have similar collaboration, so we can just point back to
the channels doc in that section and keep it pretty thin / DRY.
Release Notes:
- N/A
Joseph T. Lyons
created
1f9d5ef
Always display terminal cursor when blinking is disabled (#43487)
Click to expand commit body
Fixes an issue where the terminal cursor wouldn't always be displayed in
the default `blink: "terminal_controlled"` mode unless the terminal
requested cursor blinking.
Release Notes:
- N/A
Agus Zubiaga
created
83f0a3f
Redact sensitive environment variables in LSP Logs: Server Info (#43480)
Click to expand commit body
Follow-up to:
- https://github.com/zed-industries/zed/pull/43436
- https://github.com/zed-industries/zed/pull/42831
The changes in #42831 resulted in a regression where environment
variables in the Server Info view were no longer redact. The changes in
#43436 were insufficient as I was still seeing sensitive values in
Nightly e6fe95b4f2f676c7fc4a5f951ba7c721e7d22e8a (which includes
#43436).
CC: @SomeoneToIgnore (Hi! 👋 Thanks for keeping this redaction
functionality alive)
Release Notes:
- N/A
Peter Tripp
created
7ecbf8c
zeta2: Remove expected context from evals (#43430)
fb0fcd8
Add missing update of last_prediction_refresh (#43483)
Click to expand commit body
Fixes a regression introduced in
https://github.com/zed-industries/zed/pull/43284 where edit predictions
stopped being throttled at all 😬
Release Notes:
- N/A
Co-authored-by: Ben Kunkle <ben@zed.dev>