1398a12
More keybindings in macOs modals with buttons
Click to expand commit body
Closes https://github.com/zed-industries/community/issues/1095
by forcing the non-Cancel button to get a focus.
Due to the way macOs handles buttons on modals, the focus gain had to be
achieved via certain button addition order, rather than conventional
"setFocus"-ish API, see the related comment for details.
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
Kirill Bulatov
and
Antonio Scandurra
created
70f8cf4
Move methods querying window state into `AsyncAppContext`
Antonio Scandurra
created
4f69397
Merge pull request #2432 from zed-industries/more-diagnostic-source
Click to expand commit body
Show diagnostic source in more places
Julia
created
185c165
Show diagnostic source in inline diagnostic
Julia
created
9108e41
Merge pull request #2431 from zed-industries/fix-broken-contact-finder
794446b
Move `debug_elements` to `AsyncAppContext`
Click to expand commit body
Previously, `debug_elements` was available on `WindowContext`. If that
method was called while having a borrow out to a view, it would panic because
the view would already have been borrowed.
By moving it to an `AsyncAppContext` we ensure the method can't be called while
a view is being used.
Antonio Scandurra
created
4c1cba6
Remove unnecessary `Element` impl for `RootElement`
Antonio Scandurra
created
f7de0ad
Show diagnostic source in diagnostic multibuffer headers
This was introduced with #2420 and was caused by re-entrantly updating
the workspace. Instead of passing the workspace reference from the outside,
we now define the definition navigation as a method on the editor which solves
the issue.
Note that we also needed to introduce a `defer` call when navigating to a definition
to prevent the workspace from reading the editor during `open_project_item`.
Antonio Scandurra
created
ae5794d
Merge pull request #2421 from zed-industries/metrics-2
Click to expand commit body
Rework telemetry code to support sending events to Clickhouse
Joseph T. Lyons
created
32f26d1
Merge pull request #2422 from zed-industries/source-eslint-server-from-github
Click to expand commit body
Source ESLint server from Github rather than 3rd party NPM package
Julia
created
1bf8521
Source ESLint server from Github rather than 3rd party NPM package
Julia
created
6b0faa2
Rework telemetry code to support sending events to Clickhouse
Click to expand commit body
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Joseph Lyons
and
Max Brunsfeld
created
dc999f7
Merge pull request #2420 from zed-industries/simplify-action-dispatch