Commit log

c2c37f2 fix(menu): return true from menu handlers

Click to expand commit body
ConversationFragment.onOptionsItemSelected was using break statements
instead of return true for handled menu items. This caused the method to
return false (from super.onOptionsItemSelected), indicating the event was
not handled.

On tablets with split-pane view, this caused menu events to bubble from the
temporary fragment in ConversationsOverviewFragment to the visible
ConversationFragment, resulting in duplicate actions. For example, selecting
"Contact details" from the context menu would open contact details twice:
first for the selected conversation (correct), then for the currently active
conversation (wrong), with the wrong one appearing on top.

Fixed by changing all break statements to return true, matching the pattern
already used in onContextItemSelected. This also adds a missing return after
action_block_avatar which was previously falling through to the next case.

Fixes: https://todo.sr.ht/~singpolyma/soprani.ca/437

Phillip Davis created

da4c216 filter accts in ConversationsOverviewFragment

Phillip Davis created

b11972b escape jids in more places

Phillip Davis created

d675927 dont timeout w/o ack

Phillip Davis created

575cfdf declare ImportBackupService in android manifest

Click to expand commit body
was causing all backup restores to fail,
service was never even created

Phillip Davis created

b947940 guard against null url in oob stanza

Click to expand commit body
previously, would crash whole app

`if (url != null) {` makes it seem like we were
fine with the subsequent code not running anyway

Phillip Davis created

4fa90ed Update for 16KB alignment

Stephen Paul Weber created

95bcad4 Merge branch '442-connect-via-tor-not-working' of https://git.secluded.site/cheogram-android

Click to expand commit body
* '442-connect-via-tor-not-working' of https://git.secluded.site/cheogram-android:
  fix(settings): enable Tor conns for other flavs

Stephen Paul Weber created

011e884 fix(settings): enable Tor conns for other flavs

Click to expand commit body
Remove QuickConversationsService.isConversations() checks from
AppSettings.java (isUseTor, isExtendedConnectionOptions) to allow Tor
connections in non-Conversations flavours.

I tested by installing with a modified package ID, adding a new account,
enabling the Tor toggle, and seeing that 0 out of 1 accounts were
connected because Tor is unavailable. After installing/enabling Orbot
and waiting a bit, I had to toggle the account to get it to try again.

Fixes: https://todo.sr.ht/~singpolyma/soprani.ca/442

Amolith created

8863066 don't care abt old pw if didUnlock

Phillip Davis created

e68d564 Don't set to UTF8 if it's just ascii

Click to expand commit body
for better compatibility with scanners

Stephen Paul Weber created

f240e52 Show self in participants

Stephen Paul Weber created

3984516 See own hats

Stephen Paul Weber created

37c504b Change button labels to make function more clear

Stephen Paul Weber created

8780945 Side by side looked dumb on narrow devices

Stephen Paul Weber created

7e157f5 Workaround for snikket sending unavailable

Stephen Paul Weber created

957df4f Fix account colors on item lists

Click to expand commit body
including startconversation

Stephen Paul Weber created

c6be9b6 fix Pre-Authenticated In-Band Registration

Daniel Gultsch created

2fc3c19 Fix more insets

Stephen Paul Weber created

b3bcfbb put Manage Phone Accounts in ListView footer

Click to expand commit body
- fixes issue where sufficiently large account list can't scroll down to
  the "Manage Phone Accounts" button
- introduces a binding, which seems good

Phillip Davis created

0b92727 Revert "Tap the brakes"

Click to expand commit body
This reverts commit eb3d1916451231732aad185ce28f239c37e7d242.

Stephen Paul Weber created

6e36911 Bump versionCode

Stephen Paul Weber created

95ec711 Fix reaction carbons

Click to expand commit body
Can't use from when the message is from us...

Stephen Paul Weber created

867bb7a Bump versionCode

Stephen Paul Weber created

18fde27 Disable HTTP avatars

Click to expand commit body
We don't need even more HTTP around here, thanks

Stephen Paul Weber created

2f45846 Fix block avatar

Stephen Paul Weber created

d42d5f7 Hook up reactions parser again

Stephen Paul Weber created

7920be1 Fix NPE

Stephen Paul Weber created

6ab14a0 Fix NPE

Stephen Paul Weber created

13f27d8 Bump versionCode

Stephen Paul Weber created

33c5eb1 Temporarily allow mismatch node

Click to expand commit body
Because apparently my muc module at least has this bug

Stephen Paul Weber created

f0bcf5f When command fetch fails, don't spin forever

Stephen Paul Weber created

f8c251b Do not merge if true counterpart differs

Stephen Paul Weber created

1b0404c Copy this so we can mutate

Stephen Paul Weber created

8847688 Bump versionCode

Stephen Paul Weber created

a0fb074 Fix CI

Stephen Paul Weber created

d3ffb25 Fix anyFeature

Stephen Paul Weber created

5795afa Merge commit 'a2378805932c94c140deb73d3a21884ecd8ce6fa'

Click to expand commit body
* commit 'a2378805932c94c140deb73d3a21884ecd8ce6fa': (87 commits)
  version bump to 2.19.0-beta
  default to bubbles start align on tablets
  make enter phone number screen work on small screens
  use 'safe' aac encoding by default instead of maintainig list
  Translated using Weblate (Hungarian)
  cache vCard exceptions
  move most MUC handling into Manager
  move non-muc presence sending into PresenceManager
  put offline messages purge into manager
  Add Samsung Galaxy S9+ and Google Pixel 2 to the list of AAC sensitive devices
  Translated using Weblate (Portuguese)
  Translated using Weblate (Portuguese)
  Translated using Weblate (Portuguese)
  Translated using Weblate (Japanese)
  Translated using Weblate (Portuguese)
  Translated using Weblate (Japanese)
  Translated using Weblate (Spanish)
  Translated using Weblate (Italian)
  Translated using Weblate (Kabyle)
  Translated using Weblate (Portuguese (Brazil))
  ...

Stephen Paul Weber created

29a3dd6 Prioitize PSTN type when present

Stephen Paul Weber created

f7efada Merge commit '12df7f1a17c5cfa0ea1607dde6705b0773d6ffd6'

Click to expand commit body
* commit '12df7f1a17c5cfa0ea1607dde6705b0773d6ffd6':
  introduce ping and carbons managers
  clean caps cache when resources go unavailable
  respond to version requests via DiscoManager
  refactor channel discovery to use new APIs
  respond to disco#info queries via DiscoManager

Stephen Paul Weber created

7522d7e fix: second reply treated as separate message

Click to expand commit body
diagnosis: when we get a message with a <replace> element,
we overwrite several fields of the replaced message. Unfortunately, this
includes the remoteId of the replaced message, which is the field by
which we look up the message to be replaced. All corrections to a
message reference the id of the original, unedited message, so edits
>= 2 find a null replacedMessage.

fix is just to remove that line

Phillip Davis created

3ee6586 bump version

Stephen Paul Weber created

d1edb1d Merge commit '0b366cfaf8db40d9644f51c564913a56eae5ba73'

Click to expand commit body
* commit '0b366cfaf8db40d9644f51c564913a56eae5ba73': (24 commits)
  use new api for disco and caps
  Add missing slashes
  Translated using Weblate (French)
  Translated using Weblate (French)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Chinese (Traditional Han script))
  Translated using Weblate (Hebrew)
  Translated using Weblate (Italian)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Serbian)
  Translated using Weblate (German)
  Add ASUS Nexus 7 to the list of problematic AEC devices.
  Translated using Weblate (Estonian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Russian)
  Translated using Weblate (Polish)
  Translated using Weblate (Galician)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Russian)
  ...

Stephen Paul Weber created

387db99 Upgrade MaterialDrawer to fix insets on a15

Stephen Paul Weber created

9e5a83f Fix status bar colour

Stephen Paul Weber created

de9bf72 Merge commit '086a72731b75df4735cb4f18f00b66f938997918'

Click to expand commit body
* commit '086a72731b75df4735cb4f18f00b66f938997918':
  add mime type and icon for pcap files
  refactor HTTP slot requester
  better wording for no channel binding error
  Translated using Weblate (Italian)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Italian)
  Added translation using Weblate (Irish)
  Translated using Weblate (Irish)
  Added translation using Weblate (Irish)
  Translated using Weblate (Russian)
  Translated using Weblate (Russian)
  Translated using Weblate (Russian)
  Translated using Weblate (Polish)
  Translated using Weblate (Serbian)
  Translated using Weblate (Russian)

Stephen Paul Weber created

c218dd9 Merge commit 'e8ecd090c42d11ee7c5dc30b79217079bd8d6c4d'

Click to expand commit body
* commit 'e8ecd090c42d11ee7c5dc30b79217079bd8d6c4d': (33 commits)
  amend changelog for 2.18.2
  disabling autofill hints programatically seems to have no effect
  Translated using Weblate (German)
  Translated using Weblate (Estonian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Russian)
  change selector for tablet
  change link to bouncycastle
  fix FAB not shriking
  fix selection indicator in overview
  bump version code
  remove some unused code
  set fgs type on import backup worker
  reorganize third party libraries in about section
  version bump to 2.18.2
  parse uri params as multi list
  Translated using Weblate (Estonian)
  Translated using Weblate (Chinese (Simplified Han script))
  Translated using Weblate (Turkish)
  ...

Stephen Paul Weber created

5218679 Fix bundle

Stephen Paul Weber created

278bd95 Remove extra translations

Stephen Paul Weber created

ef37358 Bump version

Stephen Paul Weber created