7ed3f5f
Clean up references in doc comments in `ui` and `theme` crates (#3985)
Click to expand commit body
This PR cleans up a number of references in doc comments in the `ui` and
`theme` crates so that `rustdoc` will link and display them correctly.
Release Notes:
- N/A
447bfca
Add a test to catch keybinding bounds issue (#3966)
Click to expand commit body
Add a test to catch regressions to
https://github.com/zed-industries/zed/pull/3964
Thanks for the idea @ConradIrwin
TODO:
- [ ] Fix immediate stack overflow in test
Release Notes:
- N/A
Mikayla Maki
created
128a8ff
Remove unnecessary mutexes from livekit client types
bebb528
Merge branch 'main' into migrations-on-server-start
Conrad Irwin
created
824d06e
Remove `Default` impl for `StatusColors` (#3977)
Click to expand commit body
This PR removes the `Default` impl for `StatusColors`.
Since we need default light and dark variants for `StatusColors`, we
can't use a single `Default` impl.
Release Notes:
- N/A
Marshall Bowers
created
d374953
search: Remove newlines from query used for tab_content. (#3976)
Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2388
Release Notes:
- Fixed tab content of project search overflowing the tab for queries
with newlines.
This PR adds a `SharedUrl` type to GPUI.
It's just like a `SharedString`, but for denoting that the contained
value is a URL.
Mainlined from @nathansobo's GPUI blog post:
https://github.com/zed-industries/zed/pull/3968/files#diff-7ee75937e2daf7dd53f71b17698d8bd6d46993d06928d411781b9bd739b5f231R9-R12
Release Notes:
- N/A
Marshall Bowers
created
fa53353
Rename `IconElement` to just `Icon` (#3974)
Click to expand commit body
This PR renames the `IconElement` component to just `Icon`.
This better matches the rest of our components, as `IconElement` was the
only one using this naming convention.
The `Icon` enum has been renamed to `IconName` to free up the name.
I was trying to come up with a way that would allow rendering an
`Icon::Zed` directly (and thus make the `IconElement` a hidden part of
the API), but I couldn't come up with a way to do this cleanly.
Release Notes:
- N/A
Marshall Bowers
created
29ed067
Add a missing default value to docs (#3973)
4afa5fb
Add stories for collab notifications (#3967)
Click to expand commit body
This PR adds some basic stories for collab notifications to make them
easier to work on:
<img width="1076" alt="Screenshot 2024-01-08 at 9 43 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4a0adcfa-1134-49c2-b589-74ac1d52af4c">
I factored out a `CollabNotification` component that defines the general
structure for one of these notifications, and this is the component that
we use in the stories, with representative values passed to it to
simulate the different instances of the notification.
We can't use the actual notification components in the stories due to
their data dependencies.
Release Notes:
- N/A
c40a7f3
Stop propagation when deploying the context menu for a project panel entry (#3965)
Click to expand commit body
This PR fixes an issue where right-click on any project panel entry
would cause the context menu on the root of the project panel
(introduced in #3954) to deploy.
We need to stop propagation in the handler on the inner project panel
list items so that the click event doesn't bubble up the tree.
Release Notes:
- Fixed an issue where the project panel was always deploying the root
context menu rather than on the clicked item.
Marshall Bowers
created
6982b4b
Fix off by 1 error when computing available key bindings (#3964)
Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2379
Release Notes:
- Fixed issue where keybindings in some context menus would not show
reliably.
Mikayla Maki
created
0684369
Fix off by 1 error when computing available key bindings
Mikayla
created
435b5ca
Restore the terminal cursor settings (#3963)
Click to expand commit body
As it says on the tin
Release Notes:
- Restored the terminal cursor's I-beam and pointing hand settings