Commit log

eb9ddef Always show full command on terminal tab hover (#3934)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/1856

Release Notes:

- Fixed terminal tab tooltip being truncated

Kirill Bulatov created

d566a0d Always show full command on terminal tab hover

Kirill Bulatov created

419b4d0 External file drag and drop (#3933)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/1317
Deals with https://github.com/zed-industries/community/issues/486

Reworks pane drag and drop code to support 
* dropping external files into main pane (supports splits same as tabs
and project entries drop) — this will open the file dropped
* dropping external files, tabs and project entries drop into the
terminal — this will add file abs path into the terminal

Release Notes:

- Added a way to drag and drop external files into Zed main & terminal
panes; support tabs and project entries drop into terminal pane

Kirill Bulatov created

df937ea Use fs to determine if file path is a dir

Kirill Bulatov created

e5fbc53 Instrument welcome screen events (#3930)

Click to expand commit body
# TODO

- [x] Fix busted tests
- [x] Check all events from actions on welcome screen
    - [x] change theme
    - [x] change keymap
    - [x] install cli
    - [x] enable vim
    - [x] send metric data
    - [x] send diagnostics
    - [x] close welcome screen
- [X] Check all settings events
    - [x] record theme change (in main and in selector)
    - [x] record base keymap change (in main and in selector)
    - [x] record metric data value
    - [x] record diagnostics value
- [X] Triple check that telemetry settings still block events from being
sent, since we updated how we check for settings changes
- [X] Remove immediate flush mode and allow the flush method to be
called publicly
- [x] Remove references to clickhouse in the code (should be generic at
the client level)

Release Notes:

- N/A

Joseph T. Lyons created

44bc5ae Improve setting name consistency for welcome page

Joseph T. Lyons created

1bcee19 Improve operation name consistency for welcome page

Joseph T. Lyons created

f4c78d3 Remove "clickhouse" from telemetry code

Click to expand commit body
The client sends events to our end point, and the endpoint is what determines what analytics database is used to store the data. The client should be generic and not mention the name of the service being proxied to through our server.

Joseph T. Lyons created

5344296 Remove immediate flush mode

Click to expand commit body
Allow flush method to be called publicly. This is a better, simpler solution, that allows for better control over flushing.

Joseph T. Lyons created

4f88a50 On external file drop, add visible project entries for directories only

Kirill Bulatov created

c499e1e Fix panic during terminal tab drag and drop

Kirill Bulatov created

518868a Implement terminal pane drag and drop overrides

Kirill Bulatov created

c4e3061 Implement external file drop in pane

Kirill Bulatov created

8ff05c6 Prepare for external file drop in pane

Kirill Bulatov created

dc7f9bb gpui: Sweep through cargo doc output and mark dubious items as non-public (#3932)

Click to expand commit body
I essentially went through the publicly exported items and marked these
that are e.g. leaky reexports as pub(crate). I expect that'd be done on
Tuesday anyways.

Release Notes:
- N/A

Piotr Osiewicz created

ec03572 Properly detect file finder label positions in paths (#3931)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2367

Release Notes:

- Fixed file finder crashing on certain paths with multi-codepoint
characters
([#2367](https://github.com/zed-industries/community/issues/2367))

Kirill Bulatov created

5dca1b5 Properly detect file finder label positions in paths

Kirill Bulatov created

520c433 Fix tests

Joseph T. Lyons created

800c995 Clean up code

Joseph T. Lyons created

ea17702 Merge branch 'main' into instrument-welcome-screen

Joseph T. Lyons created

167a0b5 Add event for welcome page close

Joseph T. Lyons created

cdd5cb1 WIP

Joseph T. Lyons created

96a0e9f Fix bug that was causing `Editor` to notify on every mouse move (#3929)

Click to expand commit body
Release Notes:

- Fixed a bug that was causing Zed to use a lot of energy when moving
the mouse.

Antonio Scandurra created

23414d1 Fix bug that was causing `Editor` to notify on every mouse move

Antonio Scandurra created

db4a0b1 Fix low handing styling fruits on the collab panel (#3928)

Click to expand commit body
Release Notes:

- N/A

Kirill Bulatov created

d86ccb1 Reduce the height of the collaborators' color ribbon

Kirill Bulatov created

ae14f7b Add space between menus and player stack

Kirill Bulatov created

ee336cb Add spaces between leave call and call status icons, and call status icons and user menu

Kirill Bulatov created

b813451 Fix base keymap selector keyboard shortcuts (#3927)

Click to expand commit body
Release Notes:

- Fixed base keymap selector keyboard shortcuts

Kirill Bulatov created

0d7f3ef Fix base keymap selector keyboard shortcuts

Kirill Bulatov created

3d1f522 Fix the alignment of the assistant (#3925)

Click to expand commit body
![CleanShot 2024-01-05 at 17 30
11@2x](https://github.com/zed-industries/zed/assets/1789/b70226d0-bc07-4ce3-b45d-c25aace998c2)

Release Notes:

- Fixed the alignment of the assistant headers and text
- Increased the left padding on the assistant.

Nathan Sobo created

aaada7d Implement From<Rgba> for Fill

Nathan Sobo created

436a281 Align the assistant message headers with the editable message content

Click to expand commit body
Since the message headers are buttons, we need to shift them relatively to
compensate for the fact that the background is only visible when hovered.
I'm ok with the background not being aligned so long as the unhovered text is.

Nathan Sobo created

621c98b Restore collab button tooltips, make screenshare item background of editor background's color (#3924)

Click to expand commit body
Release Notes:

- Restored collab button tooltips, made screenshare item background of
editor background's color

Kirill Bulatov created

669293e Screenshare item background is now of editor background's color

Kirill Bulatov created

e549ef0 Restore tooltipts for all collab buttons

Kirill Bulatov created

a7901ab following tests (#3902)

Click to expand commit body
Starting work on the following tests.

* The first failure was caused by not properly dropping the references,
which is now fixed.
* The next failure is caused by a `cx.after_window_update` being changed
to `cx.on_next_frame`. This doesn't seem to work (at least in tests),
but might also explain the flaky following behavior Max and I observed
if there's a timing bug in production too.
* * When you are following someone and they move their cursor you should
receive two proto messages: UpdateBuffer to move the cursor, and
UpdateFollowers to update where you're following. It seems like this
could be made a bit less chatty/fragile, but probably out of scope for
this.
* With that worked around, there's one more failure, but I haven't
looked into it yet. (possibly caused by an incorrect fix for the cx
one).

Max Brunsfeld created

385cbfe Tidy up context usage

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

709682e Tidy up TestContext lifecycle

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

c7568a7 All the following tests

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

204ef45 Merge branch 'main' into following-tests

Conrad Irwin created

f239a82 More following tests

Conrad Irwin created

81d707a Port 1.00 following tests

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

7e810d7 Restore the ability to disable key bindings by setting them to `null` in your keymap (#3921)

Click to expand commit body
* Fix an incorrect use of `Any::type_id` that prevented the disabling of
key bindings
* Restructured the representation of disabled key bindings so that they
handle context predicates correctly. Previously, to disable key binding,
you needed to supply the exact same context predicate (e.g. `Editor &&
mode == "full"`) as the binding that you are trying to disable. Now, the
context predicates of disabled key bindings are evaluated just like any
other context predicate (with the current context) to see if they apply.

Release Notes:

- Fixed an issue where disabling key bindings didn't work. To disable a
key binding, set it to `null` in your keymap.

Max Brunsfeld created

be98ff4 Iterate on design of channel management modal (#3923)

Click to expand commit body
This PR refines the design of the channel management modal:

#### Before

<img width="585" alt="Screenshot 2024-01-05 at 4 17 32 PM"
src="https://github.com/zed-industries/zed/assets/1486634/a6d96674-b688-4549-8fb8-0a7b2c7c88be">

#### After

<img width="589" alt="Screenshot 2024-01-05 at 4 15 20 PM"
src="https://github.com/zed-industries/zed/assets/1486634/31ae8dc1-a129-4a15-963e-9779b9b79bd9">

Release Notes:

- Improved the look of the channel management modal.

Marshall Bowers created

76b1a3c Refine copilot UI

Nate Butler created

8a96562 Handle contexts correctly for disabled key bindings

Max Brunsfeld created

d144543 Use the already existing styles/typography for Headline

Nate Butler created

dcb9c0b Merge branch 'main' into copilot-ui

Nate Butler created

6cb8b86 Tidy up styling of connection status in the title bar (#3922)

Click to expand commit body
This PR tidies up the styling of the connection status indicators in the
title bar.

Removed some debug styles and tweaked the styling to match the rest of
the title bar overall.

Release Notes:

- Improved the connection status indicators in the title bar.

Marshall Bowers created