Commit log

a529a53 Don't allow granting write access to guests who haven't signed the CLA, if the channel requires the zed CLA (#4208)

Max Brunsfeld created

2570808 Add requires_zed_cla column to channels table

Click to expand commit body
Don't allow granting guests write access in a call where the channel
or one of its ancestors requires the zed CLA, until that guest has
signed the Zed CLA.

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

f2eb78b Avoid overwriting mouse wheel scroll with selection auto-scroll (#4207)

Click to expand commit body
Release Notes:

- Fixed an issue where mouse wheel events could be ignored while
selecting text near the top or bottom of the editor with the mouse.

Julia created

a2aa47a Avoid overwriting mouse wheel scroll with selection auto-scroll

Julia created

fd8d2d4 One off

Conrad Irwin created

92c4c84 Fix the fonts panic and completions in the settings (#4205)

Click to expand commit body
* Do not add fonts' `font_family` into the font completion list, if
there's no corresponding attribute in the font data
* Remove `font_style_name` and `font_name` attribute from the completion
options, since those bring `-Italic`, `-Bold` variants that are not
family names (which we use to load the fonts, so they are useless)

Release Notes:

- Improved font family names completion in the settings

Kirill Bulatov created

a75fa35 Fix the fonts panic

Click to expand commit body
co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

98d514f Fix off-by-one highlighting in hover tooltip

Click to expand commit body
rust analyzer has a tendency to return markdown of the form:

```rust
 // <-- note the leading space
blah blah blah
```

This is clearly defectuous, so we used to .trim() the output.

Unfortunately we trim after applying syntax highlighting, so that causes
the output to look goofy.

Fix this by updating the highlighting when we trim.

Conrad Irwin created

676d2cb collab 0.39.0

Max Brunsfeld created

44c2b8b Add REST APIs for signing the CLA, retrieving users who've signed the CLA (#4202)

Max Brunsfeld created

b9458fe Fix call to get_or_create_user in seed binary

Max Brunsfeld created

03e0089 Fix get_or_create_user test

Max Brunsfeld created

cd7f377 Allow checking CLA signatures by GitHub login

Click to expand commit body
This will be used by CLA Bot.

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

a9ddef8 Update Channel membership UI

Click to expand commit body
* Remove ability to act on people defined in parent channels
* Show promote buttons on guests

Conrad Irwin created

43c2192 Hide editor hovers when a menu is open (#4200)

Click to expand commit body
Release Notes:

- Fixed a bug where editor hover state could appear while menu open
([#2384](https://github.com/zed-industries/community/issues/2384)).

Conrad Irwin created

56556d7 Add API for retrieving the date that a contributor signed the CLA

Click to expand commit body
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

6c937c4 Make POST /contributors API idempotent

Click to expand commit body
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

2bfbd72 Remove unused import? (#4201)

Click to expand commit body
Release builds are currently failing:
https://github.com/zed-industries/zed/actions/runs/7616903969/job/20744857084

It is unclear to me why debug builds are not.

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

2445df8 Remove unused import?

Conrad Irwin created

53b47c1 Hide editor hovers when a menu is open

Conrad Irwin created

c5465d2 Fix panel deserialization (#4198)

Click to expand commit body
In the old world, panel loading happened strictly before workspace
deserialization. Now it's inverted.

Fix this by storing on the dock the serialized state so they can restore
state as panels are loaded.

[[PR Description]]

Release Notes:

- Fixed Zed forgetting which panels were open on boot.
([#2406](https://github.com/zed-industries/community/issues/2406)).

Conrad Irwin created

36a8bbf Fix panel deserialization

Click to expand commit body
In the old world, panel loading happened strictly before workspace
deserialization. Now it's inverted.

Fix this by storing on the dock the serialized state so they can restore
state as panels are loaded.

Conrad Irwin created

1981de4 Add REST APIs for getting and adding contributors

Click to expand commit body
Co-authored-by: Mikayla <mikayla@zed.dev>

Max Brunsfeld and Mikayla created

a1c4716 Potential fix for #2422 (#4197)

Click to expand commit body
- it seems like layer.drawable_size() is 0,0 in metal_renderer.rs:189 
- we set this in two places:
    - in response to a CALayerDelegate setFrameSize: event
- in response to a CALayerDelegate viewDidChangeBackingProperties:
event.
- it looks like if we don't set it in either of these cases we get a
different failure mode: the view is zoomed just wrong.
- That said, I can reproduce the screenshot if .scale_factor() returns
0.
- This might happen if [nativeWindow screen] is nil, which happens when
the window is off screen.
    - possible that zed started with offscreen window?
- I would expect that viewDidChangeBackingProperties would fire when
that changed.
    - potential fix: default to 2.0

Release Notes:

- Fixed Zed occasionally rendering blank on laungh
([#2422](https://github.com/zed-industries/community/issues/2422)).

Conrad Irwin created

e896941 Fix certain hovers being cut off (#4196)

Click to expand commit body
Release Notes:

- Fixes a bug where the bottom of hover popovers would be cut off
([#2434](https://github.com/zed-industries/community/issues/2434)).

Mikayla Maki created

72cb865 jk (#4189)

Click to expand commit body
Add support for mapping `jk` to escape in vim mode.

This changes the behaviour of the keymatches when there are pending
matches.

Before: Even if there was a pending match, any complete matches would be
triggered and the pending state lost.

After: If there is a pending match, any complete matches are delayed by
1s, or until more keys are typed.

Release Notes:

- Added support for mapping `jk` in vim mode
([#2378](https://github.com/zed-industries/community/issues/2378)),
([#176](https://github.com/zed-industries/community/issues/176))

Conrad Irwin created

9d221a1 Z index with flicker fix (#4170)

Click to expand commit body
Part of `was_top_layer` was checking if a opaque level starts with the
current stacking order, but now that each entry in the order has an id,
those comparison checks were failing as every entry generated is now
unique

I'll admit I'm still a little fuzzy on the specific reasons for this
function to be defined as it is so I'd appreciate another set of eyes

Release Notes:

- N/A

Julia created

41a99c6 Potential fix for #2422

Conrad Irwin created

6419df8 Fix certain hovers being cut off

Mikayla created

942edbf Run tests even if lint/fmt/spell/squawk fails

Conrad Irwin created

c494777 TYPO

Conrad Irwin created

0903d29 Improve logic for reused bindings, add docs.

Conrad Irwin created

3b3252b Rewrote and documented `was_top_layer` logic

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

455d5ee Preserve stacking order ID order when reusing cached view state

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Julia and Antonio Scandurra created

6c4d024 TYPO

Conrad Irwin created

c5d7c8e Fix cmd-k left

Conrad Irwin created

831769c Ignore stacking order entry ids in `was_top_layer`

Julia created

2c3d980 Store a z-index id per-layer

Click to expand commit body
Co-Authored-By: Nathan Sobo <nathan@zed.dev>

Julia and Nathan Sobo created

7ec4f22 de-dbg!

Conrad Irwin created

5b906e7 Fix lightning bolt hover and git gutter mark overlapping (#4195)

Click to expand commit body
Bumps `gutter_padding_factor` from 3.5 to 4.0 due git mark on the gutter
becoming much thicker than in Zed1:
 
Current:

![current_zed_2](https://github.com/zed-industries/zed/assets/2690773/f7f0f76b-63a2-4790-a4f4-ca791b617a64)

Fixed:

![new_zed2](https://github.com/zed-industries/zed/assets/2690773/0075567d-e661-4140-8ffa-ec17d72f8e54)

Stable (no hover background appearing):

![zed_1](https://github.com/zed-industries/zed/assets/2690773/c3366845-b763-46f7-a2c7-48dd72dc4f10)

Release Notes:

- Fixed gutter marks overlapping with hover highlights

Kirill Bulatov created

7aa3d9d Fix lightning bolt hover and git gutter mark overlapping

Kirill Bulatov created

b5cb832 lsp-log: Reemit Editors search events.

Click to expand commit body
NextMatch/PreviousMatch did not work due to us not updating the match index in the buffer search (that relied on an event being emitted).

Piotr Osiewicz created

426ef75 Show diagnostics on hover (#4192)

Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2426

Release Notes:

- Fixed a bug that was preventing diagnostics from being shown on hover.

Antonio Scandurra created

f76a250 Show diagnostics on hover

Antonio Scandurra created

4312c7d Introduce `ZED_MEASUREMENTS=1` and `script/histogram` (#4191)

Click to expand commit body
With this pull request, we're introducing a `ZED_MEASUREMENTS` variable
which is used by the `measure` function to print to stderr how long it
took to execute a given closure. This is used right now to measure frame
time when a new frame is requested. This data can be plotted as a
histogram via `script/histogram`.

Here's a workflow I typically use:

- Run `export ZED_MEASUREMENTS=1`
- Checkout a commit that you want to measure the performance of
- Run zed in release mode and use it for 5-10 seconds
- Copy the printed measurements into a file, say `version-a`
- Checkout another commit that you want to measure the performance of
- Run zed in release mode and use it for 5-10 seconds
- Copy the printed measurements into a file, say `version-b`
- Run `script/histogram version-a version-b` (note that you can supply
however many files you want)

Release Notes:

- N/A

Antonio Scandurra created

de64de2 Introduce a `ZED_MEASUREMENTS` env var and use it to measure frame time

Antonio Scandurra created

10ca33c Introduce script/histogram to produce before/after comparisons

Antonio Scandurra created

2c737a1 Resize Nightly icons to same scale as Stable/Preview (#4179)

Click to expand commit body
I'm sure @iamnbutler can do a better job here, this is just hacky, but
the size of the icon when doing `Cmd+tab` has been bugging me, so I
thought I'd resize them quickly to the dimensions the Stable/Preview
icons have.

Release Notes:

- N/A

Thorsten Ball created

b9c7baf Merge remote-tracking branch 'origin/main' into jk

Conrad Irwin created

4143d3a Work on tests

Conrad Irwin created