Commits in v0.116.0-pre

Commit log

`6342023` Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle (#3127)

Click to expand commit body

rust-analyzer complains about a bunch of dependency cycles:

```
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> assistant(Idx::<CrateData>(35)), alternative path: assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> breadcrumbs(Idx::<CrateData>(88)), alternative path: breadcrumbs(Idx::<CrateData>(88)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> collab_ui(Idx::<CrateData>(129)), alternative path: collab_ui(Idx::<CrateData>(129)) -> feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> feedback(Idx::<CrateData>(219)), alternative path: feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> quick_action_bar(Idx::<CrateData>(480)), alternative path: quick_action_bar(Idx::<CrateData>(480)) -> assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> search(Idx::<CrateData>(553)), alternative path: search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> semantic_index(Idx::<CrateData>(556)), alternative path: semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> terminal_view(Idx::<CrateData>(643)), alternative path: terminal_view(Idx::<CrateData>(643)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> vim(Idx::<CrateData>(748)), alternative path: vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> welcome(Idx::<CrateData>(775)), alternative path: welcome(Idx::<CrateData>(775)) -> vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> assistant(Idx::<CrateData>(35)), alternative path: assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> breadcrumbs(Idx::<CrateData>(88)), alternative path: breadcrumbs(Idx::<CrateData>(88)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> collab_ui(Idx::<CrateData>(129)), alternative path: collab_ui(Idx::<CrateData>(129)) -> feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> feedback(Idx::<CrateData>(219)), alternative path: feedback(Idx::<CrateData>(219)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> quick_action_bar(Idx::<CrateData>(480)), alternative path: quick_action_bar(Idx::<CrateData>(480)) -> assistant(Idx::<CrateData>(35)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> search(Idx::<CrateData>(553)), alternative path: search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> semantic_index(Idx::<CrateData>(556)), alternative path: semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> terminal_view(Idx::<CrateData>(643)), alternative path: terminal_view(Idx::<CrateData>(643)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> vim(Idx::<CrateData>(748)), alternative path: vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
stderr: [ERROR project_model::workspace] cyclic deps: zed(Idx::<CrateData>(791)) -> welcome(Idx::<CrateData>(775)), alternative path: welcome(Idx::<CrateData>(775)) -> vim(Idx::<CrateData>(748)) -> search(Idx::<CrateData>(553)) -> semantic_index(Idx::<CrateData>(556)) -> zed(Idx::<CrateData>(791))
```

so move the example into `zed` instead.

Kirill Bulatov created 2 years ago

`525ff6b` Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle

Kirill Bulatov created 2 years ago

`65a0ebf` Update get_channel_participant_details to include guests

Conrad Irwin created 2 years ago

`da2b808` Rename members to participants in db crate

Conrad Irwin created 2 years ago

`ec4391b` Add setting to disable completion docs

Julia created 2 years ago

`a7db2aa` Add check_is_channel_participant

Click to expand commit body

Refactor permission checks to load ancestor permissions into memory
for all checks to make the different logics more explicit.

Conrad Irwin created 2 years ago

`1c3ecc4` Whooooops

Julia created 2 years ago

`034e993` Remove old contact request notification mechanism, use notification instead

Max Brunsfeld created 2 years ago

`3241128` Make notification db representation more flexible

Max Brunsfeld created 2 years ago

`fed3ffb` Set up notification store for integration tests

Max Brunsfeld created 2 years ago

`1e1256d` Set RUST_LOG to info by default in zed-local script

Max Brunsfeld created 2 years ago

`69c6559` Fix use statement order

Max Brunsfeld created 2 years ago

`d1756b6` Start work on notification panel

Max Brunsfeld created 2 years ago

`50cf25a` Add notification doc comments

Max Brunsfeld created 2 years ago

`cf6ce0d` Start work on storing notifications in the database

Max Brunsfeld created 2 years ago

`c4fc9f7` Eagerly attempt to resolve missing completion documentation

Julia created 2 years ago

`44a30e2` Restore elevation docs

Marshall Bowers created 2 years ago

`ef18aaa` Merge branch 'main' into gpui2

Marshall Bowers created 2 years ago

`45f3a98` Remove old `ui` and `storybook` crates (#3125)

Click to expand commit body

This PR deletes the old `ui` and `storybook` crates in favor of their
newer variants that we'll be landing to `main` in the near future.

### Motivation

These crates are based off the old version of GPUI 2 (the `gpui2`
crate).

At this point we have since transitioned to the new version of GPUI 2
(the `gpui3` crate, currently still on the `gpui2` branch).

Having both copies around is confusing, so the old ones are going the
way of the dinosaurs.

Release Notes:

- N/A

Marshall Bowers created 2 years ago

`36bca4f` Restore click events on `Button`s using `on_mouse_down`

Marshall Bowers created 2 years ago

`6e5ad75` Use `Workspace::view` to construct the view

Marshall Bowers created 2 years ago

`79a61c2` Remove global `WorkspaceState`

Marshall Bowers created 2 years ago

`d23bb3b` Unbork markdown parse test by making links match

Julia created 2 years ago

`bac43ae` Fix panic when following due to disconnected channel notes views (#3124)

Click to expand commit body

In addition to fixing a panic, this makes it slightly more convenient to
re-open disconnected channel notes views. I didn't make it automatic,
but it will at least replace the previous, disconnected view.

Release Notes:

- Fixed a crash that sometimes occurred when following someone with a
disconnected channel notes view open.

Max Brunsfeld created 2 years ago

`e900ea2` Fix toggling of left panel

Marshall Bowers created 2 years ago

`8496d02` Hold the story view in the `StoryWrapper`

Marshall Bowers created 2 years ago

`fc94c4e` Render stories as `View`s

Marshall Bowers created 2 years ago

`c90d976` Remove debug logging in `Element` derive macro

Marshall Bowers created 2 years ago

`d320d3a` Remove hacky children

Marshall Bowers created 2 years ago

`24bab48` Use new children approach for `Toolbar`

Marshall Bowers created 2 years ago

`f5d6d7c` Mark channel notes as disconnected immediately upon explicitly signing out

Max Brunsfeld created 2 years ago

`85fe11f` Replace disconnected channel notes views when re-opening the notes

Max Brunsfeld created 2 years ago

`30979ca` Use new children approach for `Pane`s and `Toast`s

Marshall Bowers created 2 years ago

`ce8533f` Checkpoint

Nathan Sobo created 2 years ago

`78432d0` Add channel visibility columns and protos

Mikayla created 2 years ago

`540436a` Push role refactoring through RPC/client

Conrad Irwin created 2 years ago

`2e5461e` Exclude disconnected channel views from following messages

Max Brunsfeld created 2 years ago

`2044ccd` WIP

Antonio Scandurra created 2 years ago

`ca35573` WIP

Antonio Scandurra created 2 years ago

`85332ea` Race completion filter w/completion request & make not block UI

Julia created 2 years ago

`6dbe983` Checkpoint: Back to a compiling state

Marshall Bowers created 2 years ago

`262f588` Checkpoint

Marshall Bowers created 2 years ago

`4688a94` Allow file links in markdown & filter links a bit aggressively

Julia created 2 years ago

`207d843` Fix issues in `storybook2`

Marshall Bowers created 2 years ago

`a6b872b` Temporarily disable click handlers

Marshall Bowers created 2 years ago

`8cd1121` Reconcile with upstream changes

Marshall Bowers created 2 years ago

`9581279` Fix some merge errors

Marshall Bowers created 2 years ago

`002458f` Merge branch 'gpui2' into gpui2-ui

Marshall Bowers created 2 years ago

`a50977e` Add prettier support (#3122)

Kirill Bulatov created 2 years ago

`ef73bf7` Fix license issue

Kirill Bulatov created 2 years ago

Commit log

6342023 Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle (#3127)

525ff6b Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle

65a0ebf Update get_channel_participant_details to include guests

da2b808 Rename members to participants in db crate

ec4391b Add setting to disable completion docs

a7db2aa Add check_is_channel_participant

1c3ecc4 Whooooops

034e993 Remove old contact request notification mechanism, use notification instead

3241128 Make notification db representation more flexible

fed3ffb Set up notification store for integration tests

1e1256d Set RUST_LOG to info by default in zed-local script

69c6559 Fix use statement order

d1756b6 Start work on notification panel

50cf25a Add notification doc comments

cf6ce0d Start work on storing notifications in the database

c4fc9f7 Eagerly attempt to resolve missing completion documentation

44a30e2 Restore elevation docs

ef18aaa Merge branch 'main' into gpui2

45f3a98 Remove old `ui` and `storybook` crates (#3125)

36bca4f Restore click events on `Button`s using `on_mouse_down`

6e5ad75 Use `Workspace::view` to construct the view

79a61c2 Remove global `WorkspaceState`

d23bb3b Unbork markdown parse test by making links match

bac43ae Fix panic when following due to disconnected channel notes views (#3124)

e900ea2 Fix toggling of left panel

8496d02 Hold the story view in the `StoryWrapper`

fc94c4e Render stories as `View`s

c90d976 Remove debug logging in `Element` derive macro

d320d3a Remove hacky children

24bab48 Use new children approach for `Toolbar`

f5d6d7c Mark channel notes as disconnected immediately upon explicitly signing out

85fe11f Replace disconnected channel notes views when re-opening the notes

30979ca Use new children approach for `Pane`s and `Toast`s

ce8533f Checkpoint

78432d0 Add channel visibility columns and protos

540436a Push role refactoring through RPC/client

2e5461e Exclude disconnected channel views from following messages

2044ccd WIP

ca35573 WIP

85332ea Race completion filter w/completion request & make not block UI

6dbe983 Checkpoint: Back to a compiling state

262f588 Checkpoint

4688a94 Allow file links in markdown & filter links a bit aggressively

207d843 Fix issues in `storybook2`

a6b872b Temporarily disable click handlers

8cd1121 Reconcile with upstream changes

9581279 Fix some merge errors

002458f Merge branch 'gpui2' into gpui2-ui

a50977e Add prettier support (#3122)

ef73bf7 Fix license issue

`6342023` Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle (#3127)

`525ff6b` Remove zed -> ... -> semantic_index -> zed Cargo dependency cycle

`65a0ebf` Update get_channel_participant_details to include guests

`da2b808` Rename members to participants in db crate

`ec4391b` Add setting to disable completion docs

`a7db2aa` Add check_is_channel_participant

`1c3ecc4` Whooooops

`034e993` Remove old contact request notification mechanism, use notification instead

`3241128` Make notification db representation more flexible

`fed3ffb` Set up notification store for integration tests

`1e1256d` Set RUST_LOG to info by default in zed-local script

`69c6559` Fix use statement order

`d1756b6` Start work on notification panel

`50cf25a` Add notification doc comments

`cf6ce0d` Start work on storing notifications in the database

`c4fc9f7` Eagerly attempt to resolve missing completion documentation

`44a30e2` Restore elevation docs

`ef18aaa` Merge branch 'main' into gpui2

`45f3a98` Remove old `ui` and `storybook` crates (#3125)

`36bca4f` Restore click events on `Button`s using `on_mouse_down`

`6e5ad75` Use `Workspace::view` to construct the view

`79a61c2` Remove global `WorkspaceState`

`d23bb3b` Unbork markdown parse test by making links match

`bac43ae` Fix panic when following due to disconnected channel notes views (#3124)

`e900ea2` Fix toggling of left panel

`8496d02` Hold the story view in the `StoryWrapper`

`fc94c4e` Render stories as `View`s

`c90d976` Remove debug logging in `Element` derive macro

`d320d3a` Remove hacky children

`24bab48` Use new children approach for `Toolbar`

`f5d6d7c` Mark channel notes as disconnected immediately upon explicitly signing out

`85fe11f` Replace disconnected channel notes views when re-opening the notes

`30979ca` Use new children approach for `Pane`s and `Toast`s

`ce8533f` Checkpoint

`78432d0` Add channel visibility columns and protos

`540436a` Push role refactoring through RPC/client

`2e5461e` Exclude disconnected channel views from following messages

`2044ccd` WIP

`ca35573` WIP

`85332ea` Race completion filter w/completion request & make not block UI

`6dbe983` Checkpoint: Back to a compiling state

`262f588` Checkpoint

`4688a94` Allow file links in markdown & filter links a bit aggressively

`207d843` Fix issues in `storybook2`

`a6b872b` Temporarily disable click handlers

`8cd1121` Reconcile with upstream changes

`9581279` Fix some merge errors

`002458f` Merge branch 'gpui2' into gpui2-ui

`a50977e` Add prettier support (#3122)

`ef73bf7` Fix license issue