Commit log

c95a7c7 Address some TODOs in editor2 crate (#3445)

Click to expand commit body
* Fix crash when jumping to definition
* Enabling resolution of completions
* Make links in interactive text clickable
* Enable code paths that use `select_anchors`

Max Brunsfeld created

bda1dc7 Use `ButtonLike` for breadcrumb (#3452)

Click to expand commit body
This PR updates the (placeholder) breadcrumb to use the new `ButtonLike`
component.

Eventually this will need custom styling (e.g., syntax highlighting for
the symbol children), which is why we're using a `ButtonLike` as opposed
to a regular `Button`.

Release Notes:

- N/A

Marshall Bowers created

9d53287 Implement `Selectable` for buttons (#3451)

Click to expand commit body
This PR implements the `Selectable` trait for `ButtonLike`, `Button`,
and `IconButton`.

Release Notes:

- N/A

Marshall Bowers created

481e42a collab panel2 (#3447)

Click to expand commit body
[[PR Description]]

Release Notes:

- N/A

Conrad Irwin created

27a6761 Fix crash when jumping to a definition in the same buffer

Max Brunsfeld created

4c27f44 Merge branch 'main' into collab-panel2

Conrad Irwin created

04bbd10 Fix the selected state for the panel icons in the status bar (#3450)

Click to expand commit body
This PR fixes a bug where the selected state for the panel icons in the
status bar was not correctly reflecting whether the panel was open.

It was erroneously using the `is_open` state for the context menu.

Release Notes:

- N/A

Marshall Bowers created

b357ae4 Add new `Button` and `IconButton` components (#3448)

Click to expand commit body
This PR adds new `Button` and `IconButton` components built on top of
our new button abstractions.

Both of these buttons are built from the common `ButtonLike` base, and
implement the `ButtonCommon` (name TBD) trait in order to provide a
common interface.

There are still some visual tweaks that we'll need to make to the new
buttons, but those should be straightforward to make after we land this.

Release Notes:

- N/A

Marshall Bowers created

cd60d46 Merge branch 'main' into collab-panel2

Conrad Irwin created

0eef4d0 Scrollyscrolly

Conrad Irwin created

0b8f906 Implement highlighting of go-to-definition links

Max Brunsfeld created

4f04020 Fix mouse interaction on contact subsections

Conrad Irwin created

9451bd6 Implement completion-resolution in editor2

Click to expand commit body
Enable the completion tests in editor2.

Max Brunsfeld created

3bdd51c Availability indicators

Conrad Irwin created

4ebae4d Make LeftSlot take an element

Conrad Irwin created

df5de47 Make `toggle` method accept `impl Into<Option<bool>>` (#3446)

Click to expand commit body
This PR makes the `toggle` method on the various list components accept
an `impl Into<Option<bool>>` instead of just an `Option<bool>`.

This allows a caller with just a `bool` avoid having to wrap the
`Option` themselves.

Release Notes:

- N/A

Marshall Bowers created

2bd4281 Use pointer cursor style for clickable ranges in InteractiveText

Max Brunsfeld created

fc2251e Implement SelectionsCollection::select_anchor_ranges

Max Brunsfeld created

fb377ae Context menu, Dragon Drop, for collab panel (#3441)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

d8ed7c0 Move `GraphicSlot` out of `components` module (#3444)

Click to expand commit body
This PR moves the `GraphicSlot` definition out of the `components`
module, as it doesn't contain a component.

Release Notes:

- N/A

Marshall Bowers created

6ab3825 No moar toggleable

Conrad Irwin created

87cf0cf Merge branch 'main' into collab-panel2

Conrad Irwin created

0d31722 Style hover popover (#3443)

Click to expand commit body
[[PR Description]]

This PR styles the hover popover, and sets it on the [second elevation
level](https://zed-docs.vercel.app/doc/ui2/trait.StyledExt.html#method.elevation_2).

![CleanShot 2023-11-29 at 14 55
55@2x](https://github.com/zed-industries/zed/assets/1714999/01589b2a-d6e2-4baa-ba5d-050f06cf2c58)


Release Notes:

- N/A

Nate Butler created

3c05d57 Style hover popover

Nate Butler created

509504d Rework `Disclosure` component (#3442)

Click to expand commit body
This PR reworks the `Disclosure` component.

The primary goal here was to remove the illegal state where a
`Disclosure` is rendered with a `Toggle::NotToggleable` state, as the
`Disclosure` shouldn't exist at all in this case.

Release Notes:

- N/A

Marshall Bowers created

139708d Merge branch 'main' into collab-panel2

Conrad Irwin created

7e5aa5c More drag'n'drop fixes

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

e77846d Rework `Toggle` into `Toggleable` and `ToggleState`

Marshall Bowers created

e377bd8 Add channel drag'n'drop

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Conrad Irwin and Max created

6f5cc0a Rework `Disclosure` component

Marshall Bowers created

e99fa77 Reorganize list components (#3440)

Click to expand commit body
This PR reorganizes the list components so that each of the sub
components lives in its own file.

### Motivation

I've seen a number of folks have trouble finding the `ListItem`
definition while pairing, so having it in its own file seems more
self-explanatory.

Release Notes:

- N/A

Marshall Bowers created

41e7653 Channel Context Menu

Conrad Irwin created

c7b79c9 Remove unnecessary constructor and `Clone` derives

Marshall Bowers created

390b0d8 Reorganize list components

Marshall Bowers created

ee260a5 Progress

Conrad Irwin created

960ef71 Add a context menu to the project panel (#3393)

Click to expand commit body
This PR adds a context menu to the project panel in Zed2.

* [x] Allow the context menu to extend outside of the project panel's
bounds
* [x] Add keyboard shortcuts to the context menu
* [x] Dismiss the context menu
    * [x] when running an action
    * [x] when changing selection in the project panel

Release Notes:

NA

Max Brunsfeld created

3e2c517 Add `Disableable` trait (#3439)

Click to expand commit body
This PR adds a new `Disableable` trait to use for elements that are
capable of being disabled.

Release Notes:

- N/A

Marshall Bowers created

dbfc7d3 Merge branch 'main' into project-panel-context-menu

Max Brunsfeld created

c23a610 Move padding on uniform list inside the scrollable area (#3437)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

233aac5 Make DismissEvent a unit struct

Click to expand commit body
Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

043cef8 Remove unneeded wrapping `div`s in `ListItem` left content (#3438)

Click to expand commit body
This PR removes some unneeded wrapping `div`s around the left content in
`ListItem`s.

Release Notes:

- N/A

Marshall Bowers created

ac34229 Add keyboard control over context menus

Click to expand commit body
Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

912c30c Remove unneeded `.clone`s

Marshall Bowers created

97e6fd2 Remove unneeded wrapping divs in `ListItem` left content

Marshall Bowers created

a8bf083 Button2 – Part1 (#3420)

Click to expand commit body
## TODO

- [x] Remove `InteractionState`
- [ ] `Selectable` should use `Selection` instead of a boolean
- [x] Clean out ui2 prelude
- [ ] Build out button2 button types
- [ ] Port old buttons

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>

Nate Butler and Marshall Bowers created

a4035f1 WIP

Antonio Scandurra created

35481e2 Move padding on uniform list inside the scrollable area

Conrad Irwin created

5d59108 Inviting/Responding/Creating Channels... etc. (#3433)

Click to expand commit body
Release Notes:

- n/a

Conrad Irwin created

f735f52 v0.116.x dev

Joseph T. Lyons created

a62c484 Make prettier more robust to offline work and errors (#3434)

Click to expand commit body
Refactors prettier support:

* moves away prettier-related code into a separate module, makes
prettier installation & start phases more type-restricted
* ensures prettier installation and start attempts are capped with a
fixed attempts amount: after it's exceeded, no further attempts to
install and/or start prettier area made
* improves default prettier management, by correctly preserving its
plugin set between (re) installations and always installing the prettier
server part
* slightly improves prettier logging 

Release Notes:

- N/A

Kirill Bulatov created