4e970e9
Use a different color for ignored files in the project panel
Max Brunsfeld created
4e970e9
Use a different color for ignored files in the project panel
Max Brunsfeld created
7ec68e0
Improve completion, action and shared project popovers' layout (#4226)
Before: * cutoff completion labels and docs <img width="801" alt="image" src="https://github.com/zed-industries/zed/assets/2690773/12fe39b2-a8a7-42d8-b697-e2a4fbd836b7"> * too long action labels start to introduce newlines and break the layout <img width="716" alt="image" src="https://github.com/zed-industries/zed/assets/2690773/a0530f1e-4200-4cc4-8e0f-9a63d04e4d5c"> * too long completion proposals are cut off <img width="1321" alt="image" src="https://github.com/zed-industries/zed/assets/2690773/1ec154a1-9de5-4e47-9e9f-632b3e33f42a"> After: * the docs are shifted, but both completions and docs are rendered entirely now <img width="1351" alt="image" src="https://github.com/zed-industries/zed/assets/2690773/ddb0baa4-88b6-45e9-b3e1-496c0d6a0d0f"> * <img width="750" alt="image" src="https://github.com/zed-industries/zed/assets/2690773/102ed77c-d7d0-41d2-a4a0-a8c73285ea8a"> * completions are not jumping in sized anymore, with all elements aligned to occupy max elements' width and height <img width="1459" alt="image" src="https://github.com/zed-industries/zed/assets/2690773/483e3534-b00a-423c-a848-3c4ca1199510"> Release Notes: - Improved completion and action label layouts
Kirill Bulatov created
bf35b78
Allow both action and completion lists to occupy max width and height of its element
Kirill Bulatov created
035bd79
collab 0.40.1
Max Brunsfeld created
67b7d74
Exclude staff from CLA check (#4225)
Max Brunsfeld created
513ddf1
Change background for the max width of the completion/action elements
Kirill Bulatov created
b84f4a3
Fix assertion in test_get_users
Max Brunsfeld created
cad6bab
Fix sharing project notification size
Kirill Bulatov created
4c039d0
Fix code actions being too small
Kirill Bulatov created
f3b014c
Fix default value of users created_at in sqlite schema
Max Brunsfeld created
1fd72d2
Exclude staff from CLA check
Max Brunsfeld created
74cf199
Remove unused screenshot (#4224)
This PR removes an unused screenshot from the `assets/` directory. As a note, we should probably be careful about what kinds of extraneous binary assets we're committing to the repo (especially ones not required for Zed itself), as these can bloat the repo size. Release Notes: - N/A
Marshall Bowers created
74bdb48
Make completions menu to occupy more space
* make completion elements as wide as the longest element * make completion docs scrollable co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov and Piotr created
c4a028d
Make `was_top_layer_under_active_drag` more closely match logic of `was_top_layer` (#4222)
Release Notes: - N/A
Julia created
b98c935
Revise contributing.md (#4223)
Some adjustments to be less bold in our pairing commitments and clearer about the process for proposing an idea. Release Notes: - N/A
Nathan Sobo created
38c3590
Revise contributing.md
Nathan Sobo created
8ce7594
Drop active searchable item subscription when changing active item (#4220)
We were leaking the previous active item's subscription, which meant that we would receive the `MatchesInvalidated` event as many times as we changed items. Release Notes: - Fixed a performance issue when switching the active item while the search bar was open.
Antonio Scandurra created
21d6751
Make `was_top_layer_under_active_drag` more closely match logic of `was_top_layer`
Co-Authored-By: Max Brunsfeld <max@zed.dev>
Julia and Max Brunsfeld created
3d5da2f
less secret (#4221)
- Remove ZED_SECRET_CLIENT_TOKEN - Remove ZED_CLIENT_SECRET_TOKEN Neither of these were ever actually a secret. Release Notes: - N/A
Conrad Irwin created
b5ee7f8
Remove ZED_CLIENT_SECRET_TOKEN
Conrad Irwin created
ff60d88
Remove ZED_SECRET_CLIENT_TOKEN
Conrad Irwin created
b151e12
Drop active searchable item subscription when changing active item
We were leaking the previous active item's subscription, which meant that we would receive the `MatchesInvalidated` event as many times as we changed items. Co-Authored-By: Thorsten Ball <thorsten@zed.dev> Co-Authored-By: Mikayla Maki <mikayla@zed.dev>
Antonio Scandurra , Thorsten Ball , and Mikayla Maki created
61dfec2
Add keymatch modes so terminal can have cmd-k (#4219)
This isn't my favorite idea of a fix, but it does work for now, and it seems likely the terminal will need to configure other aspects of action dispatch in the future. In the future we should explore making it possible to do this via the keymap, either by making disabling bindings more robust; or by having a way to indicate immediate mode per binding. Release Notes: - Fixed a bug where cmd-k in terminal took 1s
Conrad Irwin created
21e6b09
Remove license-file from Cargo.toml as it is apparently redundant (#4218)
Release Notes: - N/A
Piotr Osiewicz created
056da0a
Add keymatch modes so terminal can have cmd-k
This isn't my favorite idea of a fix, but it does work for now, and it seems likely the terminal will need to configure other aspects of action dispatch in the future. In the future we should explore making it possible to do this via the keymap, either by making disabling bindings more robust; or by having a way to indicate immediate mode per binding.
Conrad Irwin created
5ea3119
Add missing license for derive_refineable (#4217)
Missed one crate. Release Notes: - N/A
Piotr Osiewicz created
678bddd
chore: Add crate licenses. (#4158)
- GPUI and all dependencies: Apache 2 - Everything else: AGPL Here's a script that I've generated for it: https://gist.github.com/osiewicz/6afdd6626e517da24a2092807e6f0b6e Release Notes: - N/A --------- Co-authored-by: David <david@zed.dev>
Piotr Osiewicz and David created
edfc2e8
Make scripts/histogram ignore lines without frame duration (#4214)
Previously the script would choke on lines generated, for example, by `cargo run`. This just skips lines that don't contain `frame duration:`. Release Notes: - N/A
Thorsten Ball created
802a7f5
Print error message and skip line
Thorsten Ball created
003073d
Fix scroll jitter by ignoring autoscroll events if following (#4216)
When following someone else we saw jitter because `ScrollPositionChanged` events were battling `SelectionsChanged` events, both of which were scrolling the viewport. This ignores the ScrollPositionChanged if autoscrolling is on. Release Notes: - Fixed jittery scrolling when following someone else that had a bigger viewport.
Thorsten Ball created
030b20a
Fix scroll jitter by ignoring autoscroll events if following
When following someone else we saw jitter because `ScrollPositionChanged` events were battling `SelectionsChanged` events, both of which were scrolling the viewport. This ignores the ScrollPositionChanged if autoscrolling is on. Co-authored-by: Antonio <antonio@zed.dev> Co-authored-by: Julia <julia@zed.dev>
Thorsten Ball , Antonio , and Julia created
0db9c27
Make scripts/histogram ignore lines without frame duration
Previously the script would choke on lines generated, for example, by `cargo run`. This just skips lines that don't contain `frame duration:`. Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
a802bb2
Fix horizontal scroll going too far to the left (#4213)
Previously one could scroll infinitely to the left. This clams it to 0. Release Notes: - Fixed horizontal scroll possibly going too far to the left.
Antonio Scandurra created
c8c605d
Fix horizontal scroll going too far to the left
Previously one could scroll infinitely to the left. This clams it to 0. Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
4cccb4e
Fix LSP shenanigans when opening and/or editing settings files (#4212)
Fixes * LSP servers never being shut down on worktree release * worktrees (and LSP servers) being re-created for settings files on every opening Also, * removes `async` from `workspace_configuration` to simplify the code: we only return static configurations now Release Notes: - Fixed excessive LSP server creation for Zed settings files
Kirill Bulatov created
5e0cabc
Create a special worktree for settings files
To avoid LSP server restarts/leaks when those are being opened co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov and Piotr created
fc7458d
Trim diagnostic messages to fix rendering bug (#4210)
Before this change a diagnostic message with a trailing newline (e.g. `line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`. But the content we then display in this block had 3 "lines", which pushed the content out of the block. This fixes the issue by trimming the newlines at the end from the diagnostics. Release Notes: - Fixed rendering multi-line diagnostic errors inside of the editor.
Thorsten Ball created
accb4f8
Cache last used layer_id for StackingOrder (#4211)
This optimizes rendering time by saving computation of the layer_id and comparison when inserting it into the `BTreeMaps`.  Release Notes: - Improved rendering performance when a lot of text is being displayed.
Thorsten Ball created
bf843e2
Cache last used layer_id for StackingOrder
This optimizes rendering time by saving computation of the layer_id and comparison when inserting it into the `BTreeMaps`. Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
ab8585e
Remove the `async` modifier from the `workspace_configuration` method
Kirill Bulatov created
f8939fd
Trim diagnostic messages to fix rendering bug
Before this change a diagnostic message with a trailing newline (e.g. `line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`. But the content we then display in this block had 3 "lines", which pushed the content out of the block. This fixes the issue by trimming the newlines at the end from the diagnostics. Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball and Antonio created
351914f
Clean up LSP servers on worktree release
Kirill Bulatov created
5a9f1e4
fix local collab tests (#4209)
I was unable to run the collab tests locally because I would run out of file descriptors. From some digging it turned out that tokio allocates a new file descriptor to do work on the CurrentThread using KQUEUE. We create a new tokio Runtime with each database connection, and these database connections were being retained by the Client, which is retained by the Context. Cleaning up our leaked contexts (and an unrelated retain cycle in the UserStore) fixes the problem (though does make me wonder if a different approach might be preferrable). Release Notes: - N/A
Conrad Irwin created
ce0833e
Fix off-by-one highlighting in hover tooltip (#4206)
rust analyzer has a tendency to return markdown of the form: ```rust // <-- note the leading space blah blah blah ``` This is clearly defectuous, so we used to .trim() the output. Unfortunately we trim after applying syntax highlighting, so that causes the output to look goofy. Fix this by updating the highlighting when we trim. [[PR Description]] Release Notes: - Fixed a bug where syntax highlighting was off in hover tooltips
Conrad Irwin created
309148f
Update Channel membership UI (#4203)
* Remove ability to act on people defined in parent channels * Show promote buttons on guests Release Notes: - Improved channel membership manangement
Conrad Irwin created
d4e83e4
Fix docs
Conrad Irwin created
34efb23
Fix a circular reference between Client and UserStore
Before this change once the UserStore had been created, the Client would never be dropped.
Conrad Irwin created
0b1b758
Fix leaking test contexts
I was unable to run the collab tests locally because I would run out of file descriptors. From some digging it turned out that tokio allocates a new file descriptor to do work on the CurrentThread using KQUEUE. We create a new tokio Runtime with each database connection, and these database connections were being retained by the Client, which is retained by the Context. Cleaning up our leaked contexts fixes the problem (though does make me wonder if a different approach might be preferrable).
Conrad Irwin created
3d5bce6
Fix clippy lints in GPUI and finish documenting GPUI modules (#4188)
TODO: - [x] Clippy pass - [x] Element / WindowContext refactor - [x] `geometry ` - [x] `text_system` - [x] `styled` - [x] `element_cx` Release Notes: - N/A
Mikayla Maki created
a241a13
fix test
Mikayla created