Commit log

75fdaeb Detect when a track is unpublished due to reconnecting to livekit

Click to expand commit body
Co-authored-by: Julia <julia@zed.dev>

Max Brunsfeld and Julia created

2d1eb0c Expose a single `updates` stream from live_kit_client::Room

Click to expand commit body
Co-authored-by: Julia <julia@zed.dev>

Max Brunsfeld and Julia created

0dca67f Add --top flag to zed-local script, for making windows take up half the screen

Max Brunsfeld created

b907f37 Fix fold-related panic (#4008)

Click to expand commit body
Although it's not super clear why this fails; in zed1 we used to have a
bounds
check. Restoring the bounds check for now, but leaving a debug_assert!
in case
a local reproduction happens.

Release Notes:

- Fix a panic that happened sometimes when rendering folds

Conrad Irwin created

766a869 Fix fold-related panic

Conrad Irwin created

b4444bd Rename field in telemetry struct

Joseph T. Lyons created

3c1ed15 Remove active call data when it was accepted (#4007)

Click to expand commit body
That hopefully helps with call notifications sometimes not being closed

Release Notes:

- N/A

Kirill Bulatov created

2e9c9ad Remove active call data when it was accepted

Click to expand commit body
That hopefully helps with call notifications sometimes not being closed

co-authored-by: Max <max@zed.dev>

Kirill Bulatov and Max created

e0dd5a5 Debugging

Kirill Bulatov created

7b3e7ee Enfoce no dbg! and todo! in Rust code via clippy lints in the CI job

Kirill Bulatov created

9df29fb WIP

Joseph T. Lyons created

b26a468 Merge branch 'main' into instrument-keyboard-events

Joseph T. Lyons created

52eab41 zed 0.119.5

Joseph T. Lyons created

497c42e Merge branch 'main' into v0.119.x

Joseph T. Lyons created

f71a0cd Remove last todos

Mikayla created

4bcac68 Restore GPUI test

Mikayla created

9553759 Remove todo from search tests

Piotr Osiewicz created

7ef8839 Fix seg fault when using the WindowContext::on_window_should_close() API

Mikayla created

2a09c6a Restore missing test

Mikayla created

c98d7ad Audit all TODOs in Zed and mark port related todos

Mikayla created

02ef6fc Ensure `ArenaRef` pointers are aligned to their contained type (#4002)

Click to expand commit body
We think this may fix a segfault that sometimes occurs during
`display_layer`.

Max Brunsfeld created

61a9a3a Revert "Remove ChannelsAlpha flag"

Click to expand commit body
This reverts commit 1c1151a0ed2f26ea2cf637aa4d07567ab6b4f372.

Conrad Irwin created

69a93ed Ensure `ArenaRef` pointers are aligned to their contained type

Click to expand commit body
Co-Authored-By: Antonio Scandurra <me@as-cii.com>

Max Brunsfeld and Antonio Scandurra created

8d1bca4 Remove extra assertion

Click to expand commit body
As part of debugging the port of following tests we added an assertion
that the project was dropped. Now that we initialize the editor and
handle focus correctly in tests, the project is retained by
`refresh_document_highlights`. That doesn't affect the meaning of the
tests

Conrad Irwin created

282184a editor: Use inclusive ranges for git diff resolution. (#3999)

Click to expand commit body
The culprit was in display map which was resolving next valid point for
the editor, without regard for whether that point belongs to the same excerpt. We now make an end point a minimum of the end point passed in and the start of excerpt header, if there are any. 
This bug existed in Zed1 as well.

Fixes: Diff markers in multibuffer search overlap with dividers between
excepts (shouldn't extend all the way into the divider region)


Release Notes:
- Fixed diff markers being drawn incorrectly near headers in multibuffer
views.

Piotr Osiewicz created

f16331a Remove ChannelsAlpha flag (#4001)

Click to expand commit body
Welcome to the party!

[[PR Description]]

Release Notes:

- Added Channels for structured real-time collaboration (TODO: link)

Conrad Irwin created

5dff458 Ensure focus_in and focus_out fire on window activation (#3993)

Click to expand commit body
Also:
- Rename cx.on_blur to cx.on_focus_lost
- Fix a bug where notify calls in focus handlers were ignored
- Fix a bug where vim would get stuck in the wrong mode when switching
  windows

Release Notes:

- (preview only) vim: fix switching between multiple windows

Conrad Irwin created

1c1151a Remove ChannelsAlpha flag

Click to expand commit body
Welcome to the party!

Conrad Irwin created

f8e4fd0 collab 0.36.0

Conrad Irwin created

a520336 Use the `.selected` style for buffer search option buttons (#4000)

Click to expand commit body
This PR updates the `IconButton`s used to control the buffer search
options to use the `.selected` state to denote when they are active.
This matches what we are doing in the project search.

This should improve the contrast in certain themes.

Release Notes:

- Improved the active style for the search options in buffer search.

Marshall Bowers created

aff119b Fix possessive "its" in docs and comments (#3998)

Click to expand commit body
This PR fixes a number of places where we were incorrectly using "it's"
where we needed to use the possessive "its".

Release Notes:

- N/A

Marshall Bowers created

1c77104 chore: Enable asset compression

Click to expand commit body
This reduces size of release binary by ~20% from 134MB to 107MB without noticeable slowdown on startup. Assets are decompressed granularly, on first access

Piotr Osiewicz created

1d000f1 Fix uniform_list scrolling logic (#3996)

Click to expand commit body
Release Notes:

- Fixed theme selector not showing currently selected theme on open

Kirill Bulatov created

c197ea4 Simplify uniform list scrolling logic

Kirill Bulatov created

f57ff1c Make the scroll position updated as soon as possible to the correct deferred value

Click to expand commit body
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>

Kirill Bulatov and Antonio Scandurra created

927e0db An attempt to defer scrolls during empty initial state

Kirill Bulatov created

bbccf48 Disable synthetic drag for drag and drop (#3995)

Click to expand commit body
New drag and drop is capable of emitting fake mouse events already, no
need to fake it more.

Release Notes:

- Fixed excessive pane regions flicker on certain drag and drop state

Kirill Bulatov created

6809b92 Disable synthetic drag on drag and drop

Click to expand commit body
Otherwise, conflicting MouseMove events are generated and page regions start to flicker.

Kirill Bulatov created

d3d6b53 WIP

Joseph T. Lyons created

3c2ebc3 Prototype cursor sharing (the inefficient way) (#3970)

Click to expand commit body
Release Notes:

- Sync guest users' cursor positions

Conrad Irwin created

5d3f561 guest promotion (#3969)

Click to expand commit body
Release Notes:

- Adds the ability to promote read-only guests to read-write
participants in calls

Conrad Irwin created

2ca4627 Fix some tests (mostly more run_until_parked's...)

Conrad Irwin created

8ceb9fd Run migrations on development server start (#3971)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

72c022f Ensure focus-sensitive tests have active windows

Conrad Irwin created

1bf33b4 Ensure focus_in and focus_out fire on window activation

Click to expand commit body
Also:
- Rename cx.on_blur to cx.on_focus_lost
- Fix a bug where notify calls in focus handlers were ignored
- Fix a bug where vim would get stuck in the wrong mode when switching
  windows

Conrad Irwin created

45baad2 Remove or fix stale todos (#3990)

Click to expand commit body
The software equivalent of dusting

Release Notes:

-

Mikayla Maki created

e786e22 And a few more todos

Mikayla created

9ce7ef8 Remove the last of the major todos

Mikayla created

8cb291b Take a different approach to rendering channel buttons (#3991)

Click to expand commit body
This PR changes the approach we're using to render the channel buttons
to use a more straightforward (and less hacky) approach.

### Motivation

Even with the variety of hacks that were employed to make the current
approach work, there are still a number of issues with the current
solution:

- Hovering in the empty space to the left of a channel doesn't correctly
apply the hover background to the container for the channel buttons
- Hovering to the very right of the collab panel (right on top of the
drag handle) causes the channel button container to apply its hover
background without applying it to the rest of the row
- The buttons would still get pushed off to the right by the indent
space in the channel tree, resulting in jagged indicators at small sizes

Additionally, the rectangular background placed behind the channel
buttons still didn't look great when it overlapped with the channel
names.

### Explanation

For these reasons, I decided to explore a simpler approach that
addresses these issues, albeit with some tradeoffs that I think are
acceptable.

We now render the absolutely-positioned button container as a sibling
element of the `ListItem`. This is to avoid issues with the container
getting pushed around based on the contents of the `ListItem` rather
than staying absolutely positioned at the end of the row.

We also have gotten rid of the background for the button container, and
now rely on the background of the individual `IconButton`s to occlude
the channel name behind them when the two are overlapping.

Here are some examples of the new UI in various configurations:

#### When the channel entry is hovered

<img width="270" alt="Screenshot 2024-01-09 at 6 15 24 PM"
src="https://github.com/zed-industries/zed/assets/1486634/0207a129-30eb-4067-8490-3b6c9cbf75ea">

#### Overlapping with the channel name

<img width="229" alt="Screenshot 2024-01-09 at 6 15 43 PM"
src="https://github.com/zed-industries/zed/assets/1486634/0a67507e-45c8-4325-a71e-d416edc3a115">

#### Narrow collab panel

<img width="116" alt="Screenshot 2024-01-09 at 6 16 07 PM"
src="https://github.com/zed-industries/zed/assets/1486634/887ebaa3-e4d6-4497-9141-afcc8b7cd356">

### Tradeoffs

The new approach comes with the following tradeoffs that I am currently
aware of:

The occlusion can look a little weird when the icons are in the middle
of a channel name (as opposed to fully occluding the end of the channel
name):
<img width="190" alt="Screenshot 2024-01-09 at 6 24 32 PM"
src="https://github.com/zed-industries/zed/assets/1486634/0062b806-1b8f-47eb-af8d-f061d9829366">

Hovering one of the icons causes the icon to be hovered instead of the
row:

<img width="232" alt="Screenshot 2024-01-09 at 6 31 38 PM"
src="https://github.com/zed-industries/zed/assets/1486634/cbcc1a45-64d2-4890-8ad6-c5a5ee961b86">

Release Notes:

- Improved the way channel buttons are displayed.

Marshall Bowers created

276bfa0 Merge branch 'main' into guest-promotion

Conrad Irwin created