Commit log

edfc2e8 Make scripts/histogram ignore lines without frame duration (#4214)

Click to expand commit body
Previously the script would choke on lines generated, for example, by
`cargo run`.

This just skips lines that don't contain `frame duration:`.

Release Notes:

- N/A

Thorsten Ball created

802a7f5 Print error message and skip line

Thorsten Ball created

003073d Fix scroll jitter by ignoring autoscroll events if following (#4216)

Click to expand commit body
When following someone else we saw jitter because
`ScrollPositionChanged` events were battling `SelectionsChanged` events,
both of which were scrolling the viewport.

This ignores the ScrollPositionChanged if autoscrolling is on.

Release Notes:

- Fixed jittery scrolling when following someone else that had a bigger
viewport.

Thorsten Ball created

030b20a Fix scroll jitter by ignoring autoscroll events if following

Click to expand commit body
When following someone else we saw jitter because
`ScrollPositionChanged` events were battling `SelectionsChanged` events,
both of which were scrolling the viewport.

This ignores the ScrollPositionChanged if autoscrolling is on.

Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Julia <julia@zed.dev>

Thorsten Ball , Antonio , and Julia created

0db9c27 Make scripts/histogram ignore lines without frame duration

Click to expand commit body
Previously the script would choke on lines generated, for example, by
`cargo run`.

This just skips lines that don't contain `frame duration:`.

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

a802bb2 Fix horizontal scroll going too far to the left (#4213)

Click to expand commit body
Previously one could scroll infinitely to the left. This clams it to 0.

Release Notes:

- Fixed horizontal scroll possibly going too far to the left.

Antonio Scandurra created

c8c605d Fix horizontal scroll going too far to the left

Click to expand commit body
Previously one could scroll infinitely to the left. This clams it to 0.

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

4cccb4e Fix LSP shenanigans when opening and/or editing settings files (#4212)

Click to expand commit body
Fixes
* LSP servers never being shut down on worktree release
* worktrees (and LSP servers) being re-created for settings files on
every opening

Also,
* removes `async` from `workspace_configuration` to simplify the code:
we only return static configurations now

Release Notes:

- Fixed excessive LSP server creation for Zed settings files

Kirill Bulatov created

5e0cabc Create a special worktree for settings files

Click to expand commit body
To avoid LSP server restarts/leaks when those are being opened

co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

fc7458d Trim diagnostic messages to fix rendering bug (#4210)

Click to expand commit body
Before this change a diagnostic message with a trailing newline (e.g.
`line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`.
But the content we then display in this block had 3 "lines", which
pushed the content out of the block.

This fixes the issue by trimming the newlines at the end from the
diagnostics.

Release Notes:

- Fixed rendering multi-line diagnostic errors inside of the editor.

Thorsten Ball created

accb4f8 Cache last used layer_id for StackingOrder (#4211)

Click to expand commit body
This optimizes rendering time by saving computation of the layer_id and
comparison when inserting it into the `BTreeMaps`.


![layer_id_caching](https://github.com/zed-industries/zed/assets/1185253/2944fa3d-586b-4a9a-9dfc-0acf59b77402)

Release Notes:

- Improved rendering performance when a lot of text is being displayed.

Thorsten Ball created

bf843e2 Cache last used layer_id for StackingOrder

Click to expand commit body
This optimizes rendering time by saving computation of the layer_id and
comparison when inserting it into the `BTreeMaps`.

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

ab8585e Remove the `async` modifier from the `workspace_configuration` method

Kirill Bulatov created

f8939fd Trim diagnostic messages to fix rendering bug

Click to expand commit body
Before this change a diagnostic message with a trailing newline (e.g.
`line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`.
But the content we then display in this block had 3 "lines", which
pushed the content out of the block.

This fixes the issue by trimming the newlines at the end from the
diagnostics.

Co-authored-by: Antonio <antonio@zed.dev>

Thorsten Ball and Antonio created

351914f Clean up LSP servers on worktree release

Kirill Bulatov created

5a9f1e4 fix local collab tests (#4209)

Click to expand commit body
I was unable to run the collab tests locally because I would run out of
file descriptors.

From some digging it turned out that tokio allocates a new file
descriptor to do work on the CurrentThread using KQUEUE.

We create a new tokio Runtime with each database connection, and these
database connections were being retained by the Client, which is
retained by the Context.

Cleaning up our leaked contexts (and an unrelated retain cycle in the
UserStore) fixes the problem (though does make me
wonder if a different approach might be preferrable).

Release Notes:

- N/A

Conrad Irwin created

ce0833e Fix off-by-one highlighting in hover tooltip (#4206)

Click to expand commit body
rust analyzer has a tendency to return markdown of the form:

```rust
 // <-- note the leading space
blah blah blah
```

This is clearly defectuous, so we used to .trim() the output.

Unfortunately we trim after applying syntax highlighting, so that causes
the output to look goofy.

Fix this by updating the highlighting when we trim.

[[PR Description]]

Release Notes:

- Fixed a bug where syntax highlighting was off in hover tooltips

Conrad Irwin created

309148f Update Channel membership UI (#4203)

Click to expand commit body
* Remove ability to act on people defined in parent channels
* Show promote buttons on guests

Release Notes:

- Improved channel membership manangement

Conrad Irwin created

d4e83e4 Fix docs

Conrad Irwin created

34efb23 Fix a circular reference between Client and UserStore

Click to expand commit body
Before this change once the UserStore had been created, the Client would
never be dropped.

Conrad Irwin created

0b1b758 Fix leaking test contexts

Click to expand commit body
I was unable to run the collab tests locally because I would run out of
file descriptors.

From some digging it turned out that tokio allocates a new file
descriptor to do work on the CurrentThread using KQUEUE.

We create a new tokio Runtime with each database connection, and these
database connections were being retained by the Client, which is
retained by the Context.

Cleaning up our leaked contexts fixes the problem (though does make me
wonder if a different approach might be preferrable).

Conrad Irwin created

3d5bce6 Fix clippy lints in GPUI and finish documenting GPUI modules (#4188)

Click to expand commit body
TODO:
- [x] Clippy pass
- [x] Element / WindowContext refactor
- [x] `geometry `
- [x] `text_system`
- [x] `styled`
- [x] `element_cx`

Release Notes:

- N/A

Mikayla Maki created

a241a13 fix test

Mikayla created

938b84c Finish documenting GPUI

Mikayla created

eab2e21 Document more styling functions

Mikayla created

a99d5b8 WIP: text_system

Mikayla created

0c3fb44 Document geometry

Mikayla created

1902df9 WIP: Start geometry crate

Mikayla created

1f94463 Switch Arc<Mutex<Keymap>> to Rc<RefCell<Keymap>>, a relic of the GPUI2 port.

Click to expand commit body
Make gpui pass clippy

Mikayla created

ba5b969 collab 0.40.0

Max Brunsfeld created

a529a53 Don't allow granting write access to guests who haven't signed the CLA, if the channel requires the zed CLA (#4208)

Max Brunsfeld created

2570808 Add requires_zed_cla column to channels table

Click to expand commit body
Don't allow granting guests write access in a call where the channel
or one of its ancestors requires the zed CLA, until that guest has
signed the Zed CLA.

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

f2eb78b Avoid overwriting mouse wheel scroll with selection auto-scroll (#4207)

Click to expand commit body
Release Notes:

- Fixed an issue where mouse wheel events could be ignored while
selecting text near the top or bottom of the editor with the mouse.

Julia created

a2aa47a Avoid overwriting mouse wheel scroll with selection auto-scroll

Julia created

fd8d2d4 One off

Conrad Irwin created

92c4c84 Fix the fonts panic and completions in the settings (#4205)

Click to expand commit body
* Do not add fonts' `font_family` into the font completion list, if
there's no corresponding attribute in the font data
* Remove `font_style_name` and `font_name` attribute from the completion
options, since those bring `-Italic`, `-Bold` variants that are not
family names (which we use to load the fonts, so they are useless)

Release Notes:

- Improved font family names completion in the settings

Kirill Bulatov created

a75fa35 Fix the fonts panic

Click to expand commit body
co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

98d514f Fix off-by-one highlighting in hover tooltip

Click to expand commit body
rust analyzer has a tendency to return markdown of the form:

```rust
 // <-- note the leading space
blah blah blah
```

This is clearly defectuous, so we used to .trim() the output.

Unfortunately we trim after applying syntax highlighting, so that causes
the output to look goofy.

Fix this by updating the highlighting when we trim.

Conrad Irwin created

676d2cb collab 0.39.0

Max Brunsfeld created

44c2b8b Add REST APIs for signing the CLA, retrieving users who've signed the CLA (#4202)

Max Brunsfeld created

b9458fe Fix call to get_or_create_user in seed binary

Max Brunsfeld created

03e0089 Fix get_or_create_user test

Max Brunsfeld created

cd7f377 Allow checking CLA signatures by GitHub login

Click to expand commit body
This will be used by CLA Bot.

Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

a9ddef8 Update Channel membership UI

Click to expand commit body
* Remove ability to act on people defined in parent channels
* Show promote buttons on guests

Conrad Irwin created

43c2192 Hide editor hovers when a menu is open (#4200)

Click to expand commit body
Release Notes:

- Fixed a bug where editor hover state could appear while menu open
([#2384](https://github.com/zed-industries/community/issues/2384)).

Conrad Irwin created

56556d7 Add API for retrieving the date that a contributor signed the CLA

Click to expand commit body
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

6c937c4 Make POST /contributors API idempotent

Click to expand commit body
Co-authored-by: Marshall <marshall@zed.dev>

Max Brunsfeld and Marshall created

2bfbd72 Remove unused import? (#4201)

Click to expand commit body
Release builds are currently failing:
https://github.com/zed-industries/zed/actions/runs/7616903969/job/20744857084

It is unclear to me why debug builds are not.

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

2445df8 Remove unused import?

Conrad Irwin created

53b47c1 Hide editor hovers when a menu is open

Conrad Irwin created