edfc2e8
Make scripts/histogram ignore lines without frame duration (#4214)
Click to expand commit body
Previously the script would choke on lines generated, for example, by
`cargo run`.
This just skips lines that don't contain `frame duration:`.
Release Notes:
- N/A
003073d
Fix scroll jitter by ignoring autoscroll events if following (#4216)
Click to expand commit body
When following someone else we saw jitter because
`ScrollPositionChanged` events were battling `SelectionsChanged` events,
both of which were scrolling the viewport.
This ignores the ScrollPositionChanged if autoscrolling is on.
Release Notes:
- Fixed jittery scrolling when following someone else that had a bigger
viewport.
Thorsten Ball
created
030b20a
Fix scroll jitter by ignoring autoscroll events if following
Click to expand commit body
When following someone else we saw jitter because
`ScrollPositionChanged` events were battling `SelectionsChanged` events,
both of which were scrolling the viewport.
This ignores the ScrollPositionChanged if autoscrolling is on.
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Julia <julia@zed.dev>
Thorsten Ball
,
Antonio
, and
Julia
created
0db9c27
Make scripts/histogram ignore lines without frame duration
Click to expand commit body
Previously the script would choke on lines generated, for example, by
`cargo run`.
This just skips lines that don't contain `frame duration:`.
Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball
and
Antonio
created
a802bb2
Fix horizontal scroll going too far to the left (#4213)
Click to expand commit body
Previously one could scroll infinitely to the left. This clams it to 0.
Release Notes:
- Fixed horizontal scroll possibly going too far to the left.
Antonio Scandurra
created
c8c605d
Fix horizontal scroll going too far to the left
Click to expand commit body
Previously one could scroll infinitely to the left. This clams it to 0.
Co-authored-by: Antonio <antonio@zed.dev>
Fixes
* LSP servers never being shut down on worktree release
* worktrees (and LSP servers) being re-created for settings files on
every opening
Also,
* removes `async` from `workspace_configuration` to simplify the code:
we only return static configurations now
Release Notes:
- Fixed excessive LSP server creation for Zed settings files
Kirill Bulatov
created
5e0cabc
Create a special worktree for settings files
Click to expand commit body
To avoid LSP server restarts/leaks when those are being opened
co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov
and
Piotr
created
fc7458d
Trim diagnostic messages to fix rendering bug (#4210)
Click to expand commit body
Before this change a diagnostic message with a trailing newline (e.g.
`line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`.
But the content we then display in this block had 3 "lines", which
pushed the content out of the block.
This fixes the issue by trimming the newlines at the end from the
diagnostics.
Release Notes:
- Fixed rendering multi-line diagnostic errors inside of the editor.
Thorsten Ball
created
accb4f8
Cache last used layer_id for StackingOrder (#4211)
Click to expand commit body
This optimizes rendering time by saving computation of the layer_id and
comparison when inserting it into the `BTreeMaps`.

Release Notes:
- Improved rendering performance when a lot of text is being displayed.
Thorsten Ball
created
bf843e2
Cache last used layer_id for StackingOrder
Click to expand commit body
This optimizes rendering time by saving computation of the layer_id and
comparison when inserting it into the `BTreeMaps`.
Co-authored-by: Antonio <antonio@zed.dev>
Thorsten Ball
and
Antonio
created
ab8585e
Remove the `async` modifier from the `workspace_configuration` method
Kirill Bulatov
created
f8939fd
Trim diagnostic messages to fix rendering bug
Click to expand commit body
Before this change a diagnostic message with a trailing newline (e.g.
`line1\nline2\n`) would be rendered in a `Block` with `line_height: 2`.
But the content we then display in this block had 3 "lines", which
pushed the content out of the block.
This fixes the issue by trimming the newlines at the end from the
diagnostics.
Co-authored-by: Antonio <antonio@zed.dev>
I was unable to run the collab tests locally because I would run out of
file descriptors.
From some digging it turned out that tokio allocates a new file
descriptor to do work on the CurrentThread using KQUEUE.
We create a new tokio Runtime with each database connection, and these
database connections were being retained by the Client, which is
retained by the Context.
Cleaning up our leaked contexts (and an unrelated retain cycle in the
UserStore) fixes the problem (though does make me
wonder if a different approach might be preferrable).
Release Notes:
- N/A
Conrad Irwin
created
ce0833e
Fix off-by-one highlighting in hover tooltip (#4206)
Click to expand commit body
rust analyzer has a tendency to return markdown of the form:
```rust
// <-- note the leading space
blah blah blah
```
This is clearly defectuous, so we used to .trim() the output.
Unfortunately we trim after applying syntax highlighting, so that causes
the output to look goofy.
Fix this by updating the highlighting when we trim.
[[PR Description]]
Release Notes:
- Fixed a bug where syntax highlighting was off in hover tooltips
I was unable to run the collab tests locally because I would run out of
file descriptors.
From some digging it turned out that tokio allocates a new file
descriptor to do work on the CurrentThread using KQUEUE.
We create a new tokio Runtime with each database connection, and these
database connections were being retained by the Client, which is
retained by the Context.
Cleaning up our leaked contexts fixes the problem (though does make me
wonder if a different approach might be preferrable).
Conrad Irwin
created
3d5bce6
Fix clippy lints in GPUI and finish documenting GPUI modules (#4188)
a529a53
Don't allow granting write access to guests who haven't signed the CLA, if the channel requires the zed CLA (#4208)
Max Brunsfeld
created
2570808
Add requires_zed_cla column to channels table
Click to expand commit body
Don't allow granting guests write access in a call where the channel
or one of its ancestors requires the zed CLA, until that guest has
signed the Zed CLA.
Co-authored-by: Marshall <marshall@zed.dev>
Max Brunsfeld
and
Marshall
created
f2eb78b
Avoid overwriting mouse wheel scroll with selection auto-scroll (#4207)
Click to expand commit body
Release Notes:
- Fixed an issue where mouse wheel events could be ignored while
selecting text near the top or bottom of the editor with the mouse.
Julia
created
a2aa47a
Avoid overwriting mouse wheel scroll with selection auto-scroll
92c4c84
Fix the fonts panic and completions in the settings (#4205)
Click to expand commit body
* Do not add fonts' `font_family` into the font completion list, if
there's no corresponding attribute in the font data
* Remove `font_style_name` and `font_name` attribute from the completion
options, since those bring `-Italic`, `-Bold` variants that are not
family names (which we use to load the fonts, so they are useless)
Release Notes:
- Improved font family names completion in the settings
98d514f
Fix off-by-one highlighting in hover tooltip
Click to expand commit body
rust analyzer has a tendency to return markdown of the form:
```rust
// <-- note the leading space
blah blah blah
```
This is clearly defectuous, so we used to .trim() the output.
Unfortunately we trim after applying syntax highlighting, so that causes
the output to look goofy.
Fix this by updating the highlighting when we trim.
Release builds are currently failing:
https://github.com/zed-industries/zed/actions/runs/7616903969/job/20744857084
It is unclear to me why debug builds are not.
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).