5d3f561
guest promotion (#3969)
Click to expand commit body
Release Notes: - Adds the ability to promote read-only guests to read-write participants in calls
Conrad Irwin created
5d3f561
guest promotion (#3969)
Release Notes: - Adds the ability to promote read-only guests to read-write participants in calls
Conrad Irwin created
2ca4627
Fix some tests (mostly more run_until_parked's...)
Conrad Irwin created
8ceb9fd
Run migrations on development server start (#3971)
Release Notes: - N/A
Conrad Irwin created
72c022f
Ensure focus-sensitive tests have active windows
Conrad Irwin created
1bf33b4
Ensure focus_in and focus_out fire on window activation
Also: - Rename cx.on_blur to cx.on_focus_lost - Fix a bug where notify calls in focus handlers were ignored - Fix a bug where vim would get stuck in the wrong mode when switching windows
Conrad Irwin created
45baad2
Remove or fix stale todos (#3990)
The software equivalent of dusting Release Notes: -
Mikayla Maki created
e786e22
And a few more todos
Mikayla created
9ce7ef8
Remove the last of the major todos
Mikayla created
8cb291b
Take a different approach to rendering channel buttons (#3991)
This PR changes the approach we're using to render the channel buttons to use a more straightforward (and less hacky) approach. ### Motivation Even with the variety of hacks that were employed to make the current approach work, there are still a number of issues with the current solution: - Hovering in the empty space to the left of a channel doesn't correctly apply the hover background to the container for the channel buttons - Hovering to the very right of the collab panel (right on top of the drag handle) causes the channel button container to apply its hover background without applying it to the rest of the row - The buttons would still get pushed off to the right by the indent space in the channel tree, resulting in jagged indicators at small sizes Additionally, the rectangular background placed behind the channel buttons still didn't look great when it overlapped with the channel names. ### Explanation For these reasons, I decided to explore a simpler approach that addresses these issues, albeit with some tradeoffs that I think are acceptable. We now render the absolutely-positioned button container as a sibling element of the `ListItem`. This is to avoid issues with the container getting pushed around based on the contents of the `ListItem` rather than staying absolutely positioned at the end of the row. We also have gotten rid of the background for the button container, and now rely on the background of the individual `IconButton`s to occlude the channel name behind them when the two are overlapping. Here are some examples of the new UI in various configurations: #### When the channel entry is hovered <img width="270" alt="Screenshot 2024-01-09 at 6 15 24 PM" src="https://github.com/zed-industries/zed/assets/1486634/0207a129-30eb-4067-8490-3b6c9cbf75ea"> #### Overlapping with the channel name <img width="229" alt="Screenshot 2024-01-09 at 6 15 43 PM" src="https://github.com/zed-industries/zed/assets/1486634/0a67507e-45c8-4325-a71e-d416edc3a115"> #### Narrow collab panel <img width="116" alt="Screenshot 2024-01-09 at 6 16 07 PM" src="https://github.com/zed-industries/zed/assets/1486634/887ebaa3-e4d6-4497-9141-afcc8b7cd356"> ### Tradeoffs The new approach comes with the following tradeoffs that I am currently aware of: The occlusion can look a little weird when the icons are in the middle of a channel name (as opposed to fully occluding the end of the channel name): <img width="190" alt="Screenshot 2024-01-09 at 6 24 32 PM" src="https://github.com/zed-industries/zed/assets/1486634/0062b806-1b8f-47eb-af8d-f061d9829366"> Hovering one of the icons causes the icon to be hovered instead of the row: <img width="232" alt="Screenshot 2024-01-09 at 6 31 38 PM" src="https://github.com/zed-industries/zed/assets/1486634/cbcc1a45-64d2-4890-8ad6-c5a5ee961b86"> Release Notes: - Improved the way channel buttons are displayed.
Marshall Bowers created
276bfa0
Merge branch 'main' into guest-promotion
Conrad Irwin created
4da9d61
Implement live kit promotion/demotion
Conrad Irwin created
ed263a7
Resolve more todos
Mikayla created
80790d9
Fix / remove small todos
Mikayla created
684bd53
ui: Fix doc tests (#3989)
There were a ton of doc tests that weren't compiling in the `ui` crate, so this PR fixes them. Release Notes: - N/A
Marshall Bowers created
68d0b46
Remove unnecessary mutexes from livekit client types (#3984)
We had introduced these mutexes at a time when `gpui2` required app entities to be `Sync`, but they are no longer needed. Removing them now because we're trying to find out why we're sometimes getting crashes and deadlocks in livekit, and we didn't before.
Max Brunsfeld created
0daa2bf
Fix panic in set_scroll_anchor_remote (#3987)
If the remote sends us an invalid scroll position, we should not panic. Release Notes: - Fix a panic receiving scroll positions out of order
Conrad Irwin created
18e537a
Do not dismiss buffer search when any modal is present (#3988)
Release Notes: - Fixed buffer search being dismissed not after the modals are
Kirill Bulatov created
8b71b1d
Do not dismiss buffer search when any modal is present
Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
Kirill Bulatov and Piotr Osiewicz created
a579ef1
Rename `Shape` to `AvatarShape` (#3986)
This PR renames the `Shape` enum to `AvatarShape`, since it seems pretty specific to `Avatar`s. Release Notes: - N/A
Marshall Bowers created
a46947d
Fix panic in set_scroll_anchor_remote
Conrad Irwin created
e3c603f
Make RemoteTrackPublication a tuple struct again
Max Brunsfeld created
356f9fc
Store a raw Room pointer on RoomDelegate
Max Brunsfeld created
7ed3f5f
Clean up references in doc comments in `ui` and `theme` crates (#3985)
This PR cleans up a number of references in doc comments in the `ui` and `theme` crates so that `rustdoc` will link and display them correctly. Release Notes: - N/A
Marshall Bowers created
145f3f5
Remove unused API
Mikayla created
ebe2c36
Add short top-level description of a crate
Piotr Osiewicz created
447bfca
Add a test to catch keybinding bounds issue (#3966)
Add a test to catch regressions to https://github.com/zed-industries/zed/pull/3964 Thanks for the idea @ConradIrwin TODO: - [ ] Fix immediate stack overflow in test Release Notes: - N/A
Mikayla Maki created
128a8ff
Remove unnecessary mutexes from livekit client types
Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld and Conrad created
510234c
Add some Theme and UI docs (#3979)
Documents a number of items in the `theme` and `ui` crates. Release Notes: - N/A
Nate Butler created
1728c4e
Fixed test
Mikayla created
5b1894a
Take into account multiple scroll deltas within a single frame (#3982)
Release Notes: - Fixed an issue where all but the last scroll event would be dropped if there were multiple within a single frame.
Julia created
6144ee1
Docs for indent_size_for_line and co
Piotr Osiewicz created
51988f6
Document more enums
Nate Butler created
74dadd6
Clean up references in doc comments (#3983)
This PR cleans up a number of references in doc comments so that `rustdoc` will link and display them correctly. Release Notes: - N/A
Marshall Bowers created
686dce8
Document bracket pairs
Piotr Osiewicz created
463270e
Take into account multiple scroll deltas within a single frame
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
Julia and Antonio Scandurra created
c19551d
Document free functions
Nate Butler created
cb24062
Restore removed ColorScaleStep ALL that was breaking the build
Nate Butler created
e020d7c
Document ui crate traits
Nate Butler created
00c3afd
Add documentation to GPUI (#3980)
🍐d with @conrad @mikayla-maki on covering some of the surface area. Release Notes: - N/A
Nathan Sobo created
42cbd10
Even more docs
Co-authored-by: Conrad <conrad@zed.dev>
Nathan Sobo and Conrad created
b02f370
More docs
Max Brunsfeld created
46065c2
Fix unclosed delimiter
Nate Butler created
7dbe051
Add label docs
Nate Butler created
5f15138
WIP
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com>
Joseph T. Lyons and Julia created
324fd24
Initial button documentation
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nate Butler and Antonio Scandurra created
458c672
Add more API docs
Co-Authored-By: Conrad <conrad@zed.dev>
Nathan Sobo and Conrad created
7fbe0b8
Start work on language docs
Max Brunsfeld created
5359762
Document components/avatar
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nate Butler and Antonio Scandurra created
59f41ac
Add a bunch of docs
Co-Authored-By: Conrad <conrad@zed.dev> Co-Authored-By: Mikayla <mikayla@zed.dev>
Nathan Sobo , Conrad , and Mikayla created
9747c10
Document UI modules
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nate Butler and Antonio Scandurra created