ec03572
Properly detect file finder label positions in paths (#3931)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2367
Release Notes:
- Fixed file finder crashing on certain paths with multi-codepoint
characters
([#2367](https://github.com/zed-industries/community/issues/2367))
Kirill Bulatov
created
5dca1b5
Properly detect file finder label positions in paths
ee336cb
Add spaces between leave call and call status icons, and call status icons and user menu
Kirill Bulatov
created
b813451
Fix base keymap selector keyboard shortcuts (#3927)
Click to expand commit body
Release Notes:
- Fixed base keymap selector keyboard shortcuts
Kirill Bulatov
created
0d7f3ef
Fix base keymap selector keyboard shortcuts
Kirill Bulatov
created
3d1f522
Fix the alignment of the assistant (#3925)
Click to expand commit body

Release Notes:
- Fixed the alignment of the assistant headers and text
- Increased the left padding on the assistant.
436a281
Align the assistant message headers with the editable message content
Click to expand commit body
Since the message headers are buttons, we need to shift them relatively to
compensate for the fact that the background is only visible when hovered.
I'm ok with the background not being aligned so long as the unhovered text is.
Nathan Sobo
created
621c98b
Restore collab button tooltips, make screenshare item background of editor background's color (#3924)
Click to expand commit body
Release Notes:
- Restored collab button tooltips, made screenshare item background of
editor background's color
Kirill Bulatov
created
669293e
Screenshare item background is now of editor background's color
Starting work on the following tests.
* The first failure was caused by not properly dropping the references,
which is now fixed.
* The next failure is caused by a `cx.after_window_update` being changed
to `cx.on_next_frame`. This doesn't seem to work (at least in tests),
but might also explain the flaky following behavior Max and I observed
if there's a timing bug in production too.
* * When you are following someone and they move their cursor you should
receive two proto messages: UpdateBuffer to move the cursor, and
UpdateFollowers to update where you're following. It seems like this
could be made a bit less chatty/fragile, but probably out of scope for
this.
* With that worked around, there's one more failure, but I haven't
looked into it yet. (possibly caused by an incorrect fix for the cx
one).
7e810d7
Restore the ability to disable key bindings by setting them to `null` in your keymap (#3921)
Click to expand commit body
* Fix an incorrect use of `Any::type_id` that prevented the disabling of
key bindings
* Restructured the representation of disabled key bindings so that they
handle context predicates correctly. Previously, to disable key binding,
you needed to supply the exact same context predicate (e.g. `Editor &&
mode == "full"`) as the binding that you are trying to disable. Now, the
context predicates of disabled key bindings are evaluated just like any
other context predicate (with the current context) to see if they apply.
Release Notes:
- Fixed an issue where disabling key bindings didn't work. To disable a
key binding, set it to `null` in your keymap.
Max Brunsfeld
created
be98ff4
Iterate on design of channel management modal (#3923)
Click to expand commit body
This PR refines the design of the channel management modal:
#### Before
<img width="585" alt="Screenshot 2024-01-05 at 4 17 32 PM"
src="https://github.com/zed-industries/zed/assets/1486634/a6d96674-b688-4549-8fb8-0a7b2c7c88be">
#### After
<img width="589" alt="Screenshot 2024-01-05 at 4 15 20 PM"
src="https://github.com/zed-industries/zed/assets/1486634/31ae8dc1-a129-4a15-963e-9779b9b79bd9">
Release Notes:
- Improved the look of the channel management modal.
6cb8b86
Tidy up styling of connection status in the title bar (#3922)
Click to expand commit body
This PR tidies up the styling of the connection status indicators in the
title bar.
Removed some debug styles and tweaked the styling to match the rest of
the title bar overall.
Release Notes:
- Improved the connection status indicators in the title bar.
ff82fb9
Gracefully prevent submitting feedback while in a shared project (#3919)
Click to expand commit body
This PR fixes a panic that would occur when trying to submit feedback
while within a shared project.
There may be a way we want to support this in the future, but for now we
just show a toast letting the user know this is not supported:
<img width="415" alt="Screenshot 2024-01-05 at 2 46 02 PM"
src="https://github.com/zed-industries/zed/assets/1486634/d3eff4d9-90ba-4257-9857-19b1bc933cf3">
Release Notes:
- Fixed a panic when attempting to open the feedback modal while in a
shared project.
This PR removes the old typescript-based theme system, and it's related
functions.
TODO:
- [x] Create standalone repo of old theme system in case it is needed.
- https://github.com/zed-industries/zed1-styletrees
- [x] Remove `styles`
- [x] Remove licenses generating code related to `styles`
- [x] Remove docs related to old theme system
- [x] Add license generation to new theme system (#3917)
- [x] Check as best possible that all the places we were accessing
`styles` are removed or updated.
Note: For now, the JSON files in `assets/themes` will remain until we
are finished with the Zed 1 theme importer. We should be able to remove
those in the next few weeks.
Release Notes:
- N/A
Nate Butler
created
79cccdb
Use regular text color for diagnostic popovers (#3918)
Click to expand commit body
This PR updates the diagnostic popovers to use the regular editor text
color rather than one specific to the diagnostic kind.
Release Notes:
- Updated text color in diagnostic popovers.
c7c874a
Decouple theme license generation from TypeScript theme definitions (#3917)
Click to expand commit body
This PR decouples the generation of licenses for the themes we ship from
the TypeScript theme definitions.
For now, we are embedding the license information for the themes in the
`theme_importer`, and emit a combined `LICENSES` file in the `theme`
crate whenever we import themes. This is also where we check that each
theme has a valid license.
We then use this `LICENSES` file when building up the global license
file for Zed.
This decoupling is one step towards us being able to delete the old Zed1
styles.
Release Notes:
- N/A
This removes one of the path dependencies in gpui that's only really
needed by `workspace` (which can work around lack of these
implementations by itself). In theory it should also improve build
scheduling (as gpui doesn't have to wait for main dependency of sqlez -
libsqlite3 - to finish it's 25 seconds-long build in release), though in
practice I didn't notice a substantial improvement.
Moreover `sqlez` was unused by `settings` too, so that's removed
as well.
Release Notes:
- N/A
According to
https://docs.digitalocean.com/products/kubernetes/how-to/configure-load-balancers/#ssl-certificates
you can specify whether to disable automatic DNS record
creation for the certificate upon the load balancer’s creation using the
do-loadbalancer-disable-lets-encrypt-dns-records annotation. If you
specify true, we will not automatically create a DNS A record at the
apex of your domain to support the SSL certificate.
Conrad Irwin
created
94d0fe9
Fix current lsp logs menu item not shown as selected (#3916)
Click to expand commit body
Release Notes:
- Fixed current LSP logs menu item not shown as selected
Kirill Bulatov
created
12b5dbf
Fix current lsp logs menu item not shown as selected
This PR upgrades our version of `ctor` to v0.2.6.
We were previously using a fork that contained this fix:
https://github.com/mmastrac/rust-ctor/pull/295.
A new version of `ctor` has now been released with that change, so we
can switch back to the mainline version.
I scanned through the diff between versions (since we're upgrading from
effectively v0.1.20) and didn't notice anything that seemed obviously
breaking:
https://github.com/mmastrac/rust-ctor/compare/564b87f1dc13cf061ef9997ee501fa5378f35ba1...ee6b4b1c7bd3c9c1edad3b6f4d906e767767ba3d
Release Notes:
- N/A