0fd9165
Fixed channel chat notifications are not working anymore (#9827)
Click to expand commit body
This PR will fix the following issues that were introduced by the
following pull request #9557.
- Cannot create messages with a mention inside it
- Cannot invite a user
- Cannot accept an invitation
Release Notes:
- Fixed channel chat notifications are not working anymore.
Co-authored-by: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com>
Remco Smits
and
Bennet Bo Fenner
created
9604b22
Suppress error logs from `CopilotCompletionProvider` when Copilot is disabled (#9826)
Click to expand commit body
This PR fixes some noisy error logs from the `CopilotCompletionProvider`
when Copilot is disabled entirely via the settings.
I have the following in my settings file:
```json
{
"features": {
"copilot": false
},
}
```
After #9777 I started seeing my Zed logs getting filled up with messages
like this:
```
[2024-03-26T14:33:09-04:00 ERROR util] crates/copilot_ui/src/copilot_completion_provider.rs:206: copilot is disabled
```
Release Notes:
- N/A
Marshall Bowers
created
cd32ef6
Use correct file extension for Haskell suggestions (#9825)
Click to expand commit body
This PR fixes the file extension used for suggesting the Haskell
extension.
Release Notes:
- N/A
Marshall Bowers
created
b8ef970
Extract PureScript support into an extension (#9824)
Click to expand commit body
This PR extracts PureScript support into an extension and removes the
built-in PureScript support from Zed.
Release Notes:
- Removed built-in support for PureScript, in favor of making it
available as an extension. The PureScript extension will be suggested
for download when you open a `.purs` file.
Marshall Bowers
created
d77cda1
windows: Support compiling with MinGW toolchain (#9815)
Click to expand commit body
Fixes #9757: compile manifest using `embed-manifest` crate, which
supports both MSVC and MinGW
Release Notes:
- N/A
~~This is still a work in progress, but to show the public where I am
working on it~~ Ready for review
TODO:
- [x] Justify fullscreen size to display
- [x] Record and apply restored size
Release Notes:
- N/A
白山風露
created
fc5a088
Fix visual glitches in titlebar when there's an active prompt
Click to expand commit body
It looks like a fractional traffic lights position doesn't play well with Mac 12+.
Related to #7339 and #8128
Piotr Osiewicz
created
dbcff2a
Extract Prisma support into an extension (#9820)
Click to expand commit body
This PR extracts Prisma support into an extension and removes the
built-in Prisma support from Zed.
Release Notes:
- Removed built-in support for Prisma, in favor of making it available
as an extension. The Prisma extension will be suggested for download
when you open a `.prisma` file.
1d6792b
Extract Haskell support into an extension (#9814)
Click to expand commit body
This PR extracts Haskell support into an extension and removes the
built-in Haskell support from Zed.
I tested out the extension locally in a Nix shell using `nix-shell -p
ghc haskell-language-server` to confirm the language server still
operated as expected:
<img width="341" alt="Screenshot 2024-03-26 at 11 26 26 AM"
src="https://github.com/zed-industries/zed/assets/1486634/df16fd38-4046-4a45-ac9f-c2b85bffe5c0">
Release Notes:
- Removed built-in support for Haskell, in favor of making it available
as an extension. The Haskell extension will be suggested for download
when you open a `.hs` file.
Marshall Bowers
created
9d4c6c6
Do not format or fully save non-dirty buffers (#9813)
Click to expand commit body
Fixes https://github.com/zed-industries/zed/issues/9475
Release Notes:
- Start skipping formatting and actual FS saving for non-dirty buffers
([9475](https://github.com/zed-industries/zed/issues/9475))
This pull request introduces a new `InlineCompletionProvider` trait,
which enables making `Editor` copilot-agnostic and lets us push all the
copilot functionality into the `copilot_ui` module. Long-term, I would
like to merge `copilot` and `copilot_ui`, but right now `project`
depends on `copilot`, which makes this impossible.
The reason for adding this new trait is so that we can experiment with
other inline completion providers and swap them at runtime using config
settings.
Please, note also that we renamed some of the existing copilot actions
to be more agnostic (see release notes below). We still kept the old
actions bound for backwards-compatibility, but we should probably remove
them at some later version.
Also, as a drive-by, we added new methods to the `Global` trait that let
you read or mutate a global directly, e.g.:
```rs
MyGlobal::update(cx, |global, cx| {
});
```
Release Notes:
- Renamed the `copilot::Suggest` action to
`editor::ShowInlineCompletion`
- Renamed the `copilot::NextSuggestion` action to
`editor::NextInlineCompletion`
- Renamed the `copilot::PreviousSuggestion` action to
`editor::PreviousInlineCompletion`
- Renamed the `editor::AcceptPartialCopilotSuggestion` action to
`editor::AcceptPartialInlineCompletion`
---------
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Kyle <kylek@zed.dev>
Co-authored-by: Kyle Kelley <rgbkrk@gmail.com>
Antonio Scandurra
,
Nathan
,
Kyle
, and
Kyle Kelley
created
Fixes https://github.com/zed-industries/zed/issues/9723
Move the `occlude` in the places where they are needed.
Release Notes:
- Fixed right click in the project panel's empty region
([9723](https://github.com/zed-industries/zed/issues/9723))
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
Kirill Bulatov
and
Antonio Scandurra
created
db9221a
markdown preview: Handle line breaks in between task list items correctly (#9795)
Click to expand commit body
Closes #9783
Release Notes:
- Fixed task list rendering when there was a line break between two list
items ([#9783](https://github.com/zed-industries/zed/issues/9783))
Bennet Bo Fenner
created
157fb98
Add ability to specify binary path/args for `gopls` (#9803)
Click to expand commit body
This uses the language server settings added in #9293 to allow users to
specify the binary path and arguments with which to start up `gopls`.
Example user settings for `gopls`:
```json
{
"lsp": {
"gopls": {
"binary": {
"path": "/Users/thorstenball/tmp/gopls",
"arguments": ["-debug=0.0.0.0:8080"]
},
}
}
}
```
Constraints:
* Right now this only allows ABSOLUTE paths.
Release Notes:
- Added ability to specify `gopls` binary `path` (must be absolute) and
`arguments` in user settings. Example: `{"lsp": {"gopls": {"binary":
{"path": "/my/abs/path/gopls", "arguments": ["-debug=0.0.0.0:8080"]
}}}}`
Thorsten Ball
created
b0409dd
Consolidate more extension API structs that were duplicated btwn client and server (#9797)
Click to expand commit body
Release Notes:
- N/A
Max Brunsfeld
created
5e7fcc0
Remove old extension dir when upgrading (#9800)
Click to expand commit body
Fixes #9799
Release Notes:
- Fixed a bug where upgrading an extension did not work correctly if the
extension had switched from using an old extension schema with
`extension.json` to the new schema with `extension.toml`.
Max Brunsfeld
created
5adc51f
Add telemetry events for loading extensions (#9793)
Click to expand commit body
* Store extensions versions' wasm API version in the database
* Share a common struct for extension API responses between collab and
client
* Add wasm API version and schema version to extension API responses
Release Notes:
- N/A
Co-authored-by: Marshall <marshall@zed.dev>
Max Brunsfeld
and
Marshall
created
9b62e46
windows: Add extension builder support (#9791)
Click to expand commit body
Release Notes:
- N/A
Ezekiel Warren
created
1b4c82d
Fix next/prev shortcuts handling in the File Finder (#9785)
Click to expand commit body
This PR fixes the unexpected File Finder behaviour described in
https://github.com/zed-industries/zed/pull/8782#issuecomment-2018551041
Any change of the modifier keys except for the release of the initial
modifier keys now prevents opening the selected file.
Release Notes:
- N/A
Andrew Lygin
created
bdea804
Restore the hitbox of the excerpt header (#9790)
Click to expand commit body
In https://github.com/zed-industries/zed/pull/9722, the
jump-to-excerpt-source buttons where shrunk too far.
Release Notes:
- N/A
There is also `.C` and `.H` (capital), but I can't imagine they are very
popular and I'd be worried clashing with C.
Release Notes:
- Added more path suffixes recognized as C++
This copies the logic from #9608 to the X11 client.
Fixes #9707.
Release Notes:
- N/A
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Paul
and
Mikayla Maki
created
030e299
Fix key repeat after releasing a different key on Wayland (#9768)
Click to expand commit body
Quick fix that fixes key repeat not working when releasing a different
key than the current one being held
Don't really know much rust yet, so unsure this is the best way to
handle this, but this does seem like a good starting point to get at
least a tad familiar with it
Release Notes:
- N/A
RoblKyogre
created
6231df9
Windows: fix initial active status (#9694)
Click to expand commit body
Separate from #9451
On Windows, a new window may already active immediate after creation.
Release Notes:
- N/A
---------
Co-authored-by: Mikayla <mikayla@zed.dev>
mouse scroll wasn't working unless the window was maximized or in the
top left corner because the Windows wheel events give screen coordinates
Release Notes:
- N/A
Ezekiel Warren
created
2646ed0
linux: Implement `restart` and `app_path` (#9681)
Click to expand commit body
Added `restart` and `app_path` method for linux platform which was
marked as `//todo(linux)`
Release Notes:
- N/A
Raunak Raj
created
7bba9da
Fix dependency install script on RHEL derivatives (#9684)
Click to expand commit body
Added a check to `script/linux` so the script does not try to enable CSB
or add EPEL if the user is on Fedora, which does not need these steps.
The script now runs nicely on Fedora! :)
Release Notes:
- N/A
Moved `SetCursor` calls to `WM_SETCURSOR`, which occurs when OS is
requires set cursor.
Release Notes:
- N/A
白山風露
created
053d05f
Bump Tree-sitter for inclusion of strncat in wasm c stdlib
Click to expand commit body
Co-authored-by: Marshall <marshall@zed.dev>
Max Brunsfeld
and
Marshall
created
0981c97
extension_cli: Clear out existing manifest collections for old `extension.json` (#9780)
Click to expand commit body
This PR fixes an issue in the extension CLI when building extensions
using the old manifest schema (`extension.json`).
If there were values provided for the `languages`, `grammars`, or
`themes` collections, these could interfere with the packaging process.
We aren't expecting these fields to be set in the source
`extension.json` (just in the generated one), so we can clear them out
when building up the manifest.
Release Notes:
- N/A
Co-authored-by: Max <max@zed.dev>
Marshall Bowers
and
Max
created
eec8660
Use `.is_some_and()` instead of `.is_some() && .unwrap()` (#9704)
Click to expand commit body
That's nicer & more readable.
(I just noticed that this looks weird while trying to understand why zed
changes my cursor, so decided to make a quick fix (btw the issue with
the cursor is that zed always loads cursor named "default" on wayland))
Release Notes:
- N/A
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
<img width="209" alt="image"
src="https://github.com/zed-industries/zed/assets/38318044/0dcc4d0b-db9e-4eba-aa36-5c35f185e7e3">
Release Notes:
- Fixed alignment of items in the title bar
([#9709](https://github.com/zed-industries/zed/issues/9709)).
Reverts zed-industries/zed#9741
/cc @niklaswimmer it looks like that PR change broke our rendering of
avatars (as @bennetbo found out) - they have a blue-ish tint now, which
I suppose might have to do with change between BGRA and RGBA. I'm gonna
revert it for now, let's reopen it though.

Release Notes:
- N/A
This PR fixes #9567
Release Notes:
- Changed default indentation for Prisma files to 2 spaces
([#9567](https://github.com/zed-industries/zed/issues/9567)).
Ko
created
7f9355e
windows: update text system to new cosmic version
Click to expand commit body
The same changes have been used on linux here 500350403124a8faffc67a5162bc7745a1bac6af
and here 34832d49b09071846ff6f55f8ca1df019980a1df.
Signed-off-by: Niklas Wimmer <mail@nwimmer.me>
The latest update to resvg bumped some transitive dependencies
which lead to duplicates. The update to the image dependency
unifies most of their versions again.
Most notably, gif and kurbo are still duplicated, which is best fixed
downstream however.
Signed-off-by: Niklas Wimmer <mail@nwimmer.me>
Niklas Wimmer
created
007acc4
gpui: Update cosmic-text and resvg dependency
Click to expand commit body
This unifies the rustybuzz dependency to the same version.
Signed-off-by: Niklas Wimmer <mail@nwimmer.me>
This removes bindgen and cbindgen from the dependency graph on non-macos
systems, improving compile times on those systems.
Signed-off-by: Niklas Wimmer <mail@nwimmer.me>
The ashpd update removes the dependency on an older zbus version which
decreases compile times.
Signed-off-by: Niklas Wimmer <mail@nwimmer.me>
Niklas Wimmer
created
4785520
Support newline and tab literals in regex search-and-replace operations (#9609)
Click to expand commit body
Closes #7645
Release Notes:
- Added support for inserting newlines (`\n`) and tabs (`\t`) in editor
Regex search replacements
([#7645](https://github.com/zed-industries/zed/issues/7645)).
I found that there may be some minor problems here, in editor.edit may
be more dependent on the order of operations, if the same set of
operations, different execution orders may lead to some different
results, so maybe we need to use BTreeSet instead of HashSet, because
HashSet may not be able to ensure that the same set of data order is
consistent, but maybe my worries are too much
Release notes:
- N/A
Hans
created
e77d313
markdown preview: Improve task list visuals (#9695)
Click to expand commit body
Instead of using some arbitrary unicode characters to render a task as
completed/not completed, I feel that using an actual checkbox from the
components crate makes it look more polished.
Before:

After:
<img width="883" alt="image"
src="https://github.com/zed-industries/zed/assets/53836821/f63d56c3-bfbb-41c8-b150-8ebf973f75e2">
Release Notes:
- Improved visuals of task lists inside the markdown preview
Bennet Bo Fenner
created
5181d3f
Workspace configuration for elixir-ls LSP (#9330)
Click to expand commit body
This allows the workspace configuration settings to be passed to the
elixir-ls LSP via lsp settings.
This following example settings disable dialyzer in the LSP:
```
"lsp": {
"elixir-ls": {
"settings": {
"dialyzerEnabled": false
}
}
}
```
It follows the same pattern used in
[#8568](https://github.com/zed-industries/zed/pull/8568) and resolves
[#4260](https://github.com/zed-industries/zed/issues/4260).
Zed's language server logs show the settings are being sent to the
language server:
```
Received client configuration via workspace/configuration
%{"dialyzerEnabled" => false}
Registering for workspace/didChangeConfiguration notifications
Starting build with MIX_ENV: test MIX_TARGET: host
client/registerCapability succeeded
Registering for workspace/didChangeWatchedFiles notifications
client/registerCapability succeeded
Received workspace/didChangeConfiguration
Received client configuration via workspace/didChangeConfiguration
%{"dialyzerEnabled" => false}
```
Release Notes:
- Added workspace configuration settings support for elixir-ls language
server. Those can now be configured by setting `{"lsp": {"elixir-ls": {
"settings: { "your-settings-here": "here"} } }` in Zed settings.
[#4260](https://github.com/zed-industries/zed/issues/4260).
Richard Taylor
created
6d78737
markdown preview: Insert missing line break on hard break (#9687)
Click to expand commit body
Closes #8990
For this input
```
Test \
Test
```
pulldown_cmark reports
```
Start(Paragraph)
Text(Borrowed("Test "))
HardBreak
Text(Borrowed("Test"))
End(Paragraph)
```
Previously `Event::HardBreak` just marked the paragraph block as
completed and ignored all the remaining text inside the paragraph.
Before:
See https://github.com/zed-industries/zed/issues/8990#issue-2173197637
After:

Release Notes:
- Fixed markdown preview not handling hard breaks (e.g. `\`) correctly
([#8990](https://github.com/zed-industries/zed/issues/8990)).