6237e5e
Stop sending hangs to slack for a bit (#11933)
Click to expand commit body
Release Notes: - N/A
Conrad Irwin created
6237e5e
Stop sending hangs to slack for a bit (#11933)
Release Notes: - N/A
Conrad Irwin created
44105e1
Upload panics via collab instead of zed.dev (#11932)
Release Notes: - N/A
Conrad Irwin created
decfbc6
Disallow multiple save modals for the same pane item (#11931)
Fixes https://github.com/zed-industries/zed/issues/10192 Release Notes: - Fixed multiple save modals appearing for the same file being closed ([10192](https://github.com/zed-industries/zed/issues/10192))
Kirill Bulatov created
6513886
Don't scale context menus in editors with buffer font size (#11930)
With the changes in #11817, context menus within editors would get scaled by the `buffer_font_size` instead of the `ui_font_size`. This seems incorrect, as it results in context menus being sized inconsistently depending on what context they originate from. This PR makes it so that all context menus scale based on the `ui_font_size`. ### Before <img width="1474" alt="Screenshot 2024-05-16 at 2 43 19 PM" src="https://github.com/zed-industries/zed/assets/1486634/a5be8113-ae24-44ad-a2e9-61105e1fcc9e"> ### After <img width="1095" alt="Screenshot 2024-05-16 at 2 43 01 PM" src="https://github.com/zed-industries/zed/assets/1486634/3a8d51cf-fc91-4743-8f44-78344028e447"> Release Notes: - Changed context menus in editors to no longer scale with `buffer_font_size`.
Marshall Bowers created
53815af
Fix small markdown typo in Windows docs (#11888)
Fixed a small issue in the windows docs where a note wasn't displaying correctly Release Notes: - N/A
Justy created
5596a34
Wayland: Implement text_input_v3 and xkb compose (#11712)
Release Notes:
- N/A
Fixes #9207
Known Issues:
- [ ] ~~After launching Zed and immediately trying to change input
method, the input panel will appear at Point{0, 0}~~
- [ ] ~~`ime_handle_preedit` should not trigger `write_to_primary`~~
Move to other PR
- [ ] ~~Cursor is visually stuck at the end.~~ Move to other PR
Currently tested with KDE & fcitx5.
Fernando Tagawa created
fdadbc7
Add `WithRemSize` element (#11928)
This PR adds a new `WithRemSize` element to the `ui` crate. This element can be used to create an element tree that has a different rem size than the base window. `WithRemSize` can be nested, allowing for subtrees that have a different rem size than their parent and their children. <img width="912" alt="Screenshot 2024-05-16 at 2 25 28 PM" src="https://github.com/zed-industries/zed/assets/1486634/f599cd9f-c101-496b-93e8-06e570fbf74f"> Release Notes: - N/A
Marshall Bowers created
13bbaf1
Use `UpdateGlobal` accessors in more places (#11925)
This PR updates a number of instances that were previously using `cx.update_global` to use `UpdateGlobal::update_global` instead. Release Notes: - N/A
Marshall Bowers created
c1e291b
gpui: Improve `Global` ergonomics (#11923)
This PR adds some ergonomic improvements when working with GPUI `Global`s. Two new traits have been added—`ReadGlobal` and `UpdateGlobal`—that provide associated functions on any type that implements `Global` for accessing and updating the global without needing to call the methods on the `cx` directly (which generally involves qualifying the type). I looked into adding `ObserveGlobal` as well, but this seems a bit trickier to implement as the signatures of `cx.observe_global` vary slightly between the different contexts. Release Notes: - N/A
Marshall Bowers created
1b26160
Add basic proxy settings (#11852)
Adding `proxy` keyword to configure proxy while using zed. After setting the proxy, restart Zed to acctually use the proxy. Example setting: ```rust "proxy" = "socks5://localhost:10808" "proxy" = "http://127.0.0.1:10809" ``` Closes #9424, closes #9422, closes #8650, closes #5032, closes #6701, closes #11890 Release Notes: - Added settings to configure proxy in Zed --------- Co-authored-by: Jason Lee <huacnlee@gmail.com>
张小白 and Jason Lee created
90b631f
tailwind: Allow configuring custom tailwind server build (#11921)
This adds the ability to configure the `tailwindcss-language-server`
integration to use a custom build of the server.
Example configuration in Zed `settings.json`:
```json
{
"lsp": {
"tailwindcss-language-server": {
"binary": {
"arguments": [
"/Users/username/tailwindcss-intellisense/packages/tailwindcss-language-server/bin/tailwindcss-language-server",
"--stdio"
]
}
}
}
}
```
This will cause Zed to use its own Node version and run it with the
given arguments.
**Note**: you need to provide `--stdio` as the second argument!
It's also possible to use a custom Node binary:
```json
{
"lsp": {
"tailwindcss-language-server": {
"binary": {
"path": "/Users/username/bin/my-node",
"arguments": [
"/Users/username/tailwindcss-intellisense/packages/tailwindcss-language-server/bin/tailwindcss-language-server",
"--stdio"
]
}
}
}
}
```
This is *super handy* when debugging the language server.
Release Notes:
- Added ability to configure own build of `tailwindcss-language-server`
in Zed settings. Example:
`{"lsp":{"tailwindcss-language-server":{"binary":{"arguments":["/absolute/path/to/tailwindcss-language-server/bin/tailwindcss-language-server",
"--stdio" ]}}}}`
Thorsten Ball created
a414b16
python: Add highlighting to variables (#11851)
Krzysztof Witkowski created
9c02239
chat: Only autocomplete active people (#11892)
Release Notes: - chat: Updated name autocompletion to only consider active users --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Conrad Irwin and Marshall Bowers created
178ffab
theme: Properly merge `SyntaxTheme` styles to allow for partial overrides (#11911)
This PR improves the merging behavior for the `SyntaxTheme` such that user-provided values get merged into the base theme. This makes it possible to override individual styles without clobbering the unspecified styles in the base theme. Release Notes: - Improved merging of `syntax` styles in the theme.
Marshall Bowers created
4ba57d7
Make `SyntaxTheme::new_test` only available in tests (#11909)
This PR addresses a TODO comment by making `SyntaxTheme::new_test` only available in tests. We needed to make it available when the `test-support` feature was enabled for it to be used in tests outside of the `theme` crate. Release Notes: - N/A
Marshall Bowers created
f2e7c63
editor: Add Cut, Copy, and Paste actions to the context menu (#11878)
Hi, I saw someone on Twitter mentioned that missing Cut, Copy and Paste actions in the context menu in the editor block them from using Zed. It turns out that resolving this issue is simply a matter of adding these actions to the mouse context menu. To keep items in the context menu grouped, I placed them at the top of the menu with a separator at the end. Let me know if that's OK. Thanks! Here is the screenshot:  Release Notes: - Added "Cut", "Copy", and "Paste" actions to the context menu ([#4280](https://github.com/zed-industries/zed/issues/4280)).
Vitaly Slobodin created
8c681d0
lsp: Use itemDefaults if sent along with completion items (#11902)
This fixes #10532 by properly making use of `itemDefaults.data` when that is sent along next to completion `items`. With this line here we tell the language server that we support `data` in `itemDefaults`, but we actually never checked for it and never used it: https://github.com/zed-industries/zed/blob/a0d7ec9f8e70799163313767b5a8bc34d9e4aa1b/crates/lsp/src/lsp.rs#L653 In the case of `tailwindcss-language-server` that means that most of the items it returns (more than 10k items!) were missing the `data` attribute, since the language server thought it can send it along in the `itemDefaults` (because we advertised our capability to use it.) When we then did a `completionItem/resolve`, we would not send a `data` attribute along, which lead to an error on the `tailwindcss-language-server` side and thus no documentation. This PR also adds support for the other `itemDefaults` that could be sent along and that we say we support: https://github.com/zed-industries/zed/blob/a0d7ec9f8e70799163313767b5a8bc34d9e4aa1b/crates/lsp/src/lsp.rs#L650-L653 `editRange` we handle separately, so this PR only adds the other 3. Release Notes: - Fixed documentation not showing up for completion items coming from `tailwindcss-language-server`. ([#10532](https://github.com/zed-industries/zed/issues/10532)). Demo: https://github.com/zed-industries/zed/assets/1185253/bc5ea0b3-7d83-499f-a908-b0d2a1db8a41
Thorsten Ball created
9969d6c
Fix: Missing token count for GPT-4o model. (bumps tiktoken-rs to v0.5.9) (#11893)
Fix: this makes sure we have token counts for the new GPT-4o model. See: https://github.com/zurawiki/tiktoken-rs/releases/tag/v0.5.9 Release Notes: - Fix: Token count was missing for the new GPT-4o model. (I believe this should go in a 0.136.x release)
Toon Willems created
8c8c176
docs: Fix quote in default.json (#11900)
Release Notes: - N/A
Jason Lee created
58919e9
eslint: Change default configuration to fix errors (#11896)
Without this, we'd get constant errors when typing something with ESLint
enabled:
[2024-05-16T10:32:30+02:00 WARN project] Generic lsp request to node
failed: Request textDocument/codeAction failed with message: Cannot read
properties of undefined (reading 'disableRuleComment')
[2024-05-16T10:32:30+02:00 ERROR util]
crates/project/src/project.rs:7023: Request textDocument/codeAction
failed with message: Cannot read properties of undefined (reading
'disableRuleComment')
[2024-05-16T10:32:31+02:00 WARN project] Generic lsp request to node
failed: Request textDocument/codeAction failed with message: Cannot read
properties of undefined (reading 'disableRuleComment')
[2024-05-16T10:32:31+02:00 ERROR util]
crates/project/src/project.rs:7023: Request textDocument/codeAction
failed with message: Cannot read properties of undefined (reading
'disableRuleComment')
This is fixed by changing the default settings for ESLint language
server to have those fields.
I don't think we need to make these configurable yet. These are defaults
that multiple other plugins also use:
- vscode-eslint:
https://sourcegraph.com/github.com/microsoft/vscode-eslint@4d9fc40e71c403d359beaccdd4a6f8d027031513/-/blob/client/src/client.ts?L702-703
- nvim-lspconfig:
https://sourcegraph.com/github.com/neovim/nvim-lspconfig@a27179f56c6f98a4cdcc79ee2971b514815a4940/-/blob/lua/lspconfig/server_configurations/eslint.lua?L94-101
- coc-eslitn:
https://sourcegraph.com/github.com/neoclide/coc-eslint@70eb10d294e068757743f9b580c724e92c5b977d/-/blob/src/index.ts?L698:17-698:35
Release Notes:
- Changed the default ESLint configuration to include the following in
order to silence warnings/errors: `{"codeAction": {
"disableRuleComment": { "enable": true, "location": "separateLine", },
"showDocumentation": { "enable": true } }}`
Thorsten Ball created
a0d7ec9
Fix repeatedly docking project panel (#11884)
Close: #11808 , #9688 Release Notes: - N/A
CharlesChen0823 created
ba8aba4
hotfix for collab crashes (#11885)
Release Notes: - N/A
Conrad Irwin created
66e8739
assistant: Factor `RecentBuffersContext` logic out of `AssistantPanel` (#11876)
This PR factors some more code related to the `RecentBuffersContext` out of the `AssistantPanel` and into the corresponding module. We're trying to strike a balance between keeping this code easy to evolve as we work on the Assistant, while also having some semblance of separation/structure. This also adds the missing functionality of updating the remaining token count when the `CurrentProjectContext` is enabled/disabled. Release Notes: - N/A --------- Co-authored-by: Max <max@zed.dev>
Marshall Bowers and Max created
cb430fc
Autodetect parser name with prettier by default (#11558)
Closes https://github.com/zed-industries/zed/issues/11517 * Removes forced prettier parser name for languages, making `auto` command to run prettier on every file by default. * Moves prettier configs away from plugin language declarations into language settings Release Notes: - N/A
Kirill Bulatov created
52c70c1
emmet: release 0.0.3 (#11873)
Includes: #10779 Release Notes: - N/A
Piotr Osiewicz created
1651cdf
ruby: Use two spaces per indentation level (#11869)
Hello, this pull request changes the indentation level for Ruby language from 2 spaces to the most used setting in the Ruby world: 2 spaces per indentation level. This setting is mentioned in the [Ruby style guide from the Rubocop (Ruby linter and formatter) team](https://rubystyle.guide/#spaces-indentation) and/or in another popular Rubocop configuration tool - [`standardrb`](https://github.com/standardrb/standard/blob/main/config/base.yml#L233) Thanks! Release Notes: - N/A
Vitaly Slobodin created
a1e5f6b
windows: Use `DwmFlush()` to trigger vsync event (#11731)
Currently , on Windows 10, we used a `Timer` to trigger the vsync event, but the `Timer`'s time precision is only about 15ms, which means a maximum of 60FPS. This PR introduces a new function to allow for higher frame rates on Windows 10. And after reading the codes, I found that zed triggers a draw after handling mouse or keyboard events, so we don't need to call draw again when we handle `WM_*` messages. Therefore, I removed the `invalidate_client_area` function. Release Notes: - N/A
张小白 created
4ae3396
Make primary clipboard Linux only (#11843)
I guess only Linux supports the primary clipboard. Release Notes: - N/A
张小白 created
1c62839
Add missing linux dependencies for compiling openssl on Fedora (#11857)
Release Notes: - N/A
yodatak created
b7cf304
Remove 2 removal (#11867)
Release Notes: - N/A
Conrad Irwin created
247825b
Deploy install.sh to cloudflare (#11866)
Release Notes: - N/A
Conrad Irwin created
f7c5d70
macOS: Support all `OpenType` font features (#11611)
This PR brings support for all `OpenType` font features to `macOS(v10.10+)`. Now, both `Windows`(with #10756 ) and `macOS` support all font features. Due to my limited familiarity with the APIs on macOS, I believe I have made sure to call `CFRelease` on all variables where it should be called. Close #11486 , and I think the official website's [documentation](https://zed.dev/docs/configuring-zed) can be updated after merging this PR. > Zed supports a subset of OpenType features that can be enabled or disabled for a given buffer or terminal font. The following OpenType features can be enabled or disabled too: calt, case, cpsp, frac, liga, onum, ordn, pnum, ss01, ss02, ss03, ss04, ss05, ss06, ss07, ss08, ss09, ss10, ss11, ss12, ss13, ss14, ss15, ss16, ss17, ss18, ss19, ss20, subs, sups, swsh, titl, tnum, zero. https://github.com/zed-industries/zed/assets/14981363/44e503f9-1496-4746-bc7d-20878c6f8a93 Release Notes: - Added support for **all** `OpenType` font features to macOS.
张小白 created
f47bd32
v0.137.x dev
Joseph T. Lyons created
c3c4e37
Do not select target range going to definition (#11691)
Release Notes: -Fixed #11347 , do not select target range going to definition. Just place the cursor at the start of target range.
Congyu created
d3dfa91
Fix aside affecting parent popover height (#11859)
Release Notes: - Fixed the size of the completions menu changing based on the size of the aside ([#11722](https://github.com/zed-industries/zed/issues/11722)). https://github.com/zed-industries/zed/assets/30776250/c67e6fef-20f2-4dc5-92b3-09bb73f874a7 https://github.com/zed-industries/zed/assets/30776250/7467b8ee-6e66-42d7-a8cc-2df11df58c5e --------- Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
loczek and Marshall Bowers created
4ff1ee1
tasks: minor fixes to docs (#11862)
Release Notes: - N/A
Piotr Osiewicz created
1b9014b
tailwind: Allow Tailwind LS to be used in Scala (#11858)
This fixes the issue mentioned here:
https://github.com/zed-industries/zed/issues/5830#issuecomment-2111947083
In order for other languages to work, we need to pass the following
settings along to the Tailwind language server.
With the following Zed settings, it then also works for Scala:
```json
{
"languages": {
"Scala": {
"language_servers": ["tailwindcss-language-server"]
},
},
"lsp": {
"tailwindcss-language-server": {
"settings": {
"includeLanguages": {
"scala": "html"
},
"experimental": {
"classRegex": ["[cls|className]\\s\\:\\=\\s\"([^\"]*)"]
}
}
}
}
}
```
Release Notes:
- Added ability to configure settings for `tailwindcss-language-server`,
namely the `includeLanguages` and `experimental` objects.
**NOTE**: I have only tested that the language server boots up for Scala
files and that the settings are forwarded correctly. I don't have a
Scala+Tailwind project with which to test that the actual completions
also work.
cc @nguyenyou
Thorsten Ball created
f42f443
Remove stray `println!` (#11855)
This PR removes a stray `println!` left over from #11844. Release Notes: - N/A
Marshall Bowers created
a59a388
tasks: Wire through click handlers in new tasks modal (#11854)
:facepalm: Spotted by @SomeoneToIgnore Release Notes: - N/A
Piotr Osiewicz created
43d79af
metal renderer: Increase instance buffer size dynamically (#11849)
Previously, we had an instance buffer pool that could only allocate buffers with a fixed size (hardcoded to 2mb). This caused certain scenes to render partially, e.g. when showing tens of thousands of glyphs on a big screen. With this commit, when `MetalRenderer` detects that a scene would be too large to render using the current instance buffer size, it will: - Clear the existing instance buffers - Allocate new instance buffers that are twice as large - Retry rendering the scene that failed with the newly-allocated buffers during the same frame. This fixes #11615. Release Notes: - Fixed rendering issues that could arise when having large amounts of text displayed on a large display. Fixed by dynamically increasing the size of the buffers used on the GPU. ([#11615](https://github.com/zed-industries/zed/issues/11615)). Before: https://github.com/zed-industries/zed/assets/1185253/464463be-b61c-4149-a417-01701699decb After: https://github.com/zed-industries/zed/assets/1185253/4feacf5a-d862-4a6b-90b8-317ac74e9851 Co-authored-by: Antonio <me@as-cii.com>
Thorsten Ball and Antonio created
26ffdaf
tasks: Use unique id for run indicator (#11846)
This fixes a small visual issue with the run indicator. As all run indicators use the same element id they all show up as pressed when clicking on a single button. We can safely use a combination of "run_indicator" and the actual row as the element id, as there can only ever be one run indicator per line. Before: <img width="552" alt="Screenshot 2024-05-15 at 12 24 08" src="https://github.com/zed-industries/zed/assets/53836821/18779f1a-0984-488f-83fd-4a6a561f223e"> After: <img width="633" alt="image" src="https://github.com/zed-industries/zed/assets/53836821/07ea26b5-06ad-4955-8250-d96d4704220c"> Release Notes: - Fixed an issue where all run buttons would show up as pressed when clicking on a single run button
Bennet Bo Fenner created
2666434
rust: reduce false positives in runnables query (#11845)
We were marking `#[cfg(test)]`ed function as a test, which is wrong. Also allow for other attribute_items (such as #[should_panic]) between test attribute and a function item. Release Notes: - N/A
Piotr Osiewicz created
8bc41e1
Use editor's current font size to scale UI elements (#11844)
This is a follow-up to #11817 and fixes the case where the font size has been changed with `cmd +/-` and not through the settings. It now works with both: when the font size is adjusted in the settings and when changing it via shortcuts. Release Notes: - N/A Demo: https://github.com/zed-industries/zed/assets/1185253/2e539bd3-f5cc-4aae-9f04-9ae014187959
Thorsten Ball created
8629a07
Tighten up KeyBinding (#11839)
After #11795, the context menu was looking a little ridiculous on Mac in vim mode (and the command palette has for a while). <img width="258" alt="Screenshot 2024-05-14 at 20 35 50" src="https://github.com/zed-industries/zed/assets/94272/cb0ec8b9-4da6-4ab4-9eec-c60d62f79eff"> <img width="581" alt="Screenshot 2024-05-14 at 20 56 28" src="https://github.com/zed-industries/zed/assets/94272/d8fec440-17cc-4c20-80d9-c1d7f2f18315"> A future change would be to have a platform style for vim keybindings so we can render `g A`, but for now this just removes a bunch of (to my eyes at least) unnecessary space: <img width="576" alt="Screenshot 2024-05-14 at 21 01 55" src="https://github.com/zed-industries/zed/assets/94272/a39f4123-dc3b-4bb5-bb8d-5de6b37552e7"> cc @iamnbutler Release Notes: - N/A
Conrad Irwin created
3cbac27
Show buffer_search on vim::MoveToNextMatch (#11836)
This changes the vim::MoveToNextMatch event callback to open the buffer_search toolbar. This fixes an issue where highlights would appear which were only cancellable by opening then closing the toolbar. Release Notes: - the buffer search toolbar now opens on vim::MoveToNextMatch fixing the issue where highlights were not cancellable --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Gus and Conrad Irwin created
1a358e2
cleanup (#11835)
cleanup unneed code. Release Notes: - N/A
CharlesChen0823 created
ba26acc
blade: Fix display of straight underlines (#11818)
Fixes: #11715 (also apply alpha of the color to wavy ones while we're at it) Release Notes: - Fixed display of straight underlines when using the blade renderer (#11715)
jansol created
edadc6f
Fix bug with keymaps flickering in mouse menu (#11795)
Fixes a bug where Vim bindings would flash in the mouse context menu and then be replaced by the default keybindings. Also fixes those bindings not being usable while the mouse context menu was open. Release Notes: - Fixed bug where Vim bindings were not available when mouse context menu was open --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Gus and Conrad Irwin created
3da625e
astro: Bump to v0.0.2 (#11834)
This PR bumps the Astro extension to v0.0.2. Changes: - #11830 Release Notes: - N/A
Marshall Bowers created
586f708
ruby: Bump to v0.0.3 (#11833)
This PR bumps the Ruby extension to v0.0.3. Changes: - #11825 Release Notes: - N/A
Marshall Bowers created