Commit log

e1f4dfc Refine inline transformation UX (#12939)

Click to expand commit body
https://github.com/zed-industries/zed/assets/482957/1790e32e-1f59-4831-8a4c-722cf441e7e9



Release Notes:

- N/A

---------

Co-authored-by: Richard <richard@zed.dev>
Co-authored-by: Nathan <nathan@zed.dev>

Antonio Scandurra , Richard , and Nathan created

9e3c5f3 Docs to help people find their way back (#12958)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

f780504 zed.desktop.in: Don't hardcode executable name due to binary conflicts (#12951)

Click to expand commit body
> * There are a couple of other `zed` binaries that may be present on
linux systems
    ([1](https://openzfs.github.io/openzfs-docs/man/v2.2/8/zed.8.html),
[2](https://zed.brimdata.io/docs/commands/zed)). If you want to rename
our CLI
binary because of these issues, we suggest `zedit`, `zeditor`, or
`zed-cli`.

Due to aformentioned issue don't hardcode the executable name in the
.desktop file so envsubst can change it in accordance with the
distributor's requirement.

Resolves #12290.

Release Notes:

- N/A

Joey Riches created

76b0120 Reveal the selected item when cycling a picker's selection (#12950)

Click to expand commit body
Release Notes:

- Fixed a bug where the selected tab was not always shown when cycling
between tabs with `ctrl-tab`.

Max Brunsfeld created

0ac9af9 assistant: Add MVP for `/rustdoc` using indexed docs (#12952)

Click to expand commit body
This PR adds an MVP of retrieving docs using the `/rustdoc` command from
an indexed set of docs.

To try this out:

1. Build local docs using `cargo doc`
2. Index the docs for the crate you want to search using `/rustdoc
--index <CRATE_NAME>`
    - Note: This may take a while, depending on the size of the crate
3. Search for docs using `/rustdoc my_crate::path::to::item`
    - You should get completions for the available items

Here are some screenshots of it in action:

<img width="640" alt="Screenshot 2024-06-12 at 6 19 20 PM"
src="https://github.com/zed-industries/zed/assets/1486634/6c49bec9-d084-4dcb-a92c-1b4c557ee9ce">

<img width="636" alt="Screenshot 2024-06-12 at 6 52 56 PM"
src="https://github.com/zed-industries/zed/assets/1486634/636a651c-7d02-48dc-b05c-931f33c49f9c">

Release Notes:

- N/A

Marshall Bowers created

ec08694 Use clang+mold on linux (#12944)

Click to expand commit body
Takes a clean build on my machine from 222s to 185s

Release Notes:

- N/A

Conrad Irwin created

8451dba Introduce an outline panel (#12637)

Click to expand commit body
Adds a new panel: `OutlinePanel` which looks very close to project
panel:

<img width="256" alt="Screenshot 2024-06-10 at 23 19 05"
src="https://github.com/zed-industries/zed/assets/2690773/c66e6e78-44ec-4de8-8d60-43238bb09ae9">

has similar settings and keymap (actions work in the `OutlinePanel`
context and are under `outline_panel::` namespace), with two notable
differences:
* no "edit" actions such as cut/copy/paste/delete/etc.
* directory auto folding is enabled by default

Empty view: 
<img width="841" alt="Screenshot 2024-06-10 at 23 19 11"
src="https://github.com/zed-industries/zed/assets/2690773/dc8bf37c-5a70-4fd5-9b57-76271eb7a40c">


When editor gets active, the panel displays all related files in a tree
(similar to what the project panel does) and all related excerpts'
outlines under each file.
Same as in the project panel, directories can be expanded or collapsed,
unfolded or folded; clicking file entries or outlines scrolls the buffer
to the corresponding excerpt; changing editor's selection reveals the
corresponding outline in the panel.

The panel is applicable to any singleton buffer:
<img width="1215" alt="Screenshot 2024-06-10 at 23 19 35"
src="https://github.com/zed-industries/zed/assets/2690773/a087631f-5c2d-4d4d-ae25-30ab9731d528">

<img width="1728" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/e4f8082c-d12d-4473-8500-e8fd1051285b">

or any multi buffer:

(search multi buffer)

<img width="1728" alt="Screenshot 2024-06-10 at 23 19 41"
src="https://github.com/zed-industries/zed/assets/2690773/60f768a3-6716-4520-9b13-42da8fd15f50">

(diagnostics multi buffer)
<img width="1728" alt="image"
src="https://github.com/zed-industries/zed/assets/2690773/64e285bd-9530-4bf2-8f1f-10ee5596067c">

Release Notes:
- Added an outline panel to show a "map" of the active editor

Kirill Bulatov created

7f56f4e Add libgit2 build dependency to Arch-based distros (#12924)

Click to expand commit body
Release Notes:

- N/A

DocKDE created

6fa347d Move rustdoc-related code to `rustdoc` crate (#12945)

Click to expand commit body
This PR moves the rustdoc-related code out of `html_to_markdown` and
into the `rustdoc` crate.

Release Notes:

- N/A

Marshall Bowers created

c3df9b7 Start on rustdoc crawler (#12942)

Click to expand commit body
This PR adds a first pass at a rustdoc crawler.

We'll be using this to get information about a crate from the rustdoc
artifacts for use in the Assistant.

Release Notes:

- N/A

---------

Co-authored-by: Richard <richard@zed.dev>

Marshall Bowers and Richard created

72dac24 Add missing LICENSE file to `ollama` crate (#12943)

Click to expand commit body
This PR adds a missing LICENSE file to the recently-added `ollama`
crate.

Also added the missing `lints.workspace = true` to the `Cargo.toml`.

Release Notes:

- N/A

Marshall Bowers created

001f17c vim: Implement named registers (#12895)

Click to expand commit body
Release Notes:

- vim: Add support for register selection `"a`-`"z`, `"0`-`"9`, `"-`.
`"_` and `"%`
([#11511](https://github.com/zed-industries/zed/issues/11511))

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

Paul Eguisier and Conrad Irwin created

3c3dad6 v0.141.x dev

Joseph T Lyons created

1b28f93 Make notification windows not have titles on X11 (#12935)

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Release Notes:

- N/A

Co-authored-by: Max <max@zed.dev>

Conrad Irwin and Max created

2fd00a8 docs: Capitalize Vim in Vim mode documentation (#12934)

Click to expand commit body
Release Notes:

- N/A

Thorsten Ball created

bee3441 Ollama improvements (#12921)

Click to expand commit body
Attempt to load the model early on when the user has switched the model.

This is a follow up to #12902

Release Notes:

- N/A

Kyle Kelley created

113546f Do not encourage additional ignored labels

Click to expand commit body
We recently reduced the set of ignored labels down to a single label: "ignore top-ranking issues." It makes sense that we don't allow for multiple to be registered in this script now.

Joseph T Lyons created

5e9f9b4 Wrap JS/TS runnables in quotes (#12932)

Click to expand commit body
Some of the runnables added in #12118 don't work for tests (or code)
that contain spaces. In other words, the runnable for a test like
```js
it('does the thing', () => ...)
```
would end up w/ something like `npx jest does the thing
/path/to/file.spec.js`, but what we really want is `npx jest
--testNamePattern "does the thing" /path/to/file.spec.js`. A similar
thing was happening for the "node execute selection" runnable: selecting
`let foo = 1` would run `node -e let foo = 1`, not `node -e "let foo =
1"`.

In my (somewhat limited?) experience, it's very common for tests like
these to include spaces, and of course a code selection is almost
certain to contain whitespace.

Not covered: 
- this just blindly wraps quotes around the symbol/code; in the future
it may make sense to try to figure out *what type of quote* to use. (eg
`it('does the "thing"', () => ...)` is a valid test name, but
`--testNamePattern "does the "thing""` would not work. Note the doubled
quotes.)
- I did not wrap the filenames in quotes to escape those for the shell,
nor did I test if that's actually an issue. In my experience, I've not
seen many (any?) test files that contain spaces in the name, but I
suspect that it would be an issue if a containing dir includes spaces.
(eg `npx jest ... /path/to/My Documents/Code/file.spec.js`

/cc @RemcoSmitsDev 

Release Notes:

- Fixed some runnables in Javascript/Typescript

claytonrcarter created

ec95a33 Added TSX test runnables (#12922)

Click to expand commit body
Fix #12884

Release Notes:

- Added runnable tests for TSX files.

---
Runnable tests can be customized via `tsx-test` tag

---------

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>

Chung Wei Leong and Piotr Osiewicz created

b823509 linux: Use filesystem based unix socket instead of abstract namespace (#12756)

Click to expand commit body
Release Notes:

- N/A

fixes: unable to launch multiple zed instances even if the support dirs
are different(example: bwrap based sandboxing)

maan2003 created

e16bbe0 Make install.sh sh-compatible (#12899)

Click to expand commit body
Co-Authored-By: Max <max@zed.dev>

Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>
Co-authored-by: Shyim <github@shyim.de>

Conrad Irwin , Max , and Shyim created

ab41edd Fix cursors on some GNOME installations (#12914)

Click to expand commit body
This PR adds support for `org.gnome.desktop.interface`'s `cursor-theme`
setting on Wayland. This should fix cursors not showing up on some GNOME
installs. This PR also adds the wiring to watch the current cursor theme
value.

Thanks to @apricotbucket28 for helping debug the issue.

Release Notes:

- N/A

Mikayla Maki created

4cb8d6f Ollama Provider for Assistant (#12902)

Click to expand commit body
Closes #4424.

A few design decisions that may need some rethinking or later PRs:

* Other providers have a check for authentication. I use this
opportunity to fetch the models which doubles as a way of finding out if
the Ollama server is running.
* Ollama has _no_ API for getting the max tokens per model
* Ollama has _no_ API for getting the current token count
https://github.com/ollama/ollama/issues/1716
* Ollama does allow setting the `num_ctx` so I've defaulted this to
4096. It can be overridden in settings.
* Ollama models will be "slow" to start inference because they're
loading the model into memory. It's faster after that. There's no UI
affordance to show that the model is being loaded.

Release Notes:

- Added an Ollama Provider for the assistant. If you have
[Ollama](https://ollama.com/) running locally on your machine, you can
enable it in your settings under:

```jsonc
"assistant": {
    "version": "1",
    "provider": {
      "name": "ollama",
      // Recommended setting to allow for model startup
      "low_speed_timeout_in_seconds": 30,
    }
}
```

Chat like usual

<img width="1840" alt="image"
src="https://github.com/zed-industries/zed/assets/836375/4e0af266-4c4f-4d9e-9d74-1a91f76a12fe">

Interact with any model from the [Ollama
Library](https://ollama.com/library)

<img width="587" alt="image"
src="https://github.com/zed-industries/zed/assets/836375/87433ac6-bf87-4a99-89e1-96a93bf8de8a">

Open up the terminal to download new models via `ollama pull`:


![image](https://github.com/zed-industries/zed/assets/836375/af7ec411-76bf-41c7-ba81-64bbaeea98a8)

Kyle Kelley created

127b9ed project_panel: Don't show file icon during rename when file icons are otherwise hidden (#12910)

Click to expand commit body
This PR fixes an instance where the file icon for a project panel entry
would be shown during a rename even when the `project_panel.file_icons`
setting was set to `false`.

Resolves #12905.

Release Notes:

- Fixed an issue where file icons were displayed in the project panel
during a rename even when `project_panel.file_icons` was set to `false`
([#12905](https://github.com/zed-industries/zed/issues/12905)).

Marshall Bowers created

c30f6a1 Fix alt key getting stuck when tabbing on linux (#12912)

Click to expand commit body
Release Notes:

- N/A

Mikayla Maki created

8ccd2a0 Add tag handler for collecting crate items from rustdoc output (#12903)

Click to expand commit body
This PR adds a tag handler for collecting crate items from rustdoc's
HTML output.

This will serve as the foundation for getting more insight into a
crate's contents.

Release Notes:

- N/A

Marshall Bowers created

57b87be Hoist `indexmap` to workspace level (#12901)

Click to expand commit body
This PR hoists `indexmap` up to a workspace dependency.

Release Notes:

- N/A

Marshall Bowers created

80c14c9 Pull app / OS info out of GPUI, add Linux information, make fallible window initialization (#12869)

Click to expand commit body
TODO:
- [x] Finish GPUI changes on other operating systems 

This is a largely internal change to how we report data to our
diagnostics and telemetry. This PR also includes an update to our blade
backend which allows us to report errors in a more useful way when
failing to initialize blade.


Release Notes:

- N/A

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

Mikayla Maki and Conrad Irwin created

ec9e700 linux/x11: Mark windows as destroyed after destroy request (#12892)

Click to expand commit body
Turns out we still get FocusOut and UnmapNotify events after the window
has been destroyed, which resulted in error messages popping up because
we can't find the window anymore that we want to mark as unfocused.



Release Notes:

- N/A

Thorsten Ball created

a06189b Fix most vim tests on linux (#12873)

Click to expand commit body
Fixes most vim tests on linux (and a few editor ones) by loading Zed
Mono
instead of relying on the system fallback stack.

Release Notes:

- N/A

Conrad Irwin created

53b0720 Remove headers from prompt library picker (#12889)

Click to expand commit body
Also, as a drive-by, we're fixing up/down not working in inline
assistant editor.

Release Notes:

- N/A

Antonio Scandurra created

b6ea393 lsp: Add support for linked editing range edits (HTML tag autorenaming) (#12769)

Click to expand commit body
This PR adds support for [linked editing of
ranges](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_linkedEditingRange),
which in short means that editing one part of a file can now change
related parts in that same file. Think of automatically renaming
HTML/TSX closing tags when the opening one is changed.
TODO:
- [x] proto changes
- [x] Allow disabling linked editing ranges on a per language basis.

Fixes #4535 

Release Notes:
- Added support for linked editing ranges LSP request. Editing opening
tags in HTML/TSX files (with vtsls) performs the same edit on the
closing tag as well (and vice versa). It can be turned off on a language-by-language basis with the following setting:
```
  "languages": {
    "HTML": {
      "linked_edits": true
    },
  }
```

---------

Co-authored-by: Bennet <bennet@zed.dev>

Piotr Osiewicz and Bennet created

98659ea Overhaul inline assistant (#12846)

Click to expand commit body
This pull request introduces a new diff mechanism that helps users
understand exactly which lines were changed by the LLM.

Release Notes:

- N/A

Antonio Scandurra created

3722275 linux/x11: Only create ModifiersChanged event if they changed (#12879)

Click to expand commit body
I noticed that when I use my mouse wheel, we get a ton of the
`XkbStateNotify` events, but the modifiers don't change, so we add a ton
of useless input events for the window.

Release Notes:

- N/A

Thorsten Ball created

ef84ce7 linux make install (#12870)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

44a5864 Wait for composition to end before sending InputIgnored (#12871)

Click to expand commit body
Release Notes:

- vim: Fixed `f`/`t` etc. for keys that require IME (#12522)

Conrad Irwin created

4e98c23 Reconnect button for remote projects (#12669)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Max <max@zed.dev>

Conrad Irwin and Max created

1914a42 Update windows doc to mention rust-lld linker error (#12859)

Click to expand commit body
Release Notes:

- N/A

## Description

When using rust-lld it's possible to get a `STATUS_ACCESS_VIOLATION`
error at compile time. I added a bit of information about it in the
build guide for windows to recommend using a different linker when
building `zed`.

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>

IceSentry and Marshall Bowers created

6afed19 Update EULA (#12858)

Click to expand commit body
Release Notes:

- N/A

Joseph T. Lyons created

2509af7 assistant: Improve JSON handling in `/fetch` command (#12864)

Click to expand commit body
This PR improves the `/fetch` command with better support for URLs that
return JSON content.

JSON response bodies will now be pretty-printed and placed within a
Markdown code block:

<img width="690" alt="Screenshot 2024-06-10 at 3 39 52 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4a7c1cb7-9f5b-4a63-9e8e-5168bf9a6625">

Release Notes:

- Improved the handling of JSON response bodies in the `/fetch` command
in the Assistant.

Marshall Bowers created

8078e58 Remove unused `color` crate (#12860)

Click to expand commit body
This PR removes the `color` crate, as it was not used anywhere.

We had added this experimentally, but right now its existence is just a
source of confusion.

Release Notes:

- N/A

Marshall Bowers created

b69c312 Add missing LICENSE file to `proto` crate (#12863)

Click to expand commit body
This PR adds a missing LICENSE file to the recently-extracted `proto`
crate.

Release Notes:

- N/A

Marshall Bowers created

e2c5ce5 Fix target of proto diff on CI (#12861)

Click to expand commit body
Release Notes:

- N/A

Nathan Sobo created

7005aaa Update linux.md

Mikayla Maki created

9db2697 Update linux.md

Mikayla Maki created

77e88c1 Extract a `proto` crate out of `rpc` (#12852)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Nathan <nathan@zed.dev>

Antonio Scandurra and Nathan created

57c4029 Show extension download counts with thousands separators (#12857)

Click to expand commit body
This PR adjusts the extension download counts to be displayed using
thousands separators.

Release Notes:

- Adjusted extension download counts to display with thousands
separators (e.g., `1,000,000`).

Marshall Bowers created

0d5485b assistant: Add `/now` slash command (#12856)

Click to expand commit body
This PR adds a `/now` command to the Assistant for indicating the
current date and time to the model.

Release Notes:

- Added `/now` command to the Assistant for getting the current date and
time.

Marshall Bowers created

a600799 ruby: Remove outline for running tests (#12642)

Click to expand commit body
Hi, this pull request superseeds the
https://github.com/zed-industries/zed/pull/12624
and removes queries for runnables from `outline.scm`. This pull request
has couple things to mention:

- Removed task for running tests with `minitest` as I think it's not
reliable in its state because, AFAIK, the only way to run `minitest`
with the specific line, i.e. `bundle exec rake test
spec/models/some_model.rb:12` is to use it with Rails. The support for
`minitest` is still there and users can add their own task, for
instance, when they use `minitest` in Rails to get support for running
tests:

  ```json
  {
    "label": "test $ZED_RELATIVE_FILE:$ZED_ROW",
    "command": "./bin/rails",
    "args": ["test", "\"$ZED_RELATIVE_FILE:$ZED_ROW\""],
    "tags": ["minitest-test"]
  }
  ```

**Question:** Perhaps that should be mentioned in the Ruby extension
documentation?

- Adjusted runnables queries to work without `ZED_SYMBOL`.

Release Notes:

- N/A

Vitaly Slobodin created

05b6581 linux/x11: handle XIM events sync to reduce lag (#12840)

Click to expand commit body
This helps with the problem of keyboard input feeling laggy when the
event loop is under load.

What would previously happen is:

- N events from X11 arrive
- N events get forwarded to XIM
- N events are handled in N iterations of the event loop (sadly, yes: we
only seem to be getting back one `ClientMessage` per poll from XCB
connection)
- Each event is pushed into the channel
- N event loop iterations are needed to get the events off the channel
and handle them

With this change, we get rid of the last 2 steps: instead of pushing the
event onto a channel, we store it on the XIM handler itself, and then
work it off synchronously.

Usually one shouldn't block the event loop, but I think in this case -
user input! - it's better to handle the events directly instead of
re-enqueuing them again in a channel, where they can accumulate and need
multiple iterations of the loop to be worked off.

This does *not* fix the problem of input feeling choppy/slower when the
system is under load, but it makes the behavior now feel exactly the
same as when XIM is disabled.

I also think the code is easier to understand since it's more
straightforward.

Release Notes:

- N/A

Thorsten Ball created