0742640
Correctly report line boundaries when a map contains both folds and wraps
This fixes the randomized test failures that were occurring on main.
Antonio Scandurra created
1a53d5b
Use a new `Workspace::activate_item` API in project diagnostics
Previously, we would only activate the pane without switching the pane's *active item*.
Antonio Scandurra created
f933d54
When selections lose their excerpts, move them to the next primary diagnostic
Max Brunsfeld created
ce6f3d7
Reuse views when moving between diagnostic view and editors
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
ea26382
Finish implementing ProjectDiagnostics::open_excerpts
* Build workspace item views with a reference to the workspace * Add randomized test for MultiBuffer::excerpted_buffers and fix a small bug Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
e5c520a
Use `Buffer` handles instead of `MultiBuffer` as editor workspace items
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
794d214
Refactor opening workspace items
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
3cab32d
WIP: Add keybinding to open buffers under cursors
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
cf62d26
Display a "Checking..." message when running disk-based diagnostics
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
e39be35
Show status bar item for project diagnostic summary
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
56496c2
Move back `diagnostic_summaries` into `Worktree`
This fixes an issue where updating the snapshot's entries would override the diagnostic summaries received on the remote side. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
089542c
Avoid removing diagnostics from `Worktree` after opening a buffer
This allows re-opening the same buffer and supplying the previous diagnostics.
Antonio Scandurra created
67f672d
Clear selections on other excerpted buffers when setting active selections
Antonio Scandurra created
94e9c7f
Give a full-width background to the diagnostic headers
Max Brunsfeld created
2b36ab0
Introduce Expanded element
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
1f762e4
Unify Flexible and Expanded elements
We'll use the name Expanded for something else now. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
b19d92e
Keep selections at the top of the project diagnostics view when it is first populated
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
9bbe67f
Don't clobber diagnostics when getting new snapshot from background scanner
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
7357b3f
Revert "Remove special handling of multi-line primary diagnostic messages and fix tests"
This reverts commit ce4142eab39118a2ecd43a0473a3e7035087191e.
Max Brunsfeld created
10548c2
Always group diagnostics the way they're grouped in the LSP message
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
943571a
Report backtraces of pending conditions when deterministic executor illegally parks
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
2dbee1d
Send diagnostic summaries to guests when they join the project
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
Nathan Sobo and Max Brunsfeld created
d7a78e1
Allow disk-based diagnostic progress begin/end events to interleave
When multiple saves occur, we can have multiple start events followed by multiple end events. We don't want to update our project diagnostics view until all pending progress is finished. Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
571d038
Re-focus diagnostics editor when transitioning from an empty to a populated state
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Nathan Sobo and Antonio Scandurra created
1875a0e
Polish rendering of inline errors
- Don't soft-wrap - Render multiple lines Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Antonio Scandurra and Nathan Sobo created
d0f7e5f
Maintain excerpt ordering correctly when some errors don't change
Antonio Scandurra created
f37f839
Wire up `refresh_anchors` in `Editor::refresh_selections` and call it
Antonio Scandurra created
7340e83
WIP - MultiBuffer::refresh_anchors
Max Brunsfeld created
fee7657
Merge branch 'main' into polish-project-diagnostics
Max Brunsfeld created
b10f06d
Merge pull request #308 from zed-industries/fix-collaboration-regressions
Fix collaboration regressions
Nathan Sobo created
f9f75e9
Fix Locator::from_index
Enhance language::tests::test_random_collaborators so that it checks buffer invariants. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
e5faaeb
Fix `Global::gt` and rename it to `changed_since`
A false negative return value of `gt` was preventing guests' multibuffers from syncing correctly. Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
5a53eee
Don't scroll editors away from the top of their buffer when content changes
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
85a13fa
Fix panic when resolving anchors after an excerpt id has been recycled
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Max Brunsfeld and Nathan Sobo created
8728d32
Merge branch 'main' into polish-project-diagnostics
Also fix false failure in ModelHandle::condition when parking is not forbidden.
Max Brunsfeld created
29b63ae
Remove invalid excerpts as opposed to styling them differently
Antonio Scandurra created
4b22e49
Merge pull request #306 from zed-industries/serialize-buffer-undos
Fix buffer replication bugs that would lead to divergence among replicas
Antonio Scandurra created
fe28abe
Show a message when no diagnostics are available
Antonio Scandurra created
e56609c
Ensure prior, deferred selections don't override newer selections
Antonio Scandurra created
eb65a5d
Fix `TreeMap::get` always returning `None`
Antonio Scandurra created
f8c2620
Fix `Buffer::remote_selections_in_range` at query range boundaries
Antonio Scandurra created
587a908
Populate deferred operations when an operation can't be applied
Antonio Scandurra created
bf04450
Verify that selections are replicated correctly in randomized test
Antonio Scandurra created
870fa5f
Serialize deferred operations
Antonio Scandurra created
d383ff3
Introduce randomized test for collaboration on buffers
This test will exercise serialization of operations as well as peers replicating from an existing buffer.
Antonio Scandurra created
7bc8eb4
Fix compile errors and get serialization unit test passing
Antonio Scandurra created
984e366
WIP - Serialize buffer in terms of its state, not its base text + ops
The main reason for this is that we need to include information about a buffer's UndoMap into its protobuf representation. But it's a bit complex to correctly incorporate this information into the current protobuf representation. If we want to continue reusing `Buffer::apply_remote_edit` for incorporating the historical operations, we need to either make that method capable of incorporating already-undone edits, or serialize the UndoMap into undo *operations*, so that we can apply these undo operations after the fact when deserializing. But this is not trivial, because an UndoOperation requires information about the full offset ranges that were undone.
Max Brunsfeld created
0bcd0a3
Forward events from remote worktrees to their projects
Max Brunsfeld created
d7ecbdc
Add unit test showing problem with serialization of undo ops
Max Brunsfeld created
d8b888c
Replicate diagnostic summaries
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
Max Brunsfeld and Antonio Scandurra created