b51a28b
Return back Windows menu (#22339)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/21873 Release Notes: - N/A
Kirill Bulatov created
b51a28b
Return back Windows menu (#22339)
Follow-up of https://github.com/zed-industries/zed/pull/21873 Release Notes: - N/A
Kirill Bulatov created
dbb7610
Improve layout of completions doc popover (#22337)
* Now more often displayed to the right. Resizes docs width if more space than min width is available. * If constrained in horizontal space and so displayed above/below resize docs height to fit. * Makes space for scrollbar and gap. Layout is imperfect for viewport sizes smaller than the context menu, left TODOs in the code for handling this. Wanted to get this change out for feedback first. Release Notes: - N/A
Michael Sloan created
6b92e0b
In terminal context, open new terminals with `cmd-n` instead of new files (#22253)
Release Notes: - In terminal context, `cmd-n` and `ctrl-n` now open a new terminal instead of a new file
Cole Miller created
2930211
Allow disabling editor scrollbars programmatically (#22333)
Disable them in the diff editors Closes https://github.com/zed-industries/zed/issues/22271 Release Notes: - N/A
Kirill Bulatov created
1449377
assistant2: Fix panics when confirming nonexistent entries in the context picker (#22332)
This PR fixes a panic that could occur when confirming when the context picker had no matching entries. Release Notes: - N/A
Marshall Bowers created
831930a
Make git panel entries clickable (#22329)
Makes a first pass over git panel UI, making it more interactive.  * every item can be selected, the selection is shown in the panel * every item can be clicked, which changes the selection and creates/focuses the editor with a project changes multi buffer * the editor is scrolled so that the clicked item is in the center * it's possible to nagivate up and down the panel, selecting next/previous items in it, triggering the editor scroll Known issues: * entries are updated oddly sometimes (should become better after DiffMap improvements land?) * only unstaged diffs are shown currently (entry status storage should help with this) * no deleted files are displayed (the underlying work is done by others now) * added files have no diff hunks shown (DiffMap will have it?) * performance story has not improved (again, DiffMap and status storage should help with this) Release Notes: - N/A
Kirill Bulatov created
bc32b4d
zeta: Compute diff on background thread (#22328)
@iamnbutler noticed slowness in assistant panel which I've pinned down to the fact that we're calculating buffer diff on foreground thread. This PR moves this computation into the background; I don't know much about Zeta but it seems fine to do, as the call-site is asynchronous anyways. Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
fac5118
python: Fix decorated test detection (#22327)
Follow-up to #22325, where I missed a couple points in the review that were actually quite relevant. Closes #ISSUE Release Notes: - N/A
Piotr Osiewicz created
7184b15
Add decorated function to pytest runnables (#22325)
Fixes: #22324 Closes #ISSUE Release Notes: - Fixed pytest decoracted function discovery
Thomas created
e82af55
assistant2: Adjust role info colors on the thread header (#22318)
<img width="800" alt="Screenshot 2024-12-20 at 9 01 29 PM" src="https://github.com/user-attachments/assets/5e9e9bf2-c84e-4215-b658-9b668dd151b2" /> Release Notes: - N/A
Danilo Leal created
dcd21e6
assistant2: Use `SwitchWithLabel` for the tool toggle (#22317)
<img width="800" alt="Screenshot 2024-12-20 at 8 52 27 PM" src="https://github.com/user-attachments/assets/4b4f62a3-eb23-489b-a459-2117baaa37b4" /> Release Notes: - N/A
Danilo Leal created
9efa131
assistant2: Use a label to render the thread menu item (#22316)
The thread menu items were rendering with a larger font that the file & directory counterparts. Now, they're consistent! | Before | After | Reference | |--------|--------|--------| | <img width="800" alt="Screenshot 2024-12-20 at 8 39 47 PM" src="https://github.com/user-attachments/assets/d196adcb-aea6-4399-8fb1-f5b771e76c1f" /> | <img width="800" alt="Screenshot 2024-12-20 at 8 35 43 PM" src="https://github.com/user-attachments/assets/a1e22c13-fd7e-4665-b09b-f3b583e7ce24" /> | <img width="800" alt="Screenshot 2024-12-20 at 8 40 38 PM" src="https://github.com/user-attachments/assets/d509ac6f-1251-4240-a369-906faebed8c0" /> | Release Notes: - N/A
Danilo Leal created
6dbc12f
Add the `SwitchWithLabel` component (#22314)
<img width="800" alt="Screenshot 2024-12-20 at 8 31 14 PM" src="https://github.com/user-attachments/assets/1d7bd10a-0db3-41e4-9f59-977cc2ab137c" /> Release Notes: - N/A
Danilo Leal created
a8afc63
gpui: Remove use of `use gpui::*` in examples (#22311)
This PR removes the use of `use gpui::*` in the GPUI examples, as this is not how consumers should be importing GPUI. Release Notes: - N/A
Marshall Bowers created
7c6feeb
Remove usage of `use gpui::*` (#22310)
This PR removes usages of `use gpui::*;` in the codebase (excluding examples). We should only use glob imports for `gpui::prelude`, and then import everything else individually. Release Notes: - N/A
Marshall Bowers created
fadf9ff
Make breadcrumb content scrollable (#22309)
Part of https://github.com/zed-industries/zed/issues/5363 https://github.com/user-attachments/assets/66c90cb7-1b36-4436-ad1e-344fbcd4befc Release Notes: - N/A
Danilo Leal created
9b2bc45
Expand diagnostic excerpts using heuristics on syntactic information from TreeSitter (#21942)
This is quite experimental and untested in languages other than Rust. It's written to attempt to do something sensible in many languages. Due to its experimental nature, just releasing to staff, and so not including it in release notes. Future release note might be "Improved diagnostic excerpts by using syntactic info to determine the context lines to show." Release Notes: - N/A
Michael Sloan created
ca9cee8
linux: Fix non-maximized Zed windows growing larger across sessions (#22301)
Closes #17870
Context:
On Linux, when creating a new window, bounds are either pulled from
existing workspace data (serialized in an SQLite DB) or fall back to
some default constants if no data exists.
These bounds include the full dimensions of the window (width and
height), which already account for insets. However, properties like
`inset` (Wayland) or `last_insets` (X11) exist only at the platform
level and are not part of the window bounds themselves.
During rendering, we call `set_client_inset`, which updates the inset
values and also adjusts the window bounds, increasing their dimensions.
In Zed's case, the inset is 10px, which adds 20px to both the width and
height (10px from each side).
Problem:
When quitting, the full window bounds (which already account for inset)
are saved to the DB. On reopening, these saved bounds are used to create
the window. `set_client_inset` runs again and inflates the dimensions
even more.
Solution:
Store window bounds *without* the inset-inflated dimensions. On the next
session, `set_client_inset` will take care of applying the inset,
resulting window dimensions matching the previous session. This fix is
in the PR.
Alternative Solution:
Another option is to save the inset explicitly in the DB and apply it
during window creation. But this means storing more data, and the inset
would need to be platform-agnostic, which adds complexity. Doesn’t seem
worth it for no real gain.
X11 Before:
```sh
saving window bounds with width: 1136, height: 784
tims@lemon ~/w/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s
Running `target/debug/zed`
saving window bounds with width: 1156, height: 804 <---- +20px
tims@lemon ~/w/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s
Running `target/debug/zed`
saving window bounds with width: 1176, height: 824 <---- +20px
tims@lemon ~/w/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.36s
Running `target/debug/zed`
saving window bounds with width: 1196, height: 844 <---- +20px
```
X11 After:
```sh
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s
Running `target/debug/zed`
saving window bounds with width: 1116, height: 764
tims@lemon ~/w/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s
Running `target/debug/zed`
saving window bounds with width: 1116, height: 764 <---- same
tims@lemon ~/w/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s
Running `target/debug/zed`
saving window bounds with width: 1116, height: 764 <---- same
```
On Wayland, saving occurs only when you actually resize the window (on
X11, saving happens both on init and while dragging the window). To
trigger saving, I manually resized the window by ~1px to make it print.
Wayland Before:
```sh
Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 36s
Running `target/debug/zed`
saving window bounds with width: 945, height: 577
tims@orange ~/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.77s
Running `target/debug/zed`
saving window bounds with width: 966, height: 597 <--- +20px on both (1px increase in width is me resizing)
tims@orange ~/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.87s
Running `target/debug/zed`
saving window bounds with width: 987, height: 618 <--- +20px on both (1px increase in width and height is me resizing)
tims@orange ~/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.89s
Running `target/debug/zed`
saving window bounds with width: 1006, height: 638 <--- +20px on both (1px decrease in width is me resizing)
```
Wayland After:
```sh
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.82s
Running `target/debug/zed`
saving window bounds with width: 925, height: 558
tims@orange ~/zed (fix-window-growing-larger)> cargo run
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.84s
Running `target/debug/zed`
saving window bounds with width: 925, height: 557 <--- same (1px decrease in height is me resizing)
saving window bounds with width: 925, height: 558
```
Release Notes:
- Fix non-maximized zed windows growing larger across sessions on Linux
---------
Co-authored-by: mgsloan@gmail.com <michael@zed.dev>
tims and mgsloan@gmail.com created
c01403b
Reapply completion docs prefetch (#22306)
Leaving release notes as N/A because it had release notes in the past in #21705 In #21286, documentation resolution was made more efficient by only resolving the current completion. However, this meant that single line documentation shown inline in the menu was missing until scrolled to. This also meant that it would wait for navigation to resolve completion docs, leading to lag for displaying documentation. This change resolves this by attempting to fetch all the completions that will be shown. It also mostly avoids re-resolving completions. It intentionally re-resolves the current selection on navigation, as some language servers will respond with more information later on. Release Notes: - N/A
Michael Sloan created
8ee04bf
Fix remote dev project name label (#22307)
Closes https://github.com/zed-industries/zed/issues/21877 <img width="800" alt="Screenshot 2024-12-20 at 6 45 50 PM" src="https://github.com/user-attachments/assets/2069465f-1a00-47de-b691-585bb2603279" /> Release Notes: - N/A
Danilo Leal created
4ed0e51
Inline assistant v2 layout (#22305)
Makes the inline assistant look like @danilo-leal's prototype. Also fixes the bug with indent guides that @maxdeviant found! <img width="1059" alt="Screenshot 2024-12-20 at 4 24 56 PM" src="https://github.com/user-attachments/assets/5e55a3c2-768a-4e9d-bad5-d4ebbe9db9ce" /> Release Notes: - N/A
Richard Feldman created
72e56ee
Use stable Alacritty crate version (#22304)
Release Notes: - N/A
Kirill Bulatov created
306fc19
Fix knockout icon background to match hovered entry background in project panel (#22258)
No issue attached, as this is something trivial and should have been part of my merged PR [here](https://github.com/zed-industries/zed/pull/22073). For context, in the above-mentioned PR, I removed the hover color from selected/marked entries in the Project Panel. The reasoning behind this change is already explained in that PR, but to reiterate: > This change was inspired by the behavior in VSCode, the Firefox sidebar, and Dolphin (KDE File Manager). When an item is selected, it doesn’t display a separate hover state to avoid confusing users about whether the item is selected or merely hovered over. @nilskch mentioned in the comments of the above PR that I should have also changed the background of the knockout icon, which appears on entries, to match the entry background color on hover. This PR addresses that. Before:  After:  Release Notes: - N/A
tims created
4fbb568
Improve `script/bump-zed-minor-version` (#22199)
- Follow up to: https://github.com/zed-industries/zed/pull/22170 CC: @mgsloan Release Notes: - N/A --------- Co-authored-by: Michael Sloan <mgsloan@gmail.com>
Peter Tripp and Michael Sloan created
7913b6a
assistant2: Restrict directory context picker to development builds (#22302)
This PR temporarily restricts the directory context picker to development builds until the implementation is finished. Release Notes: - N/A
Marshall Bowers created
d566792
assistant2: List directories in directory context picker (#22300)
This PR updates the directory context picker in Assistant2 to show the available directories. Release Notes: - N/A
Marshall Bowers created
62f5ca5
editor: Improve performance of lsp_ext validation (#22299)
We've received a complaint on Discord about bad multicursor performance. I too run 15k cursor simultaneously. The gist of the issue was in the lsp_ext; whenever we gather up actions to be registered on a buffer, we need to know whether a buffer has any of the languages for which we have LSP extensions. The problem stemed from the fact that we did a two-phase filtering. For each selection we'd first check whether this selection lies in a part of a file that is part of a language for which we have LSP extensions. Then, we'd check whether we're running a language server of interest for this buffer. This is not optimal, because it would often do the redundant work: 1. We resolve selections for buffer that are known to not contain a given language server. 2. We look up language server in the LspStore once per each matching selection. In case where the file is not related at all, we end up resolving all of the selections which is pretty bad. This PR makes us skip buffers which are known to not match the criteria. It also caches the result of language server lookup for the buffers. Closes #ISSUE Release Notes: - Improved performance with large quantity of cursors
Piotr Osiewicz created
4eb8492
chore: Remove stray println (#22297)
Follow-up to #22292 Release Notes: - N/A
Piotr Osiewicz created
d824bae
Fix lang servers status set to Downloading when checking version (#22292)
This message has confused me many times too: we printed the status as "Downloading" when we were only checking whether we need to install a given version of a language server. This fixes the issue for Node-based language servers where we had the same check in all implementations. Closes #22241 Release Notes: - Fixed some language servers reporting status as "Downloading..." when only a version check was being done.
Thorsten Ball created
8a858fe
Enable Assistant2 outside of development builds (#22294)
This PR removes the gate that limited Assistant2 to development builds, so that we can start testing it out in Nightly. Note that currently this still requires explicit opt-in to the `assistant2` feature flag. Release Notes: - N/A
Marshall Bowers created
cbd2e81
Add arrow key movements to terminal vi mode (#22103)
Expands #18715 Release Notes: - Added arrow keys movement to the built-in terminal's [vi mode](https://github.com/alacritty/alacritty/blob/master/docs/features.md#vi-mode) (which is using Alacritty under the hood). Details -- A minuscule improvement on #18715 to allow user with alternative keyboard layouts to use the terminal's vi mode with the arrow keys.
Alejandro Gómez-Londoño created
b25d8ec
vim: Fix deletion with sentence-motion (#22289)
Fixes #22151. Turns out Vim also has some weird behavior with sentence deletion in case it's on the first character of a line. Release Notes: - vim: Fixed deleting sentence-wise (i.e. `d(` and `d)`), which would previously delete the whole line instead of just a sentence.
Thorsten Ball created
7c03e11
Fix blank line cursor width (#22275)
This PR ensures that, for fixed-width fonts, the cursor width is the same on blank lines as on non-blank lines, as well as at the end of a line. It does so by using the em advance to define the cursor width instead of the em width in these cases. Note that this can look... bizarre on non-fixed-width fonts: <img width="93" alt="Screenshot 2024-12-19 at 21 43 11" src="https://github.com/user-attachments/assets/a4c9b26c-98ea-4a1d-947b-51f1acd3c2f8" /> However, this is arguably reasonably consistent with how (terminal) Vim handles it: <img width="45" alt="Screenshot 2024-12-19 at 21 46 42" src="https://github.com/user-attachments/assets/ec3ff614-7a15-4cc3-8d14-3d15ce62f2b8" /> Closes #22260. Release Notes: - N/A
Aaron Feickert created
f3fc4d6
Add a CI check for `todo!` and `FIXME` comments (#21950)
Motivation for this is to support writing comments that will certainly be revisited before merge. Release Notes: - N/A
Michael Sloan created
e4493d6
linux: Fix wrong cursor theme for arrow cursor style (#22276)
Closes #22264 On Linux, the arrow cursor style currently used by Zed is `arrow`. However, this style might not be available in most themes, causing the cursor to fall back to system default theme. Note cursor style are platform (X11 and Wayland) agnostic. Most themes use `left_ptr` as their arrow cursor style instead of `arrow`. In some cases, `left_ptr` and `arrow` are symlinks pointing to the `default` style, but the `default` style is not guaranteed to be available across all themes. After inspecting the available cursor themes on popular desktop environments, changing the default from `arrow` to `left_ptr` seems to be available in all of them. `left_ptr` as default cursor style is also mentioned in [Arch Wiki: Cursor themes](https://wiki.archlinux.org/title/Cursor_themes#Change_X_shaped_default_cursor). KDE: ```sh tims@lemon /u/s/icons> find . -name "arrow" ./Breeze_Snow/cursors/arrow ./breeze_cursors/cursors/arrow ./Adwaita/cursors/arrow tims@lemon /u/s/icons> find . -name "default" ./default ./Breeze_Snow/cursors/default ./breeze_cursors/cursors/default ./Adwaita/cursors/default tims@lemon /u/s/icons> find . -name "left_ptr" ./Oxygen_White/cursors/left_ptr ./KDE_Classic/cursors/left_ptr ./Oxygen_Yellow/cursors/left_ptr ./Oxygen_Blue/cursors/left_ptr ./Oxygen_Black/cursors/left_ptr ./Breeze_Snow/cursors/left_ptr ./breeze_cursors/cursors/left_ptr ./Adwaita/cursors/left_ptr ./Oxygen_Zion/cursors/left_ptr ``` Gnome: ```sh tims@orange:/usr/share/icons$ find . -name "arrow" ./DMZ-Black/cursors/arrow ./Adwaita/cursors/arrow ./redglass/cursors/arrow ./whiteglass/cursors/arrow ./handhelds/cursors/arrow ./Yaru/cursors/arrow ./DMZ-White/cursors/arrow tims@orange:/usr/share/icons$ find . -name "default" ./Adwaita/cursors/default ./default ./Yaru/cursors/default tims@orange:/usr/share/icons$ find . -name "left_ptr" ./DMZ-Black/cursors/left_ptr ./Adwaita/cursors/left_ptr ./redglass/cursors/left_ptr ./whiteglass/cursors/left_ptr ./handhelds/cursors/left_ptr ./Yaru/cursors/left_ptr ./DMZ-White/cursors/left_ptr ``` My theme is set to Oxygen Yellow here. Before: <img src="https://github.com/user-attachments/assets/7485f1e7-5936-45b4-96bd-399525bad95d" alt="before" width="450px" /> After: <img src="https://github.com/user-attachments/assets/56090735-6a1f-4652-ad3e-075ff4c3f9ab" alt="after" width="450px" /> Release Notes: - Fixed wrong cursor theme for arrow cursor style on Linux.
tims created
3632b36
Move multibuffer tests to their own source file (#22270)
Release Notes: - N/A
Max Brunsfeld created
97e11fd
Update aws-sdk-rust monorepo (#22215)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [aws-config](https://redirect.github.com/smithy-lang/smithy-rs) | dependencies | patch | `1.5.10` -> `1.5.11` | | [aws-sdk-kinesis](https://redirect.github.com/awslabs/aws-sdk-rust) | dependencies | minor | `1.52.0` -> `1.53.0` | | [aws-sdk-s3](https://redirect.github.com/awslabs/aws-sdk-rust) | dependencies | minor | `1.65.0` -> `1.66.0` | --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Mi41IiwidXBkYXRlZEluVmVyIjoiMzkuNzIuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
150aa03
Update Rust crate hyper to v0.14.32 (#22207)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hyper](https://hyper.rs) ([source](https://redirect.github.com/hyperium/hyper)) | workspace.dependencies | patch | `0.14.31` -> `0.14.32` | --- ### Release Notes <details> <summary>hyperium/hyper (hyper)</summary> ### [`v0.14.32`](https://redirect.github.com/hyperium/hyper/releases/tag/v0.14.32) [Compare Source](https://redirect.github.com/hyperium/hyper/compare/v0.14.31...v0.14.32) #### Features - **server:** add `Builder::max_pending_accept_reset_streams(num)` option ([a24f0c0](https://redirect.github.com/hyperium/hyper/commit/a24f0c0af8e1f4c6b7cc3a47c83eb6e4af88aca6)) #### Bug Fixes - **http1:** fix intermittent panic parsing partial headers ([0f274ae](https://redirect.github.com/hyperium/hyper/commit/0f274ae653841e0a58b2835fd3edf47a08311e50)) #### New Contributors - [@​cratelyn](https://redirect.github.com/cratelyn) made their first contribution in [https://github.com/hyperium/hyper/pull/3796](https://redirect.github.com/hyperium/hyper/pull/3796) **Full Changelog**: https://github.com/hyperium/hyper/compare/v0.14.31...v0.14.32 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Mi41IiwidXBkYXRlZEluVmVyIjoiMzkuNzIuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
ebf6115
Update Rust crate semver to v1.0.24 (#22211)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [semver](https://redirect.github.com/dtolnay/semver) | workspace.dependencies | patch | `1.0.23` -> `1.0.24` | --- ### Release Notes <details> <summary>dtolnay/semver (semver)</summary> ### [`v1.0.24`](https://redirect.github.com/dtolnay/semver/releases/tag/1.0.24) [Compare Source](https://redirect.github.com/dtolnay/semver/compare/1.0.23...1.0.24) - Optimize Ord impls for semver::Prerelease and semver::BuildMetadata ([#​328](https://redirect.github.com/dtolnay/semver/issues/328), thanks [@​Eh2406](https://redirect.github.com/Eh2406)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Mi41IiwidXBkYXRlZEluVmVyIjoiMzkuNzIuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
394af74
Update Rust crate tree-sitter-c to v0.23.4 (#22212)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tree-sitter-c](https://redirect.github.com/tree-sitter/tree-sitter-c) | workspace.dependencies | patch | `0.23.2` -> `0.23.4` | --- ### Release Notes <details> <summary>tree-sitter/tree-sitter-c (tree-sitter-c)</summary> ### [`v0.23.4`](https://redirect.github.com/tree-sitter/tree-sitter-c/releases/tag/v0.23.4) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-c/compare/v0.23.2...v0.23.4) **NOTE:** Download `tree-sitter-c.tar.xz` for the *complete* source code. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Mi41IiwidXBkYXRlZEluVmVyIjoiMzkuNzIuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
7b0d63f
Update Rust crate tree-sitter-json to 0.24 (#22226)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tree-sitter-json](https://redirect.github.com/tree-sitter/tree-sitter-json) | workspace.dependencies | minor | `0.23` -> `0.24` | --- ### Release Notes <details> <summary>tree-sitter/tree-sitter-json (tree-sitter-json)</summary> ### [`v0.24.8`](https://redirect.github.com/tree-sitter/tree-sitter-json/releases/tag/v0.24.8) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.7...v0.24.8) **NOTE:** Download `tree-sitter-json.tar.xz` for the *complete* source code. ### [`v0.24.7`](https://redirect.github.com/tree-sitter/tree-sitter-json/releases/tag/v0.24.7) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.5...v0.24.7) **NOTE:** Download `tree-sitter-json.tar.xz` for the *complete* source code. ### [`v0.24.5`](https://redirect.github.com/tree-sitter/tree-sitter-json/releases/tag/v0.24.5) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.4...v0.24.5) **NOTE:** Download `tree-sitter-json.tar.xz` for the *complete* source code. ### [`v0.24.4`](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.3...v0.24.4) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.3...v0.24.4) ### [`v0.24.3`](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.2...v0.24.3) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.2...v0.24.3) ### [`v0.24.2`](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.1...v0.24.2) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.1...v0.24.2) ### [`v0.24.1`](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.0...v0.24.1) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.24.0...v0.24.1) ### [`v0.24.0`](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.23.0...v0.24.0) [Compare Source](https://redirect.github.com/tree-sitter/tree-sitter-json/compare/v0.23.0...v0.24.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- Release Notes: - N/A <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Mi41IiwidXBkYXRlZEluVmVyIjoiMzkuNzIuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate[bot] and renovate[bot] created
f64bfe8
linux: Fix saving file with root ownership (#22045)
Closes #13585 Currently, saving files with `root` ownership or `root` as the group throws a `Permission denied (os error 13). Please try again.` error. This PR fixes the issue on Linux by prompting the user for a password and saving the file with elevated privileges. It uses `pkexec` (Polkit), which is by default available on GNOME, KDE, and most Linux systems. I haven't implemented this for macOS as I don't have a device to test it on. This implementation is similar to how Vscode handles it. Except, they don't show custom message. **Working**: When file saving fails due to a `PermissionDenied` error, we create a temporary file in the same directory as the target file and writes the data to this temporary file. After, the contents of this file are copied to the original file using the `tee` command instead of `cp` or `mv`. This ensures that the ownership and permissions of the original file are preserved. This command is executed using `pkexec` which will prompt user for their password. **Custom Message**: The message displayed to the user in the prompt is automatically retrieved from the `org.zed.app.policy` file, which is located at `/usr/share/polkit-1/actions/`. This file should be installed during the setup process. While the policy file is optional, omitting it will cause the user to see the underlying command being executed rather than a user-friendly message. Currently, VSCode does not display the user-friendly message. The policy file must specify a unique binary, ensuring that only that binary can use the policy file. It cannot be as generic as a `/bin/bash`, as any software using bash to prompt will end up showing Zed’s custom message. To address this, we will create a custom bash script, as simple as the following, placed in `/usr/bin/zed/elevate.sh`. The script should have root ownership and should not reside in the home directory, since the policy file cannot resolve `$HOME`. ```sh #!/bin/bash eval "$@" ``` *IMPORTANT NOTE* Since copying the policy file and our script requires sudo privileges, the installation script will now prompt for the password at very end. Only on Linux, if `pexec` is installed. Screenshots: KDE with policy file:  Gnome with policy file:  Gnome without policy file:  VSCode:  User declines the permission request:  Release Notes: - Fixed file saving with root ownership on Linux.
tims created
5b86845
Fix docs for Bounds::from_corner_and_size (#22265)
(left in a todo!, oops) Release Notes: - N/A
Michael Sloan created
9782abf
ci: Put docs-only conditionals on each step (#22261)
This PR is a follow up to #22254 with a different approach. We need to put the conditional on each step in order to skip them, as I couldn't see any other way of bailing out of the pipeline early based on a condition. Release Notes: - N/A
Marshall Bowers created
6231072
Hide chat panel button when not in a call (#22200)
cc @nathansobo Release Notes: - Hide chat panel button by default when not in a call
Cole Miller created
2094d50
Fix permalink-to-line when Git repo root and worktree dir don't coincide (#22003)
Closes #21505. This should work if the git dir is an ancestor of the worktree dir or vice versa. Release Notes: - Fixed GitHub permalink-to-line actions when worktree dir and Git dir aren't the same
Cole Miller created
1e2fa3b
Update macOS system requirements in docs (#22248)
Update macOS system requirements to include Sequoia (15.x), the latest major version. Release Notes: - N/A Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Ringo De Smet and Marshall Bowers created
8e81070
terminal: Clear output after venv is activated (#22256)
The command used to activate the venv can still be accessed/scrolled to if needed. Release Notes: - The Python virtual environment activation command is no longer shown in the terminal output by default. Co-authored-by: Peter Tripp <peter@zed.dev>
Piotr Osiewicz and Peter Tripp created
1071814
zeta: Always include current file's outline in telemetry (#22257)
This doesn't include the outline in the prompt yet, but it does send it up via telemetry so we can use it to see whether it would have improved generated output. Release Notes: - N/A Co-authored-by: Agus <agus@zed.dev>
Thorsten Ball and Agus created
3d3d8f2
ci: Run required status checks for docs-only PRs, but exit early (#22254)
I noticed a problem with the addition of required status checks where PRs that only touched the docs wouldn't pass the status checks due to all of the checks being skipped via `paths-ignore`: <img width="950" alt="Screenshot 2024-12-19 at 11 16 38 AM" src="https://github.com/user-attachments/assets/a6fa43ee-de63-40a6-a15a-f2f3519e9db8" /> This PR aims to address this by making it so required status checks run for docs-only PRs, but exit early (before doing all of the work). Release Notes: - N/A
Marshall Bowers created