Commit log

d2b15c9 collab 0.36.1

Mikayla created

e3c9c60 Whoops (#4011)

Click to expand commit body
Fixes a spelling mistake I made in the database schema 😬

Release Notes:

- n/a

Mikayla Maki created

4d66ade Fix multi-key shortcuts (#4025)

Click to expand commit body
An old fix was ported over from gpui1, and the two fixes could not exist
side-by-side. Delete this code and let the keymap handle it

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).

Conrad Irwin created

91d3ba5 Switch to non-destructive migration

Mikayla created

4318353 Stop following when project is unshared (#4010)

Click to expand commit body
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.

[[PR Description]]

Release Notes:

- Fixed an edge-case where following didn't handle unshare correctly

Conrad Irwin created

51cc6b1 Guard against infinite loop in focus handling (#4023)

Click to expand commit body
Release Notes:

- Fix an infinite loop in focus handling

Conrad Irwin created

23fe720 Fix multi-key shortcuts

Click to expand commit body
An old fix was ported over from gpui1, and the two fixes could not exist
side-by-side. Delete this code and let the keymap handle it

Conrad Irwin created

a98d048 gpui: Make TextSystem::line_wrapper non-fallible. (#4022)

Click to expand commit body
Editors WrapMap could become desynchronised if user had an invalid font
specified in their config. Compared to Zed1, WrapMap ignored the
resolution failure instead of panicking. Now, if there's an invalid font
in the user config, we just fall back to an arbitrary default.


Release Notes:
- Fixed the editor panic in presence of invalid font name in the config
(fixes https://github.com/zed-industries/community/issues/2397)

---------

Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

Piotr Osiewicz , Conrad , and Conrad Irwin created

af790d1 Add test for new DeploySearch behaviour

Piotr Osiewicz created

634a552 project search: Do not open a new existing item in the current pane for DeploySearch

Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2395 using the first approach suggested in the original post (focus the existing search without bringing it over to a pane).

Piotr Osiewicz created

0649347 Guard against infinite loop in focus handling

Conrad Irwin created

a9fce19 Return a single Option from EventCoalescer

Joseph T. Lyons created

ac5f825 Fix bug with improperly reported environment (#4020)

Click to expand commit body
When logging the edit environment, we were logging the newest
environment being sent into the EventCoalescer on the latest activity
log, when we should've been logging the environment that was associated
with the ended period within the EventCoalescer.

Release Notes:

- N/A

Joseph T. Lyons created

5c2bbe5 Stop following on escape key press (#4021)

Click to expand commit body
Release Notes:

- Added a default keyboard shortcut to stop following by pressing the
escape key.

Julia created

06ce1af Only return environment when period ends

Joseph T. Lyons created

76955f6 Stop following on escape key press

Julia created

f4c698b Fix bug with improperly reported environment

Click to expand commit body
When logging the edit environment, we were logging the newest environment being sent into the EventCoalescer on the latest activity log, when we should've been logging the environment that was associated with the ended period within the EventCoalescer.

Joseph T. Lyons created

35db07f Show abs path matches in file finder (#4018)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2158

Release Notes:

- Make File finder to show matching file for the abs path queries

Kirill Bulatov created

8b3f256 Fix invisible symbol colors in the editor, use zed1 one (#4017)

Click to expand commit body
Release Notes:

- Improved the contrast between invisibles colors and the rest of the
text in the editor

Kirill Bulatov created

dd6e2df Show abs path matches in file finder

Kirill Bulatov created

ba83623 Fix whitespace symbol colors in the editor, use zed1 one

Click to expand commit body
co-authored-by: Marshall Bowers <marshall@zed.dev>

Kirill Bulatov and Marshall Bowers created

b342c92 Restore hover action in the editor (#4016)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2304
Deals with https://github.com/zed-industries/community/issues/2394

Release Notes:

- Fixed `editor::Hover` action (and `g h` command in Vim mode) not
working

Kirill Bulatov created

9bb50a5 Restore hover action in the editor

Kirill Bulatov created

4fe0c47 Do not split on only external directories being drag and dropped (#4015)

Click to expand commit body
Release Notes:

- Fixed drag and dropped folders opening an empty split pane

Kirill Bulatov created

75cb409 Instrument edit events (#4006)

Click to expand commit body
The goal of this PR is to send up events that contain the duration of
keyboard activity within Zed. I built the `EventCoalescer`, which gets
called called each time a key is pressed, within any environment (in the
case of this PR, within "editor" and "terminal). The" `EventCoalescer`
holds a start and end DateTime and adjusts the end instant as events
come in, until a timeout from the last event is hit.

I did my best to keep this mechanism efficient (avoiding vectors to
store moments in time, avoiding spawning timers threads, etc.), because
I know this is going to be per keystroke, but its behind a lock on the
telemetry struck, since it has to know when the environment changes, in
which point, it will automatically end the activity period, even if
there is no timeout. Because we have to have access to it from different
parts of the system, we have to go through the lock, which worried me a
bit (@mikayla-maki's intuition is that it should be fine).

As for the event, I take the time between the durations reported by the
event coalescer and send that up to zed - the indention is to
reconstruct the start and end times on zed.dev, in the same way we use
the event offset times and the time on zed.dev to get the official event
timestamp, and avoid the issue of the user having their system clocks
set wrong.

I'd really appreciate it if @nathansobo or @maxbrunsfeld could check
this out.

Release Notes:

- N/A

Joseph T. Lyons created

2e36b0b Do not split on only external directories being drag and dropped

Kirill Bulatov created

a33be89 chore: Revert asset compression

Click to expand commit body
While it does reduce the size of a binary quite significantly, it doesn't seem to matter for .dmg which runs it's own compression on top of binaries.

Piotr Osiewicz created

348bc84 Enforce no dbg! and todo! in Rust code via clippy lints in the CI job (#4005)

Click to expand commit body
Release Notes:

- N/A

Kirill Bulatov created

41bc49a Remove redundant install Rust steps

Click to expand commit body
Those were not installing Rust but configuring it via rustup, and
those configurations were done on `stable` toolchain which is not what we use (see rust-toolchain.toml)

co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

a5dd253 Properly require clippy installation, try to shuffle clippy arguments

Click to expand commit body
co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

1200f59 Try to run clippy just for a single target

Piotr Osiewicz created

0db7559 editor: extend diff hunk range for custom transform blocks. (#4012)

Click to expand commit body
Reported by Mikayla:

![image](https://github.com/zed-industries/zed/assets/24362066/b744d82e-328f-4554-becf-96f9fa92bfc8)
Note how the line with rust analyzer error does not have a git diff
hunk.
vs:

![image](https://github.com/zed-industries/zed/assets/24362066/e285af7a-b8ab-40e9-a9c6-b4ab8d6c4cd0)

Release Notes:
- N/A

Piotr Osiewicz created

6503dd5 enviroment -> environment

Mikayla created

0df4bfa Increase debug mode queue size

Joseph T. Lyons created

8a61d50 Never send an an empty set of events

Joseph T. Lyons created

f418bd9 Stop following when project is unshared

Click to expand commit body
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.

Conrad Irwin created

31689c0 Uncomment last tests (#4009)

Click to expand commit body
With this, we're done all known things that need porting. 

Release Notes:

-

Mikayla Maki created

83163a0 Reverse context arrays in child predicate test

Mikayla created

38396d4 Add remaining tests

Click to expand commit body
co-authored-by: Conrad <conrad@zed.dev>

Mikayla and Conrad created

a5ca583 Fix first few asserts

Mikayla created

bddf827 Add reminder for the future

Joseph T. Lyons created

4496946 Remove remaining port related todos (#3994)

Click to expand commit body
TODO:
- [x] Audit all TODO comments in Zed source and mark port related ones
with a !
- [x] Resolve all todos written as `todo!`

Release Notes:

- N/A

Mikayla Maki created

cb5d4ed Handle reconnects to the livekit server in which local tracks are unpublished (#3992)

Click to expand commit body
Release notes:

* Fixed a bug where network interruptions could cause audio and screen
sharing to stop working without indicating that they were stopped, and
there was no way to restart the audio stream.

Max Brunsfeld created

1932a29 Add back ime_key

Mikayla created

75fdaeb Detect when a track is unpublished due to reconnecting to livekit

Click to expand commit body
Co-authored-by: Julia <julia@zed.dev>

Max Brunsfeld and Julia created

2d1eb0c Expose a single `updates` stream from live_kit_client::Room

Click to expand commit body
Co-authored-by: Julia <julia@zed.dev>

Max Brunsfeld and Julia created

0dca67f Add --top flag to zed-local script, for making windows take up half the screen

Max Brunsfeld created

b907f37 Fix fold-related panic (#4008)

Click to expand commit body
Although it's not super clear why this fails; in zed1 we used to have a
bounds
check. Restoring the bounds check for now, but leaving a debug_assert!
in case
a local reproduction happens.

Release Notes:

- Fix a panic that happened sometimes when rendering folds

Conrad Irwin created

766a869 Fix fold-related panic

Conrad Irwin created

b4444bd Rename field in telemetry struct

Joseph T. Lyons created