08a4307
Fix failure to write to keychain because of dropping a future
Max Brunsfeld created
08a4307
Fix failure to write to keychain because of dropping a future
Max Brunsfeld created
02029c9
Suppress unused field warning
Max Brunsfeld created
43fbe6f
Temporarily avoid releasing livekit RemoteAudioTracks on drop (#4030)
This release call was added during the conversion to gpui2. I think it is probably valid, but want to remove it on the off chance that it is causing the crash that we're seeing in the `livekit.multicast` thread when leaving a room. Most likely, this is not going to fix anything, and is just introducing a small memory leak, but it is a step back to how the app worked with gpui 1.
Max Brunsfeld created
9d50697
Temporarily avoid releasing livekit RemoteAudioTracks on drop
This release call was added during the conversion to gpui2. I think it is probably valid, but want to remove it on the off chance that it is causing the crash that we're seeing in the `livekit.multicast` thread when leaving a room.
Max Brunsfeld created
8d29421
settings.json: Suggest font names for buffer_font_family
Piotr Osiewicz created
a104954
gpui: Validate font contents at load time.
During layout of EditorElement we use 'm' character from current font to calculate sizes, panicking with fonts that do not have that character (e.g. Arabic fonts). It's not really EditorElement's fault, as it assumes that the font it's dealing with is gonna have that character available. To prevent a crash, I added validation while loading a family that a given font contains the glyphs we're gonna use down the line.
Piotr Osiewicz created
8478ddb
Fix routing of leader updates from unshared projects (#4028)
Previously, leader updates in unshared projects would be sent to all followers regardless of project, as if they were not scoped to any project. - Fixes a crash that could sometimes happen when following someone if they were focused on an unshared project.
Max Brunsfeld created
258c2fd
Fix routing of leader updates from unshared projects
Previously, leader updates in unshared projects would be sent to all followers regardless of project, as if they were not scoped to any project.
Max Brunsfeld created
7c81764
Don't hold platform lock while calling user callbacks (#4027)
Inspired by a bug where using Edit -> Copy from the menu created a deadlock. Release Notes: - Fix a deadlock when copying from Edit -> Copy
Conrad Irwin created
a8b8be4
Don't hold platform lock while calling user callbacks
Inspired by a bug where using Edit -> Copy from the menu created a deadlock.
Conrad Irwin created
cb11fb6
Avoid bright green separators when displaying untitled buffers in multi-buffers (#4024)
Release notes: - Fixed unstyled excerpt separators when showing untitled buffers in multi-buffers.
Max Brunsfeld created
5885f03
Add migration information to release docs and fix scripts
Mikayla created
d2b15c9
collab 0.36.1
Mikayla created
e3c9c60
Whoops (#4011)
Fixes a spelling mistake I made in the database schema 😬 Release Notes: - n/a
Mikayla Maki created
4d66ade
Fix multi-key shortcuts (#4025)
An old fix was ported over from gpui1, and the two fixes could not exist side-by-side. Delete this code and let the keymap handle it Release Notes: - (Added|Fixed|Improved) ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
Conrad Irwin created
91d3ba5
Switch to non-destructive migration
Mikayla created
4318353
Stop following when project is unshared (#4010)
Before this change the views would continue to update in the background of the "disconnected" dialogue, which was disconcerting. [[PR Description]] Release Notes: - Fixed an edge-case where following didn't handle unshare correctly
Conrad Irwin created
51cc6b1
Guard against infinite loop in focus handling (#4023)
Release Notes: - Fix an infinite loop in focus handling
Conrad Irwin created
23fe720
Fix multi-key shortcuts
An old fix was ported over from gpui1, and the two fixes could not exist side-by-side. Delete this code and let the keymap handle it
Conrad Irwin created
5feae86
Avoid bright green separators when displaying untitled buffers in multi-buffers
Max Brunsfeld created
a98d048
gpui: Make TextSystem::line_wrapper non-fallible. (#4022)
Editors WrapMap could become desynchronised if user had an invalid font specified in their config. Compared to Zed1, WrapMap ignored the resolution failure instead of panicking. Now, if there's an invalid font in the user config, we just fall back to an arbitrary default. Release Notes: - Fixed the editor panic in presence of invalid font name in the config (fixes https://github.com/zed-industries/community/issues/2397) --------- Co-authored-by: Conrad <conrad@zed.dev> Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Piotr Osiewicz , Conrad , and Conrad Irwin created
af790d1
Add test for new DeploySearch behaviour
Piotr Osiewicz created
634a552
project search: Do not open a new existing item in the current pane for DeploySearch
Fixes https://github.com/zed-industries/community/issues/2395 using the first approach suggested in the original post (focus the existing search without bringing it over to a pane).
Piotr Osiewicz created
0649347
Guard against infinite loop in focus handling
Conrad Irwin created
a9fce19
Return a single Option from EventCoalescer
Joseph T. Lyons created
11b433d
Move back to sorting entries in the depth map as we insert them
Antonio Scandurra created
ac5f825
Fix bug with improperly reported environment (#4020)
When logging the edit environment, we were logging the newest environment being sent into the EventCoalescer on the latest activity log, when we should've been logging the environment that was associated with the ended period within the EventCoalescer. Release Notes: - N/A
Joseph T. Lyons created
5c2bbe5
Stop following on escape key press (#4021)
Release Notes: - Added a default keyboard shortcut to stop following by pressing the escape key.
Julia created
06ce1af
Only return environment when period ends
Joseph T. Lyons created
76955f6
Stop following on escape key press
Julia created
f4c698b
Fix bug with improperly reported environment
When logging the edit environment, we were logging the newest environment being sent into the EventCoalescer on the latest activity log, when we should've been logging the environment that was associated with the ended period within the EventCoalescer.
Joseph T. Lyons created
101cedb
:lipstick:
Antonio Scandurra created
35db07f
Show abs path matches in file finder (#4018)
Deals with https://github.com/zed-industries/community/issues/2158 Release Notes: - Make File finder to show matching file for the abs path queries
Kirill Bulatov created
cbbba41
Reuse line layouts when reusing view
Antonio Scandurra created
8b3f256
Fix invisible symbol colors in the editor, use zed1 one (#4017)
Release Notes: - Improved the contrast between invisibles colors and the rest of the text in the editor
Kirill Bulatov created
dd6e2df
Show abs path matches in file finder
Kirill Bulatov created
ba83623
Fix whitespace symbol colors in the editor, use zed1 one
co-authored-by: Marshall Bowers <marshall@zed.dev>
Kirill Bulatov and Marshall Bowers created
b342c92
Restore hover action in the editor (#4016)
Deals with https://github.com/zed-industries/community/issues/2304 Deals with https://github.com/zed-industries/community/issues/2394 Release Notes: - Fixed `editor::Hover` action (and `g h` command in Vim mode) not working
Kirill Bulatov created
9bb50a5
Restore hover action in the editor
Kirill Bulatov created
18eaefd
Reuse cursor style when reusing a view tree
Antonio Scandurra created
4fe0c47
Do not split on only external directories being drag and dropped (#4015)
Release Notes: - Fixed drag and dropped folders opening an empty split pane
Kirill Bulatov created
75cb409
Instrument edit events (#4006)
The goal of this PR is to send up events that contain the duration of keyboard activity within Zed. I built the `EventCoalescer`, which gets called called each time a key is pressed, within any environment (in the case of this PR, within "editor" and "terminal). The" `EventCoalescer` holds a start and end DateTime and adjusts the end instant as events come in, until a timeout from the last event is hit. I did my best to keep this mechanism efficient (avoiding vectors to store moments in time, avoiding spawning timers threads, etc.), because I know this is going to be per keystroke, but its behind a lock on the telemetry struck, since it has to know when the environment changes, in which point, it will automatically end the activity period, even if there is no timeout. Because we have to have access to it from different parts of the system, we have to go through the lock, which worried me a bit (@mikayla-maki's intuition is that it should be fine). As for the event, I take the time between the durations reported by the event coalescer and send that up to zed - the indention is to reconstruct the start and end times on zed.dev, in the same way we use the event offset times and the time on zed.dev to get the official event timestamp, and avoid the issue of the user having their system clocks set wrong. I'd really appreciate it if @nathansobo or @maxbrunsfeld could check this out. Release Notes: - N/A
Joseph T. Lyons created
2e36b0b
Do not split on only external directories being drag and dropped
Kirill Bulatov created
a33be89
chore: Revert asset compression
While it does reduce the size of a binary quite significantly, it doesn't seem to matter for .dmg which runs it's own compression on top of binaries.
Piotr Osiewicz created
348bc84
Enforce no dbg! and todo! in Rust code via clippy lints in the CI job (#4005)
Release Notes: - N/A
Kirill Bulatov created
50ccdf5
Reuse input handler when reusing a view tree
Antonio Scandurra created
41bc49a
Remove redundant install Rust steps
Those were not installing Rust but configuring it via rustup, and those configurations were done on `stable` toolchain which is not what we use (see rust-toolchain.toml) co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov and Piotr created
a5dd253
Properly require clippy installation, try to shuffle clippy arguments
co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov and Piotr created
d088ace
Explicitly push a node in the dispatch tree when painting a new view
Antonio Scandurra created
1200f59
Try to run clippy just for a single target
Piotr Osiewicz created