An old fix was ported over from gpui1, and the two fixes could not exist
side-by-side. Delete this code and let the keymap handle it
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
4318353
Stop following when project is unshared (#4010)
Click to expand commit body
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.
[[PR Description]]
Release Notes:
- Fixed an edge-case where following didn't handle unshare correctly
Conrad Irwin
created
51cc6b1
Guard against infinite loop in focus handling (#4023)
Click to expand commit body
Release Notes:
- Fix an infinite loop in focus handling
An old fix was ported over from gpui1, and the two fixes could not exist
side-by-side. Delete this code and let the keymap handle it
Conrad Irwin
created
5feae86
Avoid bright green separators when displaying untitled buffers in multi-buffers
Max Brunsfeld
created
a98d048
gpui: Make TextSystem::line_wrapper non-fallible. (#4022)
Click to expand commit body
Editors WrapMap could become desynchronised if user had an invalid font
specified in their config. Compared to Zed1, WrapMap ignored the
resolution failure instead of panicking. Now, if there's an invalid font
in the user config, we just fall back to an arbitrary default.
Release Notes:
- Fixed the editor panic in presence of invalid font name in the config
(fixes https://github.com/zed-industries/community/issues/2397)
---------
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Piotr Osiewicz
,
Conrad
, and
Conrad Irwin
created
634a552
project search: Do not open a new existing item in the current pane for DeploySearch
Click to expand commit body
Fixes https://github.com/zed-industries/community/issues/2395 using the first approach suggested in the original post (focus the existing search without bringing it over to a pane).
Piotr Osiewicz
created
0649347
Guard against infinite loop in focus handling
Conrad Irwin
created
a9fce19
Return a single Option from EventCoalescer
Joseph T. Lyons
created
11b433d
Move back to sorting entries in the depth map as we insert them
Antonio Scandurra
created
ac5f825
Fix bug with improperly reported environment (#4020)
Click to expand commit body
When logging the edit environment, we were logging the newest
environment being sent into the EventCoalescer on the latest activity
log, when we should've been logging the environment that was associated
with the ended period within the EventCoalescer.
Release Notes:
- N/A
Joseph T. Lyons
created
5c2bbe5
Stop following on escape key press (#4021)
Click to expand commit body
Release Notes:
- Added a default keyboard shortcut to stop following by pressing the
escape key.
f4c698b
Fix bug with improperly reported environment
Click to expand commit body
When logging the edit environment, we were logging the newest environment being sent into the EventCoalescer on the latest activity log, when we should've been logging the environment that was associated with the ended period within the EventCoalescer.
b342c92
Restore hover action in the editor (#4016)
Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2304
Deals with https://github.com/zed-industries/community/issues/2394
Release Notes:
- Fixed `editor::Hover` action (and `g h` command in Vim mode) not
working
The goal of this PR is to send up events that contain the duration of
keyboard activity within Zed. I built the `EventCoalescer`, which gets
called called each time a key is pressed, within any environment (in the
case of this PR, within "editor" and "terminal). The" `EventCoalescer`
holds a start and end DateTime and adjusts the end instant as events
come in, until a timeout from the last event is hit.
I did my best to keep this mechanism efficient (avoiding vectors to
store moments in time, avoiding spawning timers threads, etc.), because
I know this is going to be per keystroke, but its behind a lock on the
telemetry struck, since it has to know when the environment changes, in
which point, it will automatically end the activity period, even if
there is no timeout. Because we have to have access to it from different
parts of the system, we have to go through the lock, which worried me a
bit (@mikayla-maki's intuition is that it should be fine).
As for the event, I take the time between the durations reported by the
event coalescer and send that up to zed - the indention is to
reconstruct the start and end times on zed.dev, in the same way we use
the event offset times and the time on zed.dev to get the official event
timestamp, and avoid the issue of the user having their system clocks
set wrong.
I'd really appreciate it if @nathansobo or @maxbrunsfeld could check
this out.
Release Notes:
- N/A
Joseph T. Lyons
created
2e36b0b
Do not split on only external directories being drag and dropped
Those were not installing Rust but configuring it via rustup, and
those configurations were done on `stable` toolchain which is not what we use (see rust-toolchain.toml)
co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov
and
Piotr
created
a5dd253
Properly require clippy installation, try to shuffle clippy arguments
Click to expand commit body
co-authored-by: Piotr <piotr@zed.dev>
Kirill Bulatov
and
Piotr
created
d088ace
Explicitly push a node in the dispatch tree when painting a new view
Antonio Scandurra
created
1200f59
Try to run clippy just for a single target
Also, it looks like using a u64 directly doesn't work well with Metal
shaders, so we unpack the u64 into two u32s.
Antonio Scandurra
created
0db7559
editor: extend diff hunk range for custom transform blocks. (#4012)
Click to expand commit body
Reported by Mikayla:

Note how the line with rust analyzer error does not have a git diff
hunk.
vs:

Release Notes:
- N/A