5a82dc2
Emit the WorktreeUpdatedEntries event for all projects, not just local (#8963)
Click to expand commit body
Fixes a regression introduced in
https://github.com/zed-industries/zed/pull/8846 (which hasn't yet been
released), in which the project panel didn't update correctly for remote
projects when collaborating.
Release Notes:
- N/A
Thankfully this one is a simple, single change that also prevents
overflow in the `abs()`
Kirpal Grewal
created
2f15676
Update App Menus to add `...` for some modal action menu, and group menu items by type. (#8951)
Click to expand commit body
Release Notes:
- Improved App Menu, add `...` for modal action menu, and group menu
items by type.
In macOS and Windows, the `...` suffix of menu item, is means that will
open a dialog.
Jason Lee
created
4a60326
Remove workspace border, avoid the main window having double borders (#8922)
Click to expand commit body
Release Notes:
- Fixed main window border, avoid double borders.
## Diff (Left is Before, Right is After)


Reference to Safari:

## More Theme tests




Jason Lee
created
567fee4
Update `Project search` to `Project Search`. (#8943)
Click to expand commit body
Release notes:
- N/A
Jason Lee
created
6036830
Throttle the sending of UpdateFollowers messages (#8918)
Click to expand commit body
## Problem
We're trying to figure out why we sometimes see high latency when
collaborating, even though the collab server logs indicate that messages
are not taking long to process.
We think that high volumes of certain types of messages, including
`UpdateFollowers` may cause a lot of messages to queue up, causing
delays before collab sees certain messages.
## Fix
This PR reduces the number of `UpdateFollowers` messages that clients
send to collab when scrolling around or moving the cursor, using a
time-based throttle.
The downside of this change is that scrolling will not be as smooth when
following someone. The advantage is that it will be much easier to keep
up with the stream of updates, since they will be sent much less
frequently.
## Release Notes:
- Fixed slowness that could occur when collaborating due to excessive
messages being sent to support following.
---------
Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Thorsten <thorsten@zed.dev>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Max Brunsfeld
,
Nathan
,
Conrad
,
Antonio Scandurra
,
Thorsten
, and
Thorsten Ball
created
c8383e3
Use a string for ZED_LOAD_BALANCER_SIZE_UNIT in k8s template
Click to expand commit body
Co-Authored-By: Thorsten <thorsten@zed.dev>
Antonio Scandurra
and
Thorsten
created
334c3c6
Use a string for ZED_LOAD_BALANCER_SIZE_UNIT
Click to expand commit body
Co-Authored-By: Thorsten <thorsten@zed.dev>
Antonio Scandurra
and
Thorsten
created
e3a7192
Give a name to load balancers and increase node count for production (#8939)
Before this change Kubernetes would send a SIGTERM to the old server
before the new one was ready. Now it will wait.
From my reading it seems like startupProbe should not be necessary if we
have a
readinessProbe; but from testing it seems like without startupProbe we
still
drop requests when using `rollout restart`
Release Notes:
- Fixed connectivity issues during Zed deploys.
Conrad Irwin
created
01e5e42
Fix numeric sign of queue duration in logs
Max Brunsfeld
created
4de8068
Revert "Install perf on collab image (#8910)"
Click to expand commit body
Keep the removal of the collab resource requests.
This reverts commit ce6bde5a242909834341998a49eeb7f95191ff75.
lint for `unnecessary_to_owned` and fix the sole violation in the
codebase
Kirpal Grewal
created
b68a277
Fix tracing subscriber after introducing Tokio-console (#8907)
Click to expand commit body
We've also upgraded `Axum` in order to avoid having two versions of that
library in Collab (one due to Tokio-console).
Release Notes:
- N/A
---------
Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld
and
Conrad
created
703c965
Always resolve code action if needed (#8904)
Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/8874 and
https://github.com/zed-industries/zed/pull/7635
Closes https://github.com/zed-industries/zed/issues/7609
* mentions all `lsp::CodeActions` properties in the Zed client resolve
capabilities to remove more json out of general actions request
potentially
* removes odd `CodeActions.data` field checks, as that field is opaque
and is intended to store data, needed by the langserver to resolve this
code action
* if any `CodeAction` lacks either `command` or `edits` fields, tries to
resolve the action
This all effectively causes Zed to always fire an action resolve
request, since we update actions list (replacing the resolved actions
with the new, unresolved ones) via `refresh_code_actions`
https://github.com/zed-industries/zed/blob/9e66d48ccd3bb87ee97aec4e63484dc8b78e45ac/crates/editor/src/editor.rs#L3650
that is being called on selections change and the actions menu open.
Yet, we do not query the resolve until the action is either applied
(selected in the list), or called for formatting, so it seems to be fine
to resolve them always, as it's not a frequent operation such as
reacting to every keystroke.
Release Notes:
- Fixed certain code actions not being resolved properly ([7609](https://github.com/zed-industries/zed/issues/7609))
---------
Co-authored-by: Derrick Laird <swampdonk@gmail.com>
This PR enables the
[`clippy::implied_bounds_in_impls`](https://rust-lang.github.io/rust-clippy/master/index.html#/implied_bounds_in_impls)
rule and fixes the outstanding violations.
Release Notes:
- N/A
This PR enables the
[`clippy::cmp_owned`](https://rust-lang.github.io/rust-clippy/master/index.html#/cmp_owned)
rule and fixes the outstanding violations.
Release Notes:
- N/A
Marshall Bowers
created
d98b61e
Improve wording on recent projects placeholder instructions
Release Notes:
- Added tokio-console in production
Conrad Irwin
created
9a2ed4b
Windows: use folders under AppData (#8828)
Click to expand commit body
To be honest, I am not sure how to use these directories. But since it
is difficult to change these later, if we are going to change them, I
think it is time to do.
Release Notes:
- N/A
This PR enables the
[`clippy::borrow_deref_ref`](https://rust-lang.github.io/rust-clippy/master/index.html#/borrow_deref_ref)
rule and fixes the outstanding violations.
Release Notes:
- N/A
Marshall Bowers
created
a25edcc
Add libxcb-devel build dep to void linux script (#8872)
Click to expand commit body
Added missing libxcb-devel to build dependency script for void-linux.
Owen Law
created
22fe039
Move Clippy configuration to the workspace level (#8891)
Click to expand commit body
This PR moves the Clippy configuration up to the workspace level.
We're using the [`lints`
table](https://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table)
to configure the Clippy ruleset in the workspace's `Cargo.toml`.
Each crate in the workspace now has the following in their own
`Cargo.toml` to inherit the lints from the workspace:
```toml
[lints]
workspace = true
```
This allows for configuring rust-analyzer to show Clippy lints in the
editor by using the following configuration in your Zed `settings.json`:
```json
{
"lsp": {
"rust-analyzer": {
"initialization_options": {
"check": {
"command": "clippy"
}
}
}
}
```
Release Notes:
- N/A
Marshall Bowers
created
52f750b
Update blade to latest: work around Intel+NVidia driver bug (#8811)
Click to expand commit body
Picks up https://github.com/kvark/blade/pull/92
Should unblock some of the unhappy users.
Upstream bug - https://gitlab.freedesktop.org/mesa/mesa/-/issues/4688
Release Notes:
- N/A
Windows mouse and keyboard working! I also tweaked the message loop so
that it didn't get stuck. The peek message loop was almost never
returning for me during testing.
Release Notes:
- Added windows mouse and keyboard support

Ezekiel Warren
created
7c9f680
Request more resources for collab pods on Kubernetes (#8890)
Click to expand commit body
Worried that if we don't do this, they don't give us enough. We're
maxing out the pod's CPU but the node is barely sweating.
Release Notes:
- N/A
Nathan Sobo
created
2b8b913
Use correct worktree when getting permalink to line (#8888)
Click to expand commit body
Previously this code would call `project.visible_worktrees(cx).next`
which might not necessarily return the worktree matching the currently
open file.
What this change does is it adds `get_repo` method on `Project` that
allows us to get the `GitRepository` for the current buffer.
Release Notes:
- Fixed `open permalink to line` not working when multiple folders are
added to the project.
Co-authored-by: Mikayla <mikayla@zed.dev>
Thorsten Ball
and
Mikayla
created
d286c56
Optimize rustybuzz and ttf-parser in Dev (#8873)
Click to expand commit body
This PR improves the `draw()` time from hundreds to about 30ms, so
roughly 10x.
It makes Zed quite usable in Dev profile.
Release Notes:
- N/A
Dzmitry Malyshau
created
0b34b1d
Fix first/last item margin on scroll (#8880)
Click to expand commit body

Before:
https://github.com/zed-industries/zed/assets/5518/f7a4563a-504a-4a41-bfd4-21e9439cd02b
After:
https://github.com/zed-industries/zed/assets/5518/0ba41527-46fd-404f-8207-1b8c5cf37434
Release Notes:
- Fixed first and last item margin when scroll view has padding
Jason Lee
created
537d925
Backport `code_actions_on_format` docs and update them (#8881)
Click to expand commit body
Release Notes:
- N/A
Thorsten Ball
created
fae5e83
Fix all Picker Item cursor to use `Pointer`. (#8877)
Click to expand commit body
Before:
https://github.com/zed-industries/zed/assets/5518/84874858-7847-4fa4-b7a3-41ecc65a2f7d
After:
https://github.com/zed-industries/zed/assets/5518/d395ea96-aa26-4de1-8bfc-73cc43ee75cf
Release Notes:
- Made picker items to use `Pointer` cursor style
Jason Lee
created
6a268e9
Improve VCS Menu header top margin. (#8879)
Click to expand commit body
## Before


## After


Release Notes:
- Improve VCS Menu header top margin, and use `TextMuted` color for
matched count label.
Jason Lee
created
4b2e774
Fix license generation and Closure LSP repo link (#8876)
Click to expand commit body
Release Notes:
- N/A
Kirill Bulatov
created
e0c66b3
Fix panic in enclosing bracket ranges (#8870)
Click to expand commit body
This function was operating in the wrong co-ordinate space (c.f. #8081)
Release Notes:
- Fixed a panic on `ctrl-m` in a multibuffer
- **Allow joining a hosted project**
You can't yet do anything in a hosted project, but you can join it and
look how empty it is.
Release Notes:
- N/A
Conrad Irwin
created
4167c66
macOS: Fix center window with fixed bounds size (#8475)
Click to expand commit body
This PR fixes window showing up in the center of the monitor when
`center: true` option is provided.
The idea is to set the `window_wize` when creating the `window` using
`native_window.initWithContentRect_styleMask_backing_defer_screen_()`
Before:
<img width="851" alt="SCR-20240227-qokf"
src="https://github.com/zed-industries/zed/assets/20229808/27494966-2e97-4771-8837-ccb6658ced78">
After:
<img width="1132" alt="SCR-20240227-qlmg"
src="https://github.com/zed-industries/zed/assets/20229808/439568da-d380-4331-8d19-cd501f211c4c">
Release Notes:
- N/A
Quadri A. Adekunle
created
d223fe4
vim: Add support for `ap` and `ip` paragraph text objects (#7687)
Click to expand commit body
This PR adds support for `ap`/`ip` text objects in Vim mode and allows
users to perform paragraph-based operations.
Cases where compatibility with Neovim's behavior is checked, cases where
there are known differences in behavior with Neovim (cases where the
landing position is other than the beginning of the line), and cases
where the Neovim behavior in the test suite seems strange are separated
in the test code so that they can be identified.
Release Notes:
- Added support for `ap` and `ip` paragraph text objects in Vim mode
([#7359](https://github.com/zed-industries/zed/issues/7359)).
`z.` is similar to zz but moves the cursor to the first non-blank
character.
From the documentation:
```
z. Redraw, line [count] at center of window (default cursor line). Put cursor at first non-blank in the line.
zz Like "z.", but leave the cursor in the same column.
```
Release Notes:
- Support the `z.` vim keybinding: Center cursor in window and put
cursor at first non-blank
snorkypie
created
f53823c
Remove release channel from Zed URLs (#8863)
Click to expand commit body
Also adds a new command `cli: Register Zed Scheme` that will cause URLs
to be opened in the current zed version, and we call this implicitly if
you install the CLI
Also add some status reporting to install cli
Fixes: #8857
Release Notes:
- Added success/error reporting to `cli: Install Cli`
([#8857](https://github.com/zed-industries/zed/issues/8857)).
- Removed `zed-{preview,nightly,dev}:` url schemes (used by channel
links)
- Added `cli: Register Zed Scheme` to control which zed handles the
`zed://` scheme (defaults to the most recently installed, or
the version that you last used `cli: Install Cli` with)
This PR supplements tasks with additional environment variables; ideally
we'll be able to write a task like:
`cargo test -p $ZED_CURRENT_PACKAGE -- $ZED_CURRENT_FUNCTION`
- [x] Flesh out multibuffer interactions
- [x] Add ZED_SYMBOL detection based on tree-sitter queries
- [ ] Add release note and demo
- [x] Figure out a solution for rerun dilemma - should `task: rerun`
reevaluate contexts for tasks?
This PR introduced the following variables:
- ZED_COLUMN - current line column
- ZED_ROW - current line row
and the following, which are available for buffers with associated
files:
- ZED_WORKTREE_ROOT - absolute path to the root of the current worktree.
- ZED_FILE - absolute path to the file
- ZED_SYMBOL - currently selected symbol; should match the last symbol
shown in a symbol breadcrumb (e.g. `mod tests > fn test_task_contexts`
should be equal to ZED_SYMBOL of `test_task_contexts`). Note that this
isn't necessarily a test function or a function at all.
Also, you can use them in `cwd` field of definitions (note though that
we're using https://docs.rs/subst/latest/subst/#features for that, so
don't expect a full shell functionality to work); the syntax should
match up with your typical Unix shell.
Release Notes:
- Added task contexts, which are additional environment variables set by
Zed for task execution; task content is dependent on the state of the
editor at the time the task is spawned.
---------
Co-authored-by: Anthony <anthonyeid7@protonmail.com>