Commit log

7ee7ef5 zed 0.126.3

Conrad Irwin created

9a3111c Fix segfault in "install:cli" when app is not yet installed (cherry-pick #9427) (#9430)

Click to expand commit body
Cherry-picked Fix segfault in "install:cli" when app is not yet
installed (#9427)

Release Notes:

- Fixed a panic running `cli: Install` or `cli: Register Zed Scheme`
before installing the app.

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

gcp-cherry-pick-bot[bot] and Conrad Irwin created

e6d5dbd Fix panic loading language queries (#9506)

Click to expand commit body
Release Notes:

- Fixed a panic when loading a language with queries but no grammar

Conrad Irwin created

43f00b2 Don't panic on missing mtime (cherry-pick #9513) (#9515)

Click to expand commit body
Cherry-picked Don't panic on missing mtime (#9513)

This is expected as of zed 0.128 when a new unsaved file is created

Release Notes:

- Fixed a panic when collaborating with newer zed versions

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

gcp-cherry-pick-bot[bot] and Conrad Irwin created

150e021 v0.126.x stable

Joseph T. Lyons created

2ecc6e1 Omit `.git` worktree indexing (#9281)

Click to expand commit body
Closes https://github.com/zed-industries/zed/issues/9174

Release Notes:

- Fixed panics when `.git` was opened as a Zed worktree
([9174](https://github.com/zed-industries/zed/issues/9174))

Kirill Bulatov created

665e09b Fix segfault when dropping MacWindow (cherry-pick #9267) (#9269)

Click to expand commit body
Cherry-picked Fix segfault when dropping MacWindow (#9267)

This avoids calling `window.setDelegate(nil)` when the window was
already closed.

Release Notes:

- Fixed a segfault that could show up when closing windows.

Co-authored-by: Antonio <antonio@zed.dev>

Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Co-authored-by: Antonio <antonio@zed.dev>

gcp-cherry-pick-bot[bot] , Thorsten Ball , and Antonio created

60fa3bc Show only prefix/suffix if there are more than 12 breadcrumbs (cherry-pick #9220) (#9227)

Click to expand commit body
Cherry-picked Show only prefix/suffix if there are more than 12
breadcrumbs (#9220)

Fixes https://github.com/zed-industries/zed/issues/9079

This should fix the arena panic we were observing. I saw that breadcrumb
rendering was on the stack trace for some of the panics, so my suspicion
is that it's being caused by some people navigating into deeply nested
files.

Release Notes:

- Fixed a panic that could occur when displaying too many breadcrumbs.
([#9079](https://github.com/zed-industries/zed/issues/9079))

Co-authored-by: Antonio Scandurra <me@as-cii.com>

gcp-cherry-pick-bot[bot] and Antonio Scandurra created

2423c60 zed 0.126.2

Thorsten Ball created

22a7eb6 Fix broken ESLint by pinning to `2.2.20-Insiders` release (#9215)

Click to expand commit body
This fixes #9213 by pinning ESLint to `2.2.20-Insiders` which is the
last known version to work well with Zed.

Once this fix is out, we can take a closer look at upgrading to 2.4.x or
even 3.x once that's out of prerelease.

Release Notes:

- Fixed ESLint integration being broken after Mar 7 2024 due to ESLint
3.0.1 alpha release being pushed.
([#9213](https://github.com/zed-industries/zed/issues/9213)).

Thorsten Ball created

bf8974c v0.126.x: Reload extensions if manifest parsing fails (#9186)

Click to expand commit body
This PR fixes an issue where a malformed extension manifest could cause
the extensions to not be loaded.

We now default to reloading, and only skip reloading if we know it's
safe to do so.

This is an adaption of the change we made here:
https://github.com/zed-industries/zed/pull/8781/commits/ab8a9f9a6f3929fdff3da91149809efd0f53d8b7

Release Notes:

- N/A

Marshall Bowers created

5e7f554 Fix panic in layout_line when Y coordinate is too high (cherry-pick #9052) (#9075)

Click to expand commit body
Cherry-picked Fix panic in layout_line when Y coordinate is too high
(#9052)

Release Notes:

- N/A

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

gcp-cherry-pick-bot[bot] and Conrad Irwin created

1d3fe83 try to fix build

Conrad Irwin created

6d9e40c zed 0.126.1

Conrad Irwin created

8845e68 Fix panic in open urls (cherry-pick #9032) (#9034)

Click to expand commit body
Cherry-picked Fix panic in open urls (#9032)

Co-Authored-By: Nathan <nathan@zed.dev>

Release Notes:

- N/A

Co-authored-by: Nathan <nathan@zed.dev>

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Nathan <nathan@zed.dev>

gcp-cherry-pick-bot[bot] , Conrad Irwin , and Nathan created

e0034ec Make anchor_in_excerpt Optional (cherry-pick #8975) (#8979)

Click to expand commit body
Cherry-picked Make anchor_in_excerpt Optional (#8975)

We were seeing panics due to callers assuming they had valid
excerpt_ids, but that cannot easily be guaranteed across await points as
anyone may remove an excerpt.

Release Notes:

- Fixed a panic when hovering in a multibuffer

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>

gcp-cherry-pick-bot[bot] and Conrad Irwin created

5a82dc2 Emit the WorktreeUpdatedEntries event for all projects, not just local (#8963)

Click to expand commit body
Fixes a regression introduced in
https://github.com/zed-industries/zed/pull/8846 (which hasn't yet been
released), in which the project panel didn't update correctly for remote
projects when collaborating.

Release Notes:

- N/A

Max Brunsfeld created

afed6f4 v0.126.x preview

Joseph T. Lyons created

563c4db Install perf tools in production containers (#8957)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

8eb0239 Remove console-subscriber (#8955)

Click to expand commit body
It doubles CPU and RAM usage for not really enough benefit

Release Notes:

- N/A

Conrad Irwin created

deb86a1 Fix ./script/symbolicate on Preview crashes (#8956)

Click to expand commit body
Release Notes:

- N/A

Conrad Irwin created

b622dcb Enable `clippy::cast_abs_to_unsigned` (#8912)

Click to expand commit body
Thankfully this one is a simple, single change that also prevents
overflow in the `abs()`

Kirpal Grewal created

2f15676 Update App Menus to add `...` for some modal action menu, and group menu items by type. (#8951)

Click to expand commit body
Release Notes:

- Improved App Menu, add `...` for modal action menu, and group menu
items by type.

In macOS and Windows, the `...` suffix of menu item, is means that will
open a dialog.

Jason Lee created

4a60326 Remove workspace border, avoid the main window having double borders (#8922)

Click to expand commit body
Release Notes:

- Fixed main window border, avoid double borders.



## Diff (Left is Before, Right is After)


![SCR-20240306-g2v](https://github.com/zed-industries/zed/assets/5518/b13bab55-9d74-4181-ae43-e338bb6f7112)

![SCR-20240306-g0x](https://github.com/zed-industries/zed/assets/5518/af9d4190-a974-4c26-8466-dce1c78c3f31)




Reference to Safari:

![SCR-20240306-ejo](https://github.com/zed-industries/zed/assets/5518/14c41898-8218-4bec-8574-8915a7186926)


## More Theme tests

![SCR-20240306-g0d](https://github.com/zed-industries/zed/assets/5518/8938671e-bc7c-4a6a-8c06-0992beb92bb1)

![SCR-20240306-g0j](https://github.com/zed-industries/zed/assets/5518/73a68663-70f5-4f83-aea0-2079236079e7)

![SCR-20240306-g0q](https://github.com/zed-industries/zed/assets/5518/0a2b4905-3dd1-4081-b538-a78728470004)



![SCR-20240306-fu9](https://github.com/zed-industries/zed/assets/5518/dd3a9e2c-ea28-46c6-a993-047dae8b2d8f)

Jason Lee created

567fee4 Update `Project search` to `Project Search`. (#8943)

Click to expand commit body
Release notes:

- N/A

Jason Lee created

6036830 Throttle the sending of UpdateFollowers messages (#8918)

Click to expand commit body
## Problem

We're trying to figure out why we sometimes see high latency when
collaborating, even though the collab server logs indicate that messages
are not taking long to process.

We think that high volumes of certain types of messages, including
`UpdateFollowers` may cause a lot of messages to queue up, causing
delays before collab sees certain messages.

## Fix

This PR reduces the number of `UpdateFollowers` messages that clients
send to collab when scrolling around or moving the cursor, using a
time-based throttle.

The downside of this change is that scrolling will not be as smooth when
following someone. The advantage is that it will be much easier to keep
up with the stream of updates, since they will be sent much less
frequently.

## Release Notes:

- Fixed slowness that could occur when collaborating due to excessive
messages being sent to support following.

---------

Co-authored-by: Nathan <nathan@zed.dev>
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Antonio Scandurra <me@as-cii.com>
Co-authored-by: Thorsten <thorsten@zed.dev>
Co-authored-by: Thorsten Ball <mrnugget@gmail.com>

Max Brunsfeld , Nathan , Conrad , Antonio Scandurra , Thorsten , and Thorsten Ball created

c8383e3 Use a string for ZED_LOAD_BALANCER_SIZE_UNIT in k8s template

Click to expand commit body
Co-Authored-By: Thorsten <thorsten@zed.dev>

Antonio Scandurra and Thorsten created

334c3c6 Use a string for ZED_LOAD_BALANCER_SIZE_UNIT

Click to expand commit body
Co-Authored-By: Thorsten <thorsten@zed.dev>

Antonio Scandurra and Thorsten created

e3a7192 Give a name to load balancers and increase node count for production (#8939)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Thorsten <thorsten@zed.dev>

Antonio Scandurra and Thorsten created

6327f3c Modify the link to the latest (#8925)

Click to expand commit body
Fixed the link for Vue LSP server

Release Notes:

- N/A

Hans created

c58422c Fix YAML indentation

Conrad Irwin created

6d53846 0-downtime collab deploys? (#8926)

Click to expand commit body
Before this change Kubernetes would send a SIGTERM to the old server
before the new one was ready. Now it will wait.

From my reading it seems like startupProbe should not be necessary if we
have a
readinessProbe; but from testing it seems like without startupProbe we
still
drop requests when using `rollout restart`

Release Notes:

- Fixed connectivity issues during Zed deploys.

Conrad Irwin created

01e5e42 Fix numeric sign of queue duration in logs

Max Brunsfeld created

4de8068 Revert "Install perf on collab image (#8910)"

Click to expand commit body
Keep the removal of the collab resource requests.

This reverts commit ce6bde5a242909834341998a49eeb7f95191ff75.

Max Brunsfeld created

ce6bde5 Install perf on collab image (#8910)

Click to expand commit body
Release Notes:

- N/A

---------

Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

35c516f Log the time incoming RPC messages were queued (#8909)

Click to expand commit body
Release Notes:

- N/A

Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

bca98ca Enable `clippy::unnecessary_to_owned` (#8908)

Click to expand commit body
lint for `unnecessary_to_owned` and fix the sole violation in the
codebase

Kirpal Grewal created

b68a277 Fix tracing subscriber after introducing Tokio-console (#8907)

Click to expand commit body
We've also upgraded `Axum` in order to avoid having two versions of that
library in Collab (one due to Tokio-console).

Release Notes:

- N/A

---------

Co-authored-by: Conrad <conrad@zed.dev>

Max Brunsfeld and Conrad created

703c965 Always resolve code action if needed (#8904)

Click to expand commit body
Follow-up of https://github.com/zed-industries/zed/pull/8874 and
https://github.com/zed-industries/zed/pull/7635
Closes https://github.com/zed-industries/zed/issues/7609

* mentions all `lsp::CodeActions` properties in the Zed client resolve
capabilities to remove more json out of general actions request
potentially
* removes odd `CodeActions.data` field checks, as that field is opaque
and is intended to store data, needed by the langserver to resolve this
code action
* if any `CodeAction` lacks either `command` or `edits` fields, tries to
resolve the action

This all effectively causes Zed to always fire an action resolve
request, since we update actions list (replacing the resolved actions
with the new, unresolved ones) via `refresh_code_actions`

https://github.com/zed-industries/zed/blob/9e66d48ccd3bb87ee97aec4e63484dc8b78e45ac/crates/editor/src/editor.rs#L3650
that is being called on selections change and the actions menu open.

Yet, we do not query the resolve until the action is either applied
(selected in the list), or called for formatting, so it seems to be fine
to resolve them always, as it's not a frequent operation such as
reacting to every keystroke.


Release Notes:

- Fixed certain code actions not being resolved properly ([7609](https://github.com/zed-industries/zed/issues/7609))

---------

Co-authored-by: Derrick Laird <swampdonk@gmail.com>

Kirill Bulatov and Derrick Laird created

addfcde Enable `clippy::implied_bounds_in_impls` (#8906)

Click to expand commit body
This PR enables the
[`clippy::implied_bounds_in_impls`](https://rust-lang.github.io/rust-clippy/master/index.html#/implied_bounds_in_impls)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Marshall Bowers created

d112bcf Fix project subscription order (#8900)

Click to expand commit body
Co-Authored-By: Antonio <as-cii@zed.dev>

Release Notes:

- Fixed a bug that prevents project joining

Co-authored-by: Antonio <as-cii@zed.dev>

Conrad Irwin and Antonio created

9e66d48 Enable `clippy::cmp_owned` (#8899)

Click to expand commit body
This PR enables the
[`clippy::cmp_owned`](https://rust-lang.github.io/rust-clippy/master/index.html#/cmp_owned)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Marshall Bowers created

d98b61e Improve wording on recent projects placeholder instructions

Joseph T. Lyons created

ad0c573 Update config.yml

Joseph T. Lyons created

cfffa29 Enable tokio-console (#8897)

Click to expand commit body
Release Notes:

- Added tokio-console in production

Conrad Irwin created

9a2ed4b Windows: use folders under AppData (#8828)

Click to expand commit body
To be honest, I am not sure how to use these directories. But since it
is difficult to change these later, if we are going to change them, I
think it is time to do.

Release Notes:

- N/A

白山風露 created

b6af393 Enable `clippy::borrow_deref_ref` (#8894)

Click to expand commit body
This PR enables the
[`clippy::borrow_deref_ref`](https://rust-lang.github.io/rust-clippy/master/index.html#/borrow_deref_ref)
rule and fixes the outstanding violations.

Release Notes:

- N/A

Marshall Bowers created

a25edcc Add libxcb-devel build dep to void linux script (#8872)

Click to expand commit body
Added missing libxcb-devel to build dependency script for void-linux.

Owen Law created

22fe039 Move Clippy configuration to the workspace level (#8891)

Click to expand commit body
This PR moves the Clippy configuration up to the workspace level.

We're using the [`lints`
table](https://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table)
to configure the Clippy ruleset in the workspace's `Cargo.toml`.

Each crate in the workspace now has the following in their own
`Cargo.toml` to inherit the lints from the workspace:

```toml
[lints]
workspace = true
```

This allows for configuring rust-analyzer to show Clippy lints in the
editor by using the following configuration in your Zed `settings.json`:

```json
{
  "lsp": {
    "rust-analyzer": {
      "initialization_options": {
        "check": {
          "command": "clippy"
        }
      }
    }
  }
```

Release Notes:

- N/A

Marshall Bowers created

52f750b Update blade to latest: work around Intel+NVidia driver bug (#8811)

Click to expand commit body
Picks up https://github.com/kvark/blade/pull/92
Should unblock some of the unhappy users.
Upstream bug - https://gitlab.freedesktop.org/mesa/mesa/-/issues/4688

Release Notes:
- N/A

Dzmitry Malyshau created