1a93870
Only 5s of data! (#8983)
Click to expand commit body
This is still 200Mb in production, and takes several minutes to process and download. Release Notes: - N/A
Conrad Irwin created
1a93870
Only 5s of data! (#8983)
This is still 200Mb in production, and takes several minutes to process and download. Release Notes: - N/A
Conrad Irwin created
4f53e6e
Update cargo.lock
Conrad Irwin created
75a42c2
Migrate from scrypt to sha256. (#8969)
This reduces the server time to compute the hash from 40ms to 5µs, which should remove this as a noticable chunk of CPU time in production. (An attacker who has access to our database will now need only 10^54 years of CPU time instead of 10^58 to brute force a token). Release Notes: - Improved sign in latency by 40ms.
Conrad Irwin created
4d2156e
Improved message hovering in chat panel (#8977)
Highlights messages on hover and fixed a more concise position for the popover menu button. Before: https://github.com/zed-industries/zed/assets/146845123/39cab30f-659f-4164-a4ac-1dfee796e016 <img width="368" alt="Screenshot 2024-03-07 at 01 08 24" src="https://github.com/zed-industries/zed/assets/146845123/74f41243-2dc2-4839-a733-9db3109e4665"> <img width="313" alt="Screenshot 2024-03-07 at 01 04 39" src="https://github.com/zed-industries/zed/assets/146845123/f66c764d-488a-4303-b66e-f75835df6949"> After: https://github.com/zed-industries/zed/assets/146845123/ac059c0d-7b16-4fd5-bbd7-ca96e1a6dfe1 <img width="368" alt="Screenshot 2024-03-07 at 01 09 42" src="https://github.com/zed-industries/zed/assets/146845123/fa8940f6-52b4-489d-b0d3-d0e9443e2de2"> <img width="313" alt="Screenshot 2024-03-07 at 01 04 31" src="https://github.com/zed-industries/zed/assets/146845123/850226f3-2c70-4a90-bb35-4a4cb0b7a219"> Thank you for the help @ConradIrwin and @RemcoSmitsDev ! Release Notes: - Improved message hovering in chat panel
Evren Sen created
9481b34
Fix issue template formatting (#8866)
Release Notes: - N/A Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com>
L and Joseph T. Lyons created
8a92d28
Remove `todo!` comments (#8981)
Switching fully to normal `todo` style Release Notes: - N/A
Mikayla Maki created
8be4b4d
Support emoji shortcodes in chat (#8455)
Completes: https://github.com/zed-industries/zed/issues/7299 Suggestions https://github.com/zed-industries/zed/assets/53836821/2a81ba89-4634-4d94-8370-6f76ff3e9403 Automatically replacing shortcodes without using the completions (only enabled when `message_editor` > `auto_replace_emoji_shortcode` is enabled in the settings): https://github.com/zed-industries/zed/assets/53836821/10ef2b4b-c67b-4202-b958-332a37dc088e Release Notes: - Added autocompletion for emojis in chat when typing emoji shortcodes ([#7299](https://github.com/zed-industries/zed/issues/7299)). - Added support for automatically replacing emoji shortcodes in chat (e.g. typing ":wave:" will be converted to "👋") --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Bennet Bo Fenner and Conrad Irwin created
c0edb5b
GPUI custom window prompts (#8980)
This adds a GPUI fallback for window prompts. Linux does not support this feature by default, so we have to implement it ourselves. This implementation also makes it possible for GPUI clients to override the platform prompts with their own implementations. This is just a first pass. These alerts are not keyboard accessible yet, does not reflect the prompt level, they're implemented in-window, rather than as popups, and the whole feature need a pass from a designer. Regardless, this gets us one step closer to Linux support :) <img width="650" alt="Screenshot 2024-03-06 at 5 58 08 PM" src="https://github.com/zed-industries/zed/assets/2280405/972ebb55-fd1f-4066-969c-a87f63b22a6f"> Release Notes: - N/A
Mikayla Maki created
c8e03ce
Wayland: Support integer scaling without wp_fractional_scale (#8886)
Release Notes: - N/A `DoubleBuffered` is not currently very necessary because we only care about a single field `OutputState::scale` but I think it can be useful for other objects as it's a fairly common pattern in wayland.
bbb651 created
74e7611
windows: get current display size (#8916)
For the moment the windows port has a single display with hard-coded values. This first PR is just to at least fetch the **actual size of the current display**. The idea is using this code as a first template to start getting familar with the code base and prepare the work for enumerating all displays.
intigonzalez created
0b87be7
Make anchor_in_excerpt Optional (#8975)
We were seeing panics due to callers assuming they had valid excerpt_ids, but that cannot easily be guaranteed across await points as anyone may remove an excerpt. Release Notes: - Fixed a panic when hovering in a multibuffer
Conrad Irwin created
ae5ec92
Small fixes to task modal & long commands (#8974)
* Show the entire task tooltip on terminal tab hover: <img width="979" alt="Screenshot 2024-03-07 at 01 40 56" src="https://github.com/zed-industries/zed/assets/2690773/bc274a5c-70f6-4f3d-87b4-04aff3594089"> * Scroll to the end of the query when a menu label is reused as a query: <img width="658" alt="Screenshot 2024-03-07 at 01 41 03" src="https://github.com/zed-industries/zed/assets/2690773/972857f4-36db-49dc-8fa1-dd15e0470660"> Release Notes: - Improved task modal UX with long bash-like commands
Kirill Bulatov created
ca37d39
add a script to get a flamegraph of collab in production (#8972)
Add `./script/collab-flamegraph` so you can profile in production (or staging) Release Notes: - N/A
Conrad Irwin created
675ae24
Add a command for building and installing a locally-developed Zed extension (#8781)
This PR adds an `zed: Install Local Extension` action, which lets you select a path to a folder containing a Zed extension, and install that . When you select a directory, the extension will be compiled (both the Tree-sitter grammars and the Rust code for the extension itself) and installed as a Zed extension, using a symlink. ### Details A few dependencies are needed to build an extension: * The Rust `wasm32-wasi` target. This is automatically installed if needed via `rustup`. * A wasi-preview1 adapter WASM module, for building WASM components with Rust. This is automatically downloaded if needed from a `wasmtime` GitHub release * For building Tree-sitter parsers, a distribution of `wasi-sdk`. This is automatically downloaded if needed from a `wasi-sdk` GitHub release. The downloaded artifacts are cached in a support directory called `Zed/extensions/build`. ### Tasks UX * [x] Show local extensions in the Extensions view * [x] Provide a button for recompiling a linked extension * [x] Make this action discoverable by adding a button for it on the Extensions view * [ ] Surface errors (don't just write them to the Zed log) Packaging * [ ] Create a separate executable that performs the extension compilation. We'll switch the packaging system in our [extensions](https://github.com/zed-industries/extensions) repo to use this binary, so that there is one canonical definition of how to build/package an extensions. ### Release Notes: - N/A --------- Co-authored-by: Marshall <marshall@zed.dev> Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Max Brunsfeld , Marshall , and Marshall Bowers created
e273198
Debounce language server updates (#8953)
We'll send at least one every 100ms, but may send more if other messages are sent on the connection. Release Notes: - Fixed some slowness when collaborating with verbose language servers.
Conrad Irwin created
af87fb9
Implement more GPUI services on windows. (#8940)
### Description This is a part of #8809 , impl the following functions: - `os_version` - `local_timezone` - `double_click_interval` - `set_cursor_style` - `open_url` - `reveal_path` Release Notes: - N/A --------- Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Small White and Mikayla Maki created
effc317
Fix project panel scrolling position restoration (#8961)
Project panel loses the last scrolling position every time the user hides/shows it. This PR fixes the problem. The reason of the problem is that `UniformListScrollHandle`, which is intended to store the scrolling position between redrawings, is only used for ad-hoc autoscrollings to the list items, while the `interactivity.scroll_handle` that is responsible for the scrolling position, doesn't survive the project panel hiding. How the problem looks: https://github.com/zed-industries/zed/assets/2101250/7c7e3da6-9a9d-4f28-a181-ee9547349d4c Release Notes: - Fixed scrolling position restoration in the Project Panel.
Andrew Lygin created
6bbd09e
Emit the WorktreeUpdatedEntries event for all projects, not just local (#8963)
Fixes a regression introduced in https://github.com/zed-industries/zed/pull/8846 (which hasn't yet been released), in which the project panel didn't update correctly for remote projects when collaborating. Release Notes: - N/A
Max Brunsfeld created
06035da
windows: more frequent frame requests (#8921)
Note rust analyzer running in background now without keyboard/mouse movement.  Release Notes: - Improved frame rate on Windows
Ezekiel Warren created
8357039
Set the default DPI awareness for Zed (#8936)
### Description This is a part of #8809 Release Notes: - N/A
Small White created
59faef5
Update `mio` (#8935)
### Description This is a part of #8809 Update mio from 0.8.8 to 0.8.11. When using named pipes on Windows, mio will under some circumstances return invalid tokens that correspond to named pipes that have already been deregistered from the mio registry. The impact of this vulnerability depends on how mio is used. For some applications, invalid tokens may be ignored or cause a warning or a crash. On the other hand, for applications that store pointers in the tokens, this vulnerability may result in a use-after-free. ### Connections [named-pipes: fix receiving IOCP events after deregister #1760](https://github.com/tokio-rs/mio/pull/1760) [Windows Named pipes invalid memory access #6369](https://github.com/tokio-rs/tokio/issues/6369) Release Notes: - N/A
Small White created
a0fac38
prevent empty cwd in terminal view (#8924)
closes #8825 Release Notes: - N/A
Ezekiel Warren created
8352f39
Improve bindings to better match VS-Code (#8584)
Release Notes: - Changed default keybindings in the VS Code keymap so that `alt-[up|down]` now move lines up/down and`alt-shift-[up|down]` duplicate lines up/down. Previous bindings for selecting larger/smaller syntax nodes are now bound to `ctrl-shift-[left|right]`. ([#4652](https://github.com/zed-industries/zed/issues/4652))([#7151](https://github.com/zed-industries/zed/issues/7151)) --------- Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Edvard Høiby and Thorsten Ball created
850dddd
v0.127.x dev
Joseph T. Lyons created
563c4db
Install perf tools in production containers (#8957)
Release Notes: - N/A
Conrad Irwin created
8eb0239
Remove console-subscriber (#8955)
It doubles CPU and RAM usage for not really enough benefit Release Notes: - N/A
Conrad Irwin created
deb86a1
Fix ./script/symbolicate on Preview crashes (#8956)
Release Notes: - N/A
Conrad Irwin created
b622dcb
Enable `clippy::cast_abs_to_unsigned` (#8912)
Thankfully this one is a simple, single change that also prevents overflow in the `abs()`
Kirpal Grewal created
2f15676
Update App Menus to add `...` for some modal action menu, and group menu items by type. (#8951)
Release Notes: - Improved App Menu, add `...` for modal action menu, and group menu items by type. In macOS and Windows, the `...` suffix of menu item, is means that will open a dialog.
Jason Lee created
4a60326
Remove workspace border, avoid the main window having double borders (#8922)
Release Notes: - Fixed main window border, avoid double borders. ## Diff (Left is Before, Right is After)   Reference to Safari:  ## More Theme tests    
Jason Lee created
567fee4
Update `Project search` to `Project Search`. (#8943)
Release notes: - N/A
Jason Lee created
6036830
Throttle the sending of UpdateFollowers messages (#8918)
## Problem We're trying to figure out why we sometimes see high latency when collaborating, even though the collab server logs indicate that messages are not taking long to process. We think that high volumes of certain types of messages, including `UpdateFollowers` may cause a lot of messages to queue up, causing delays before collab sees certain messages. ## Fix This PR reduces the number of `UpdateFollowers` messages that clients send to collab when scrolling around or moving the cursor, using a time-based throttle. The downside of this change is that scrolling will not be as smooth when following someone. The advantage is that it will be much easier to keep up with the stream of updates, since they will be sent much less frequently. ## Release Notes: - Fixed slowness that could occur when collaborating due to excessive messages being sent to support following. --------- Co-authored-by: Nathan <nathan@zed.dev> Co-authored-by: Conrad <conrad@zed.dev> Co-authored-by: Antonio Scandurra <me@as-cii.com> Co-authored-by: Thorsten <thorsten@zed.dev> Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
Max Brunsfeld , Nathan , Conrad , Antonio Scandurra , Thorsten , and Thorsten Ball created
c8383e3
Use a string for ZED_LOAD_BALANCER_SIZE_UNIT in k8s template
Co-Authored-By: Thorsten <thorsten@zed.dev>
Antonio Scandurra and Thorsten created
334c3c6
Use a string for ZED_LOAD_BALANCER_SIZE_UNIT
Co-Authored-By: Thorsten <thorsten@zed.dev>
Antonio Scandurra and Thorsten created
e3a7192
Give a name to load balancers and increase node count for production (#8939)
Release Notes: - N/A Co-authored-by: Thorsten <thorsten@zed.dev>
Antonio Scandurra and Thorsten created
6327f3c
Modify the link to the latest (#8925)
Fixed the link for Vue LSP server Release Notes: - N/A
Hans created
c58422c
Fix YAML indentation
Conrad Irwin created
6d53846
0-downtime collab deploys? (#8926)
Before this change Kubernetes would send a SIGTERM to the old server before the new one was ready. Now it will wait. From my reading it seems like startupProbe should not be necessary if we have a readinessProbe; but from testing it seems like without startupProbe we still drop requests when using `rollout restart` Release Notes: - Fixed connectivity issues during Zed deploys.
Conrad Irwin created
01e5e42
Fix numeric sign of queue duration in logs
Max Brunsfeld created
4de8068
Revert "Install perf on collab image (#8910)"
Keep the removal of the collab resource requests. This reverts commit ce6bde5a242909834341998a49eeb7f95191ff75.
Max Brunsfeld created
ce6bde5
Install perf on collab image (#8910)
Release Notes: - N/A --------- Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld and Conrad created
35c516f
Log the time incoming RPC messages were queued (#8909)
Release Notes: - N/A Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld and Conrad created
bca98ca
Enable `clippy::unnecessary_to_owned` (#8908)
lint for `unnecessary_to_owned` and fix the sole violation in the codebase
Kirpal Grewal created
b68a277
Fix tracing subscriber after introducing Tokio-console (#8907)
We've also upgraded `Axum` in order to avoid having two versions of that library in Collab (one due to Tokio-console). Release Notes: - N/A --------- Co-authored-by: Conrad <conrad@zed.dev>
Max Brunsfeld and Conrad created
703c965
Always resolve code action if needed (#8904)
Follow-up of https://github.com/zed-industries/zed/pull/8874 and https://github.com/zed-industries/zed/pull/7635 Closes https://github.com/zed-industries/zed/issues/7609 * mentions all `lsp::CodeActions` properties in the Zed client resolve capabilities to remove more json out of general actions request potentially * removes odd `CodeActions.data` field checks, as that field is opaque and is intended to store data, needed by the langserver to resolve this code action * if any `CodeAction` lacks either `command` or `edits` fields, tries to resolve the action This all effectively causes Zed to always fire an action resolve request, since we update actions list (replacing the resolved actions with the new, unresolved ones) via `refresh_code_actions` https://github.com/zed-industries/zed/blob/9e66d48ccd3bb87ee97aec4e63484dc8b78e45ac/crates/editor/src/editor.rs#L3650 that is being called on selections change and the actions menu open. Yet, we do not query the resolve until the action is either applied (selected in the list), or called for formatting, so it seems to be fine to resolve them always, as it's not a frequent operation such as reacting to every keystroke. Release Notes: - Fixed certain code actions not being resolved properly ([7609](https://github.com/zed-industries/zed/issues/7609)) --------- Co-authored-by: Derrick Laird <swampdonk@gmail.com>
Kirill Bulatov and Derrick Laird created
addfcde
Enable `clippy::implied_bounds_in_impls` (#8906)
This PR enables the [`clippy::implied_bounds_in_impls`](https://rust-lang.github.io/rust-clippy/master/index.html#/implied_bounds_in_impls) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
d112bcf
Fix project subscription order (#8900)
Co-Authored-By: Antonio <as-cii@zed.dev> Release Notes: - Fixed a bug that prevents project joining Co-authored-by: Antonio <as-cii@zed.dev>
Conrad Irwin and Antonio created
9e66d48
Enable `clippy::cmp_owned` (#8899)
This PR enables the [`clippy::cmp_owned`](https://rust-lang.github.io/rust-clippy/master/index.html#/cmp_owned) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
d98b61e
Improve wording on recent projects placeholder instructions
Joseph T. Lyons created
ad0c573
Update config.yml
Joseph T. Lyons created