Commit log

cbbba41 Reuse line layouts when reusing view

Antonio Scandurra created

8b3f256 Fix invisible symbol colors in the editor, use zed1 one (#4017)

Click to expand commit body
Release Notes:

- Improved the contrast between invisibles colors and the rest of the
text in the editor

Kirill Bulatov created

dd6e2df Show abs path matches in file finder

Kirill Bulatov created

ba83623 Fix whitespace symbol colors in the editor, use zed1 one

Click to expand commit body
co-authored-by: Marshall Bowers <marshall@zed.dev>

Kirill Bulatov and Marshall Bowers created

b342c92 Restore hover action in the editor (#4016)

Click to expand commit body
Deals with https://github.com/zed-industries/community/issues/2304
Deals with https://github.com/zed-industries/community/issues/2394

Release Notes:

- Fixed `editor::Hover` action (and `g h` command in Vim mode) not
working

Kirill Bulatov created

9bb50a5 Restore hover action in the editor

Kirill Bulatov created

18eaefd Reuse cursor style when reusing a view tree

Antonio Scandurra created

4fe0c47 Do not split on only external directories being drag and dropped (#4015)

Click to expand commit body
Release Notes:

- Fixed drag and dropped folders opening an empty split pane

Kirill Bulatov created

75cb409 Instrument edit events (#4006)

Click to expand commit body
The goal of this PR is to send up events that contain the duration of
keyboard activity within Zed. I built the `EventCoalescer`, which gets
called called each time a key is pressed, within any environment (in the
case of this PR, within "editor" and "terminal). The" `EventCoalescer`
holds a start and end DateTime and adjusts the end instant as events
come in, until a timeout from the last event is hit.

I did my best to keep this mechanism efficient (avoiding vectors to
store moments in time, avoiding spawning timers threads, etc.), because
I know this is going to be per keystroke, but its behind a lock on the
telemetry struck, since it has to know when the environment changes, in
which point, it will automatically end the activity period, even if
there is no timeout. Because we have to have access to it from different
parts of the system, we have to go through the lock, which worried me a
bit (@mikayla-maki's intuition is that it should be fine).

As for the event, I take the time between the durations reported by the
event coalescer and send that up to zed - the indention is to
reconstruct the start and end times on zed.dev, in the same way we use
the event offset times and the time on zed.dev to get the official event
timestamp, and avoid the issue of the user having their system clocks
set wrong.

I'd really appreciate it if @nathansobo or @maxbrunsfeld could check
this out.

Release Notes:

- N/A

Joseph T. Lyons created

2e36b0b Do not split on only external directories being drag and dropped

Kirill Bulatov created

a33be89 chore: Revert asset compression

Click to expand commit body
While it does reduce the size of a binary quite significantly, it doesn't seem to matter for .dmg which runs it's own compression on top of binaries.

Piotr Osiewicz created

348bc84 Enforce no dbg! and todo! in Rust code via clippy lints in the CI job (#4005)

Click to expand commit body
Release Notes:

- N/A

Kirill Bulatov created

50ccdf5 Reuse input handler when reusing a view tree

Antonio Scandurra created

41bc49a Remove redundant install Rust steps

Click to expand commit body
Those were not installing Rust but configuring it via rustup, and
those configurations were done on `stable` toolchain which is not what we use (see rust-toolchain.toml)

co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

a5dd253 Properly require clippy installation, try to shuffle clippy arguments

Click to expand commit body
co-authored-by: Piotr <piotr@zed.dev>

Kirill Bulatov and Piotr created

d088ace Explicitly push a node in the dispatch tree when painting a new view

Antonio Scandurra created

1200f59 Try to run clippy just for a single target

Piotr Osiewicz created

142a8b6 Avoid casting view ids to u32

Click to expand commit body
Also, it looks like using a u64 directly doesn't work well with Metal
shaders, so we unpack the u64 into two u32s.

Antonio Scandurra created

0db7559 editor: extend diff hunk range for custom transform blocks. (#4012)

Click to expand commit body
Reported by Mikayla:

![image](https://github.com/zed-industries/zed/assets/24362066/b744d82e-328f-4554-becf-96f9fa92bfc8)
Note how the line with rust analyzer error does not have a git diff
hunk.
vs:

![image](https://github.com/zed-industries/zed/assets/24362066/e285af7a-b8ab-40e9-a9c6-b4ab8d6c4cd0)

Release Notes:
- N/A

Piotr Osiewicz created

6503dd5 enviroment -> environment

Mikayla created

0df4bfa Increase debug mode queue size

Joseph T. Lyons created

8a61d50 Never send an an empty set of events

Joseph T. Lyons created

f418bd9 Stop following when project is unshared

Click to expand commit body
Before this change the views would continue to update in the background
of the "disconnected" dialogue, which was disconcerting.

Conrad Irwin created

31689c0 Uncomment last tests (#4009)

Click to expand commit body
With this, we're done all known things that need porting. 

Release Notes:

-

Mikayla Maki created

83163a0 Reverse context arrays in child predicate test

Mikayla created

38396d4 Add remaining tests

Click to expand commit body
co-authored-by: Conrad <conrad@zed.dev>

Mikayla and Conrad created

a5ca583 Fix first few asserts

Mikayla created

bddf827 Add reminder for the future

Joseph T. Lyons created

4496946 Remove remaining port related todos (#3994)

Click to expand commit body
TODO:
- [x] Audit all TODO comments in Zed source and mark port related ones
with a !
- [x] Resolve all todos written as `todo!`

Release Notes:

- N/A

Mikayla Maki created

cb5d4ed Handle reconnects to the livekit server in which local tracks are unpublished (#3992)

Click to expand commit body
Release notes:

* Fixed a bug where network interruptions could cause audio and screen
sharing to stop working without indicating that they were stopped, and
there was no way to restart the audio stream.

Max Brunsfeld created

1932a29 Add back ime_key

Mikayla created

75fdaeb Detect when a track is unpublished due to reconnecting to livekit

Click to expand commit body
Co-authored-by: Julia <julia@zed.dev>

Max Brunsfeld and Julia created

2d1eb0c Expose a single `updates` stream from live_kit_client::Room

Click to expand commit body
Co-authored-by: Julia <julia@zed.dev>

Max Brunsfeld and Julia created

0dca67f Add --top flag to zed-local script, for making windows take up half the screen

Max Brunsfeld created

b907f37 Fix fold-related panic (#4008)

Click to expand commit body
Although it's not super clear why this fails; in zed1 we used to have a
bounds
check. Restoring the bounds check for now, but leaving a debug_assert!
in case
a local reproduction happens.

Release Notes:

- Fix a panic that happened sometimes when rendering folds

Conrad Irwin created

766a869 Fix fold-related panic

Conrad Irwin created

b4444bd Rename field in telemetry struct

Joseph T. Lyons created

3c1ed15 Remove active call data when it was accepted (#4007)

Click to expand commit body
That hopefully helps with call notifications sometimes not being closed

Release Notes:

- N/A

Kirill Bulatov created

2e9c9ad Remove active call data when it was accepted

Click to expand commit body
That hopefully helps with call notifications sometimes not being closed

co-authored-by: Max <max@zed.dev>

Kirill Bulatov and Max created

e0dd5a5 Debugging

Kirill Bulatov created

7b3e7ee Enfoce no dbg! and todo! in Rust code via clippy lints in the CI job

Kirill Bulatov created

a4ef1bc Rename reuse_geometry to reuse_view

Antonio Scandurra created

9df29fb WIP

Joseph T. Lyons created

1c260e6 Merge remote-tracking branch 'origin/main' into cache

Click to expand commit body
# Conflicts:
#	crates/copilot/src/sign_in.rs
#	crates/gpui/src/window.rs
#	crates/workspace/src/pane_group.rs

Antonio Scandurra created

b26a468 Merge branch 'main' into instrument-keyboard-events

Joseph T. Lyons created

f71a0cd Remove last todos

Mikayla created

4bcac68 Restore GPUI test

Mikayla created

9553759 Remove todo from search tests

Piotr Osiewicz created

7ef8839 Fix seg fault when using the WindowContext::on_window_should_close() API

Mikayla created

2a09c6a Restore missing test

Mikayla created