20d1333
Fix some comments (#8760)
Click to expand commit body
Release Notes: - N/A Signed-off-by: geekvest <cuimoman@sohu.com>
geekvest created
20d1333
Fix some comments (#8760)
Release Notes: - N/A Signed-off-by: geekvest <cuimoman@sohu.com>
geekvest created
a6dbaac
Enable `clippy::needless_question_mark` (#8759)
This PR enables the [`clippy::needless_question_mark`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_question_mark) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
33790b8
Enable `clippy::useless_format` (#8758)
This PR enables the [`clippy::useless_format`](https://rust-lang.github.io/rust-clippy/master/index.html#/useless_format) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
373e18b
Enable `clippy::unnecessary_unwrap` (#8756)
This PR enables the [`clippy::unnecessary_unwrap`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_unwrap) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
191fcf6
Enable `clippy::nonminimal_bool` (#8755)
This PR enables the [`clippy::nonminimal_bool`](https://rust-lang.github.io/rust-clippy/master/index.html#/nonminimal_bool) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
2f87647
Enable `clippy::extra_unused_lifetimes` (#8754)
This PR enables the [`clippy::extra_unused_lifetimes`](https://rust-lang.github.io/rust-clippy/master/index.html#/extra_unused_lifetimes) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
6599744
Enable `clippy::explicit_auto_deref` (#8753)
This PR enables the [`clippy::explicit_auto_deref`](https://rust-lang.github.io/rust-clippy/master/index.html#/explicit_auto_deref) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
6a9e8fa
Enable `clippy::unnecessary_operation` (#8752)
This PR enables the [`clippy::unnecessary_operation`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_operation) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
ea68f86
Enable `clippy::option_map_unit_fn` (#8751)
This PR enables the [`clippy::option_map_unit_fn`](https://rust-lang.github.io/rust-clippy/master/index.html#/option_map_unit_fn) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
d19957b
Enable `clippy::redundant_locals` (#8750)
This PR enables the [`clippy::redundant_locals`](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_locals) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
328c8a9
Enable `clippy::search_is_some` (#8748)
This PR enables the [`clippy::search_is_some`](https://rust-lang.github.io/rust-clippy/master/index.html#/search_is_some) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
3ab16d8
Enable `clippy::option_as_ref_deref` (#8747)
This PR enables the [`clippy::option_as_ref_deref`](https://rust-lang.github.io/rust-clippy/master/index.html#/option_as_ref_deref) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
ca9d5a2
Enable `clippy::needless_borrowed_reference` (#8746)
This PR enables the [`clippy::needless_borrowed_reference`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_borrowed_reference) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
bd00aed
Enable `clippy::drain_collect` (#8745)
This PR enables the [`clippy::drain_collect`](https://rust-lang.github.io/rust-clippy/master/index.html#/drain_collect) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
4097e88
Enable `clippy::needless_arbitrary_self_type` (#8743)
This PR enables the [`clippy::needless_arbitrary_self_type`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_arbitrary_self_type) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
008c505
Enable `clippy::unit_arg` (#8742)
This PR enables the [`clippy::unit_arg`](https://rust-lang.github.io/rust-clippy/master/index.html#/unit_arg) rule and suppresses the false positive that it flags. Release Notes: - N/A
Marshall Bowers created
2bfc646
Enable `clippy::filter_map_identity` (#8741)
This PR enables the [`clippy::filter_map_identity`](https://rust-lang.github.io/rust-clippy/master/index.html#/filter_map_identity) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
3e28791
Enable `clippy::unnecessary_find_map` (#8740)
This PR enables the [`clippy::unnecessary_find_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_find_map) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
503beba
Enable `clippy::manual_flatten` (#8739)
This PR enables the [`clippy::manual_flatten`](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_flatten) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
f79f56f
Enable `clippy::unnecessary_filter_map` (#8738)
This PR enables the [`clippy::unnecessary_filter_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/unnecessary_filter_map) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
a17c207
Enable `clippy::manual_find` (#8737)
This PR enables the [`clippy::manual_find`](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_find) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
fc8e515
Enable `clippy::too_many_arguments` (#8734)
This PR enables the [`clippy::too_many_arguments`](https://rust-lang.github.io/rust-clippy/master/index.html#/too_many_arguments) rule. I opted to add `#[allow(clippy::too_many_arguments)]` on the individual violations, as reworking them to take fewer arguments is a more involved task. Release Notes: - N/A
Marshall Bowers created
eaf2fbb
Enable `clippy::map_flatten` (#8733)
This PR enables the [`clippy::map_flatten`](https://rust-lang.github.io/rust-clippy/master/index.html#/map_flatten) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
8bc35c3
Enable `clippy::to_string_in_format_args` (#8732)
This PR enables the [`clippy::to_string_in_format_args`](https://rust-lang.github.io/rust-clippy/master/index.html#/to_string_in_format_args) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
52052f3
Enable `clippy::map_identity` (#8731)
This PR enables the [`clippy::map_identity`](https://rust-lang.github.io/rust-clippy/master/index.html#/map_identity) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
d7962aa
Add license to Gleam extension (#8730)
This PR adds a license to the Gleam extension crate, since the bundling script was unhappy that it didn't have one. Since extensions like this one may ultimately live outside of Zed itself, I went with the Apache 2.0 license. Release Notes: - N/A
Marshall Bowers created
9735912
Enable `clippy::clone_on_copy` (#8728)
This PR enables the [`clippy::clone_on_copy`](https://rust-lang.github.io/rust-clippy/master/index.html#/clone_on_copy) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
5935681
Enable `clippy::single_char_pattern` (#8727)
This PR enables the [`clippy::single_char_pattern`](https://rust-lang.github.io/rust-clippy/master/index.html#/single_char_pattern) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
12440d5
terminal: Make `rgb_for_index` take a `u8` instead of a `&u8` (#8726)
This PR makes the `rgb_for_index` take a `u8` instead of a `&u8`. `u8` is `Copy` and is only 1 byte, so there really isn't any reason to pass a reference to it. Release Notes: - N/A
Marshall Bowers created
4b81b15
Enable `clippy::useless_conversion` (#8724)
This PR enables the [`clippy::useless_conversion`](https://rust-lang.github.io/rust-clippy/master/index.html#/useless_conversion) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
87efb75
Enable `clippy::bind_instead_of_map` (#8723)
This PR enables the [`clippy::bind_instead_of_map`](https://rust-lang.github.io/rust-clippy/master/index.html#/bind_instead_of_map) rule and fixes the outstanding violations. Release Notes: - N/A
Marshall Bowers created
bf666af
Deny all Clippy warnings (#8720)
This PR makes Clippy deny all warnings across the workspace. We now enumerate all of the rules that have violations and temporarily allow them, with the goal being to drive the list down over time. On Windows we don't yet use `--deny warnings`, as the Windows build still has some warnings. Release Notes: - N/A
Marshall Bowers created
c9a509c
Add `cargo xtask clippy` (#8722)
This PR sets up a `cargo xtask clippy` command for running `cargo clippy` with our defined set of options. The intent is to make this easier to manage as we start enabling more Clippy rules. Release Notes: - N/A
Marshall Bowers created
c19587d
Fix Clippy warnings in `util` crate (#8721)
This PR fixes a number of Clippy warnings in the `util` crate. Release Notes: - N/A
Marshall Bowers created
0ac203b
Fix Clippy warnings in `client` crate (#8719)
This PR fixes a number of Clippy warnings in the `client` crate. Release Notes: - N/A
Marshall Bowers created
5de7492
Add flex_wrap_* and content_* to GPUI (#8710)
Now with GPUI you can auto-layout something like this: <img width="560" alt="Screenshot 2024-03-02 at 13 56 50" src="https://github.com/zed-industries/zed/assets/226244/8ec4b683-dd7d-41f8-8b09-4be66ecec9a0">
Tommi Pisto created
f9dc871
Fix Clippy warnings in `theme` crate (#8715)
This PR fixes a number of Clippy warnings in the `theme` crate. Release Notes: - N/A
Marshall Bowers created
6fcd57a
Expose more errors from rust-analyzer on invalid Cargo.toml contents (#8356)
Release Notes: - Fixed ([#7574](https://github.com/zed-industries/zed/issues/7574)).
Zephaniah Ong created
0903062
Fix unsafe precondition violation when building with nightly `rustc` (#8691)
Fixes #8658 Release Notes: - N/A
Liam Murphy created
e5e6c7f
Fix Clippy warnings in `fuzzy` crate (#8701)
This PR fixes a number of Clippy warnings in the `fuzzy` crate. Release Notes: - N/A
Marshall Bowers created
ca2cda8
Remove unneeded `'static` lifetimes on `&str`s in constants (#8698)
This PR removes unneeded `'static` lifetimes on `&str`s stored in `const` declarations. This addresses some Clippy lints about [`redundant_static_lifetimes`](https://rust-lang.github.io/rust-clippy/master/index.html#/redundant_static_lifetimes). In item-level `const` declarations we can rely on lifetime elision and use the default `'static` lifetime. Note that associated constants still require an explicit `'static` lifetime, as explained in https://github.com/rust-lang/rust/issues/115010. Release Notes: - N/A
Marshall Bowers created
5c2bd81
Fix Clippy warnings in `settings` crate (#8700)
This PR fixes a number of Clippy warnings in the `settings` crate. Release Notes: - N/A
Marshall Bowers created
26fdd14
Fix Clippy warnings in `fs` (#8696)
This PR fixes various Clippy warnings in the `fs` crate. Release Notes: - N/A
Marshall Bowers created
486f0ae
Remove `expect`s when constructing Clickhouse client (#8697)
This PR removes the `expect`s when constructing the Clickhouse client while still retaining the less-noisy behavior from before. Release Notes: - N/A
Marshall Bowers created
cfe90c3
Document `release_channel` crate (#8695)
This PR documents the `release_channel` crate. Release Notes: - N/A
Marshall Bowers created
e3608af
Use long flags in `script/clippy` for readability (#8694)
This PR modifies the `script/clippy` script to use long flags, as these are better for readability. Release Notes: - N/A
Marshall Bowers created
8c3ae8b
Upgrade `bitflags` to v2.4.2 (#8693)
This PR upgrades our [`bitflags`](https://crates.io/crates/bitflags)
dependency to v2.4.2.
This also fixes an error that was seen when running `clippy`:
```
error: &-masking with zero
--> crates/fsevent/src/fsevent.rs:19:1
|
19 | / bitflags! {
20 | | #[repr(C)]
21 | | pub struct StreamFlags: u32 {
22 | | const NONE = 0x00000000;
... |
46 | | }
47 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask
= note: `#[deny(clippy::bad_bit_mask)]` on by default
= note: this error originates in the macro `__impl_bitflags` which comes from the expansion of the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info)
```
Fixes #8681.
Release Notes:
- N/A
Marshall Bowers created
b2cc617
Allow overriding player colors via `experimental.theme_overrides` (#8692)
This PR extends the `experimental.theme_overrides` to allow overriding the player colors. Release Notes: - Added the ability to override player colors using `experimenta.theme_overrides`.
Marshall Bowers created
a84a3c0
docs: Fix "it's" typos that should be "its" (#8690)
These all meant to use the possessive "its" rather than the contraction of "it is".
Brian Donovan created
03f1805
Add Void Linux support to `script/linux` (#8664)
add support for the xbps package manager in the system library setup script
aryal created